You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Bertil Chapuis (JIRA)" <ji...@apache.org> on 2008/09/09 12:19:44 UTC
[jira] Created: (SLING-651) Extending the SlingPostServlet with
SlingPostOperations
Extending the SlingPostServlet with SlingPostOperations
-------------------------------------------------------
Key: SLING-651
URL: https://issues.apache.org/jira/browse/SLING-651
Project: Sling
Issue Type: Bug
Components: Servlets Post
Affects Versions: Servlets Post 2.0.2
Reporter: Bertil Chapuis
As described in the documentation (http://incubator.apache.org/sling/site/manipulating-content-the-slingpostservlet.html), it should be possible to extend the SlingPostServlet with SlingPostOperations. However, in the SlingPostServlet, no methods allow to bind new operations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-651) Extending the SlingPostServlet with
SlingPostOperations
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677287#action_12677287 ]
Felix Meschberger commented on SLING-651:
-----------------------------------------
Added the sample post servlet extension to the samples in Rev. 748433 (thanks bertil)
Since our restructuration, the launchpad/testing only contains the tests for the bundles in the bundles subtree. I cannot
apply the test extensions to the contrib/launchpad/testing either, since the samples may or may not be present during a contrib build.
Maybe we might have to add a separate integration testing for the samples ??
> Extending the SlingPostServlet with SlingPostOperations
> -------------------------------------------------------
>
> Key: SLING-651
> URL: https://issues.apache.org/jira/browse/SLING-651
> Project: Sling
> Issue Type: Bug
> Components: Servlets Post
> Affects Versions: Servlets Post 2.0.2
> Reporter: Bertil Chapuis
> Assignee: Felix Meschberger
> Priority: Minor
> Fix For: Servlets Post 2.0.4
>
> Attachments: FixedSlingPostServlet.diff, samples.diff, samples.diff, SlingPostServlet.diff
>
>
> As described in the documentation (http://incubator.apache.org/sling/site/manipulating-content-the-slingpostservlet.html), it should be possible to extend the SlingPostServlet with SlingPostOperations. However, in the SlingPostServlet, no methods allow to bind new operations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-651) Extending the SlingPostServlet with
SlingPostOperations
Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertil Chapuis updated SLING-651:
---------------------------------
Attachment: SlingPostServlet.diff
This should fix the issue.
> Extending the SlingPostServlet with SlingPostOperations
> -------------------------------------------------------
>
> Key: SLING-651
> URL: https://issues.apache.org/jira/browse/SLING-651
> Project: Sling
> Issue Type: Bug
> Components: Servlets Post
> Affects Versions: Servlets Post 2.0.2
> Reporter: Bertil Chapuis
> Attachments: SlingPostServlet.diff
>
>
> As described in the documentation (http://incubator.apache.org/sling/site/manipulating-content-the-slingpostservlet.html), it should be possible to extend the SlingPostServlet with SlingPostOperations. However, in the SlingPostServlet, no methods allow to bind new operations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-651) Extending the SlingPostServlet with
SlingPostOperations
Posted by "Eric Norman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Norman updated SLING-651:
------------------------------
Attachment: FixedSlingPostServlet.diff
Updated the patch to fix the problems with the bundle startup order.
> Extending the SlingPostServlet with SlingPostOperations
> -------------------------------------------------------
>
> Key: SLING-651
> URL: https://issues.apache.org/jira/browse/SLING-651
> Project: Sling
> Issue Type: Bug
> Components: Servlets Post
> Affects Versions: Servlets Post 2.0.2
> Reporter: Bertil Chapuis
> Priority: Minor
> Attachments: FixedSlingPostServlet.diff, samples.diff, samples.diff, SlingPostServlet.diff
>
>
> As described in the documentation (http://incubator.apache.org/sling/site/manipulating-content-the-slingpostservlet.html), it should be possible to extend the SlingPostServlet with SlingPostOperations. However, in the SlingPostServlet, no methods allow to bind new operations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-651) Extending the SlingPostServlet with
SlingPostOperations
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertrand Delacretaz reassigned SLING-651:
-----------------------------------------
Assignee: Bertrand Delacretaz
> Extending the SlingPostServlet with SlingPostOperations
> -------------------------------------------------------
>
> Key: SLING-651
> URL: https://issues.apache.org/jira/browse/SLING-651
> Project: Sling
> Issue Type: Bug
> Components: Servlets Post
> Affects Versions: Servlets Post 2.0.2
> Reporter: Bertil Chapuis
> Assignee: Bertrand Delacretaz
> Priority: Minor
> Attachments: samples.diff, SlingPostServlet.diff
>
>
> As described in the documentation (http://incubator.apache.org/sling/site/manipulating-content-the-slingpostservlet.html), it should be possible to extend the SlingPostServlet with SlingPostOperations. However, in the SlingPostServlet, no methods allow to bind new operations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-651) Extending the SlingPostServlet with
SlingPostOperations
Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertil Chapuis updated SLING-651:
---------------------------------
Priority: Minor (was: Major)
> Extending the SlingPostServlet with SlingPostOperations
> -------------------------------------------------------
>
> Key: SLING-651
> URL: https://issues.apache.org/jira/browse/SLING-651
> Project: Sling
> Issue Type: Bug
> Components: Servlets Post
> Affects Versions: Servlets Post 2.0.2
> Reporter: Bertil Chapuis
> Priority: Minor
> Attachments: SlingPostServlet.diff
>
>
> As described in the documentation (http://incubator.apache.org/sling/site/manipulating-content-the-slingpostservlet.html), it should be possible to extend the SlingPostServlet with SlingPostOperations. However, in the SlingPostServlet, no methods allow to bind new operations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-651) Extending the SlingPostServlet with
SlingPostOperations
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629453#action_12629453 ]
Bertrand Delacretaz commented on SLING-651:
-------------------------------------------
Could you provide some test cases for that?
The easiest way to test this might be a test bundle that is loaded by the launchpad/testing module, and provides some additional SlingPostOperation services that can be tested by the integration tests.
> Extending the SlingPostServlet with SlingPostOperations
> -------------------------------------------------------
>
> Key: SLING-651
> URL: https://issues.apache.org/jira/browse/SLING-651
> Project: Sling
> Issue Type: Bug
> Components: Servlets Post
> Affects Versions: Servlets Post 2.0.2
> Reporter: Bertil Chapuis
> Priority: Minor
> Attachments: SlingPostServlet.diff
>
>
> As described in the documentation (http://incubator.apache.org/sling/site/manipulating-content-the-slingpostservlet.html), it should be possible to extend the SlingPostServlet with SlingPostOperations. However, in the SlingPostServlet, no methods allow to bind new operations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-651) Extending the SlingPostServlet with
SlingPostOperations
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reassigned SLING-651:
---------------------------------------
Assignee: Felix Meschberger
> Extending the SlingPostServlet with SlingPostOperations
> -------------------------------------------------------
>
> Key: SLING-651
> URL: https://issues.apache.org/jira/browse/SLING-651
> Project: Sling
> Issue Type: Bug
> Components: Servlets Post
> Affects Versions: Servlets Post 2.0.2
> Reporter: Bertil Chapuis
> Assignee: Felix Meschberger
> Priority: Minor
> Attachments: FixedSlingPostServlet.diff, samples.diff, samples.diff, SlingPostServlet.diff
>
>
> As described in the documentation (http://incubator.apache.org/sling/site/manipulating-content-the-slingpostservlet.html), it should be possible to extend the SlingPostServlet with SlingPostOperations. However, in the SlingPostServlet, no methods allow to bind new operations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-651) Extending the SlingPostServlet with
SlingPostOperations
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-651:
------------------------------------
Fix Version/s: Servlets Post 2.0.4
> Extending the SlingPostServlet with SlingPostOperations
> -------------------------------------------------------
>
> Key: SLING-651
> URL: https://issues.apache.org/jira/browse/SLING-651
> Project: Sling
> Issue Type: Bug
> Components: Servlets Post
> Affects Versions: Servlets Post 2.0.2
> Reporter: Bertil Chapuis
> Assignee: Felix Meschberger
> Priority: Minor
> Fix For: Servlets Post 2.0.4
>
> Attachments: FixedSlingPostServlet.diff, samples.diff, samples.diff, SlingPostServlet.diff
>
>
> As described in the documentation (http://incubator.apache.org/sling/site/manipulating-content-the-slingpostservlet.html), it should be possible to extend the SlingPostServlet with SlingPostOperations. However, in the SlingPostServlet, no methods allow to bind new operations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-651) Extending the SlingPostServlet with
SlingPostOperations
Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertil Chapuis updated SLING-651:
---------------------------------
Attachment: samples.diff
new version wich take into account the comments.
> Extending the SlingPostServlet with SlingPostOperations
> -------------------------------------------------------
>
> Key: SLING-651
> URL: https://issues.apache.org/jira/browse/SLING-651
> Project: Sling
> Issue Type: Bug
> Components: Servlets Post
> Affects Versions: Servlets Post 2.0.2
> Reporter: Bertil Chapuis
> Priority: Minor
> Attachments: samples.diff, samples.diff, SlingPostServlet.diff
>
>
> As described in the documentation (http://incubator.apache.org/sling/site/manipulating-content-the-slingpostservlet.html), it should be possible to extend the SlingPostServlet with SlingPostOperations. However, in the SlingPostServlet, no methods allow to bind new operations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-651) Extending the SlingPostServlet with
SlingPostOperations
Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertil Chapuis updated SLING-651:
---------------------------------
Attachment: samples.diff
For the test, I finally have create two sample bundle (PostProcessor and PostOperation) which are used by the integration tests.
> Extending the SlingPostServlet with SlingPostOperations
> -------------------------------------------------------
>
> Key: SLING-651
> URL: https://issues.apache.org/jira/browse/SLING-651
> Project: Sling
> Issue Type: Bug
> Components: Servlets Post
> Affects Versions: Servlets Post 2.0.2
> Reporter: Bertil Chapuis
> Priority: Minor
> Attachments: samples.diff, SlingPostServlet.diff
>
>
> As described in the documentation (http://incubator.apache.org/sling/site/manipulating-content-the-slingpostservlet.html), it should be possible to extend the SlingPostServlet with SlingPostOperations. However, in the SlingPostServlet, no methods allow to bind new operations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-651) Extending the SlingPostServlet with
SlingPostOperations
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger resolved SLING-651.
-------------------------------------
Resolution: Fixed
I think, this can be closed.
> Extending the SlingPostServlet with SlingPostOperations
> -------------------------------------------------------
>
> Key: SLING-651
> URL: https://issues.apache.org/jira/browse/SLING-651
> Project: Sling
> Issue Type: Bug
> Components: Servlets Post
> Affects Versions: Servlets Post 2.0.2
> Reporter: Bertil Chapuis
> Assignee: Felix Meschberger
> Priority: Minor
> Fix For: Servlets Post 2.0.4
>
> Attachments: FixedSlingPostServlet.diff, samples.diff, samples.diff, SlingPostServlet.diff
>
>
> As described in the documentation (http://incubator.apache.org/sling/site/manipulating-content-the-slingpostservlet.html), it should be possible to extend the SlingPostServlet with SlingPostOperations. However, in the SlingPostServlet, no methods allow to bind new operations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-651) Extending the SlingPostServlet with
SlingPostOperations
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677282#action_12677282 ]
Felix Meschberger commented on SLING-651:
-----------------------------------------
Thanks Eric for the fixed patch. I have applied it in Rev. 748426.
> Extending the SlingPostServlet with SlingPostOperations
> -------------------------------------------------------
>
> Key: SLING-651
> URL: https://issues.apache.org/jira/browse/SLING-651
> Project: Sling
> Issue Type: Bug
> Components: Servlets Post
> Affects Versions: Servlets Post 2.0.2
> Reporter: Bertil Chapuis
> Assignee: Felix Meschberger
> Priority: Minor
> Attachments: FixedSlingPostServlet.diff, samples.diff, samples.diff, SlingPostServlet.diff
>
>
> As described in the documentation (http://incubator.apache.org/sling/site/manipulating-content-the-slingpostservlet.html), it should be possible to extend the SlingPostServlet with SlingPostOperations. However, in the SlingPostServlet, no methods allow to bind new operations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-651) Extending the SlingPostServlet with
SlingPostOperations
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633651#action_12633651 ]
Bertrand Delacretaz commented on SLING-651:
-------------------------------------------
The SlingPostServletTest fails if the "Sling - Post servlet extensions" bundle is started before the Sling POST servlet bundle.
To reproduce:
-Start launchpad/testing with "mvn jetty:run"
-In another terminal run " mvn test -Dtest=SlingPostServletTest" in the same folder
-The test might pass or fail depending on startup order of the bundles
-Stop both "Sling - Default POST Servlets" and "Sling - Post servlet extensions" bundles
-Restart "Sling - Post servlet extensions", and later "Sling - Default POST Servlets"
The test fails.
The SlingPostServlet should account for post operations services that are activated while the SlingPostServlet is inactive.
Other nitpicks:
-Typo in the module name, it's "extensions" not "extentions"
-Apache license missing from the LinkHelper class, and that class does not need to be public
-Changes to the servlets/post/pom.xml are not needed
-In SlingPostServlet test I think you can replace this with the superclass's getContent method:
final GetMethod getSource = new GetMethod(urlSource);
final int statusSource = httpClient.executeMethod(getSource);
assertEquals(urlSource + " must be accessible", 200, statusSource);
final String responseSourceBodyStr = getSource.getResponseBodyAsString();
-If SlingPostServlet test extends RenderingTestBase you could use that class's assertContains() method instead of "assertTrue(responseTargetBodyStr.contains(target))", that would give better failure messages.
> Extending the SlingPostServlet with SlingPostOperations
> -------------------------------------------------------
>
> Key: SLING-651
> URL: https://issues.apache.org/jira/browse/SLING-651
> Project: Sling
> Issue Type: Bug
> Components: Servlets Post
> Affects Versions: Servlets Post 2.0.2
> Reporter: Bertil Chapuis
> Assignee: Bertrand Delacretaz
> Priority: Minor
> Attachments: samples.diff, SlingPostServlet.diff
>
>
> As described in the documentation (http://incubator.apache.org/sling/site/manipulating-content-the-slingpostservlet.html), it should be possible to extend the SlingPostServlet with SlingPostOperations. However, in the SlingPostServlet, no methods allow to bind new operations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-651) Extending the SlingPostServlet with
SlingPostOperations
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertrand Delacretaz reassigned SLING-651:
-----------------------------------------
Assignee: (was: Bertrand Delacretaz)
> Extending the SlingPostServlet with SlingPostOperations
> -------------------------------------------------------
>
> Key: SLING-651
> URL: https://issues.apache.org/jira/browse/SLING-651
> Project: Sling
> Issue Type: Bug
> Components: Servlets Post
> Affects Versions: Servlets Post 2.0.2
> Reporter: Bertil Chapuis
> Priority: Minor
> Attachments: samples.diff, SlingPostServlet.diff
>
>
> As described in the documentation (http://incubator.apache.org/sling/site/manipulating-content-the-slingpostservlet.html), it should be possible to extend the SlingPostServlet with SlingPostOperations. However, in the SlingPostServlet, no methods allow to bind new operations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.