You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/22 08:42:11 UTC

[GitHub] [flink] zzzzzzzs opened a new pull request, #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

zzzzzzzs opened a new pull request, #20342:
URL: https://github.com/apache/flink/pull/20342

   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   Add `translate(expr, from, to)` SQL function.
   Examples:
   ```sql
   > SELECT translate('AaBbCc', 'abc', '123');
    A1B2C3
   > SELECT translate('AaBbCc', 'abc', '1');
    A1BC
   > SELECT translate('AaBbCc', 'abc', '');
    ABC 
   ```
   
   ## Brief change log
   
   - Add translate method to SqlFunctionUtils.java
   - Add related expression, convert rule, and code gen.
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as ScalarFunctionsTest#testTranslate.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (docs)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] snuyanzin commented on a diff in pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
snuyanzin commented on code in PR #20342:
URL: https://github.com/apache/flink/pull/20342#discussion_r968172962


##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java:
##########
@@ -371,6 +371,11 @@ public static String repeat(String str, int repeat) {
         return EncodingUtils.repeat(str, repeat);
     }
 
+    /** Returns an expr where all characters in from have been replaced with those in to. */
+    public static String translate3(String str, String search, String replacement) {
+        return org.apache.commons.lang3.StringUtils.replaceChars(str, search, replacement);

Review Comment:
   Could you please clarify what is the reason to use `StringUtils#replaceChars` instead of `replace` from this class?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zzzzzzzs commented on pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
zzzzzzzs commented on PR #20342:
URL: https://github.com/apache/flink/pull/20342#issuecomment-1192603439

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] snuyanzin commented on a diff in pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
snuyanzin commented on code in PR #20342:
URL: https://github.com/apache/flink/pull/20342#discussion_r968170353


##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala:
##########
@@ -282,6 +282,13 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
       "NULL")
   }
 
+  @Test
+  def testTranslate(): Unit = {
+    testSqlApi("translate('AaBbCc', 'abc', '123')", "A1B2C3")

Review Comment:
   Would be great to see also negative tests like with wrong amount of arguments or wrong argument types.
   Or what happen if the last argument has length more than the second?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zzzzzzzs commented on pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
zzzzzzzs commented on PR #20342:
URL: https://github.com/apache/flink/pull/20342#issuecomment-1192674314

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zzzzzzzs commented on a diff in pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
zzzzzzzs commented on code in PR #20342:
URL: https://github.com/apache/flink/pull/20342#discussion_r969201461


##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala:
##########
@@ -282,6 +282,13 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
       "NULL")
   }
 
+  @Test
+  def testTranslate(): Unit = {
+    testSqlApi("translate('AaBbCc', 'abc', '123')", "A1B2C3")

Review Comment:
   Add translate unit tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zzzzzzzs commented on pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
zzzzzzzs commented on PR #20342:
URL: https://github.com/apache/flink/pull/20342#issuecomment-1193036846

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] snuyanzin commented on a diff in pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
snuyanzin commented on code in PR #20342:
URL: https://github.com/apache/flink/pull/20342#discussion_r968170353


##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala:
##########
@@ -282,6 +282,13 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
       "NULL")
   }
 
+  @Test
+  def testTranslate(): Unit = {
+    testSqlApi("translate('AaBbCc', 'abc', '123')", "A1B2C3")

Review Comment:
   Would be great to see also negative tests like with wrong amount of arguments or wrong argument types



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] snuyanzin commented on a diff in pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #20342:
URL: https://github.com/apache/flink/pull/20342#discussion_r1154293981


##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java:
##########
@@ -371,6 +371,11 @@ public static String repeat(String str, int repeat) {
         return EncodingUtils.repeat(str, repeat);
     }
 
+    /** Returns an expr where all characters in from have been replaced with those in to. */
+    public static String translate3(String str, String search, String replacement) {
+        return org.apache.commons.lang3.StringUtils.replaceChars(str, search, replacement);

Review Comment:
   I didn't say to use `StringUtils#replace` I asked about usage of `replace` from this class `SqlFunctionUtils#replace`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20342:
URL: https://github.com/apache/flink/pull/20342#issuecomment-1192341058

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ec8524608ac578fe7f029f1b601fbf7675d3609d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ec8524608ac578fe7f029f1b601fbf7675d3609d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ec8524608ac578fe7f029f1b601fbf7675d3609d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zzzzzzzs commented on pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
zzzzzzzs commented on PR #20342:
URL: https://github.com/apache/flink/pull/20342#issuecomment-1192681393

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zzzzzzzs commented on a diff in pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

Posted by "zzzzzzzs (via GitHub)" <gi...@apache.org>.
zzzzzzzs commented on code in PR #20342:
URL: https://github.com/apache/flink/pull/20342#discussion_r1154393863


##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java:
##########
@@ -371,6 +371,11 @@ public static String repeat(String str, int repeat) {
         return EncodingUtils.repeat(str, repeat);
     }
 
+    /** Returns an expr where all characters in from have been replaced with those in to. */
+    public static String translate3(String str, String search, String replacement) {
+        return org.apache.commons.lang3.StringUtils.replaceChars(str, search, replacement);

Review Comment:
   StringUtils#replaceChars replaces a set of characters with a single character, while SqlFunctionUtils#replace replaces a substring with another string.
   example：
   ``` java
   String replaced = StringUtils.replaceChars("AaBbCc", "abc", "123");
   System.out.println(replaced); // "A1B2C3"
   String replaced = SqlFunctionUtils.replace("AaBbCc", "abc", "123");
   System.out.println(replaced1); // "AaBbCc"
   ```
   To meet the functionality requirements of Hive or Spark, it is necessary to use StringUtils#replaceChars. This is also the approach taken in Calcite.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zzzzzzzs commented on pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
zzzzzzzs commented on PR #20342:
URL: https://github.com/apache/flink/pull/20342#issuecomment-1193063464

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zzzzzzzs commented on pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

Posted by "zzzzzzzs (via GitHub)" <gi...@apache.org>.
zzzzzzzs commented on PR #20342:
URL: https://github.com/apache/flink/pull/20342#issuecomment-1491611206

   @snuyanzin Could you please help to review this PR in your free time? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zzzzzzzs commented on a diff in pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

Posted by GitBox <gi...@apache.org>.
zzzzzzzs commented on code in PR #20342:
URL: https://github.com/apache/flink/pull/20342#discussion_r969203533


##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java:
##########
@@ -371,6 +371,11 @@ public static String repeat(String str, int repeat) {
         return EncodingUtils.repeat(str, repeat);
     }
 
+    /** Returns an expr where all characters in from have been replaced with those in to. */
+    public static String translate3(String str, String search, String replacement) {
+        return org.apache.commons.lang3.StringUtils.replaceChars(str, search, replacement);

Review Comment:
   Replacechars () is a static method of the stringutils class, which is used to replace all search characters with replacement characters. And replace() is a static method of the stringutils class, which optionally accepts the first maximum number of matches of the search string to be replaced in a given text.
   Example:
   ```java
   public static void main(String[] args) {
       String s1 = StringUtils.replaceChars("AaaBabbCc", "ab", "123");
       String s2 = StringUtils.replace("AaaBabbCc", "ab", "123");
       System.out.println("replaceChars:" + s1);
       System.out.println("replace:" + s2);
   }
   ```
   > replaceChars:A11B122Cc
   replace:AaaB123bCc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org