[jira] [Commented] (HBASE-12523) Update checkstyle plugin rules to match our use

["Sean Busbey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-12523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216725#comment-14216725 ] 

Sean Busbey commented on HBASE-12523:
-------------------------------------

[VisibilityModifierCheck|http://checkstyle.sourceforge.net/config_design.html#VisibilityModifier] without hte optional allowing of package/package-private is too strict given our abundant use.

Depending on how the [thread on javadoc imports|http://mail-archives.apache.org/mod_mbox/hbase-dev/201411.mbox/%3CCAGHyZ6%2BhygWxSm3hBzLNyH4yG3c2%3DgsopH-xypy9AtfozxGmdw%40mail.gmail.com%3E] plays out today I'll combine those two changes into a subtask.

> Update checkstyle plugin rules to match our use
> -----------------------------------------------
>
>                 Key: HBASE-12523
>                 URL: https://issues.apache.org/jira/browse/HBASE-12523
>             Project: HBase
>          Issue Type: Sub-task
>          Components: build
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Minor
>              Labels: checkstyle
>
> update our checkstyle configuration to make sure the things that are flagged are things we don't want people doing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)