You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/05/25 02:04:40 UTC

[GitHub] [druid] clintropolis commented on a change in pull request #11289: Add test for join on __time column

clintropolis commented on a change in pull request #11289:
URL: https://github.com/apache/druid/pull/11289#discussion_r638402224



##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
##########
@@ -17491,4 +17491,36 @@ public void testEmptyGroupWithOffsetDoesntInfiniteLoop() throws Exception
         ImmutableList.of()
     );
   }
+
+  @Test
+  public void testJoinWithTimeDimension() throws Exception
+  {
+    testQuery(
+        PLANNER_CONFIG_DEFAULT,
+        QUERY_CONTEXT_DONT_SKIP_EMPTY_BUCKETS,

Review comment:
       why not skipping empty buckets?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org