You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jonkeane (via GitHub)" <gi...@apache.org> on 2026/02/11 05:14:11 UTC
[PR] WIP: Clean up any other C++20 partial compatibility issues [arrow]
jonkeane opened a new pull request, #49223:
URL: https://github.com/apache/arrow/pull/49223
Now that we have CI for it, check on other issues with C++20 compatibility on CRAN. I know that the code in #49105 is likely problematic
### Rationale for this change
### What changes are included in this PR?
### Are these changes tested?
### Are there any user-facing changes?
**This PR includes breaking changes to public APIs.** (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
**This PR contains a "Critical Fix".** (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49287: [C++][R] Clean up any other C++20 partial compatibility issues [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic merged PR #49223:
URL: https://github.com/apache/arrow/pull/49223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49287: [C++][R] Clean up any other C++20 partial compatibility issues [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49223:
URL: https://github.com/apache/arrow/pull/49223#issuecomment-3908666589
Revision: 63df31aaebe59e5d7aad4615634b3b247ba0e882
Submitted crossbow builds: [ursacomputing/crossbow @ actions-7c27c3c492](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7c27c3c492)
|Task|Status|
|----|------|
|test-r-macos-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/22065687227/job/63756785831)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49287: [C++][R] Clean up any other C++20 partial compatibility issues [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #49223:
URL: https://github.com/apache/arrow/pull/49223#issuecomment-3908654734
@github-actions crossbow submit test-r-macos-as-cran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Clean up any other C++20 partial compatibility issues [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49223:
URL: https://github.com/apache/arrow/pull/49223#issuecomment-3898634189
Revision: ab4d29669f0eaf7632ff22a8bd7f264f426d1689
Submitted crossbow builds: [ursacomputing/crossbow @ actions-9260141237](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9260141237)
|Task|Status|
|----|------|
|test-r-macos-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/21997804158/job/63562308280)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Clean up any other C++20 partial compatibility issues [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49223:
URL: https://github.com/apache/arrow/pull/49223#issuecomment-3882206309
Revision: 3de62b9490da739836a16715a4e81dc3053e5578
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d2851fb5d3](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d2851fb5d3)
|Task|Status|
|----|------|
|test-r-macos-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/21893626367/job/63204855998)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49287: [C++][R] Clean up any other C++20 partial compatibility issues [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #49223:
URL: https://github.com/apache/arrow/pull/49223#issuecomment-3924011376
After merging your PR, Conbench analyzed the 1 benchmarking run that has been run so far on merge-commit b5eb42e7658c3cbd05cfc673297bf4a7e46da574.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/64085611186) has more details. It also includes information about 14 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49287: [C++][R] Clean up any other C++20 partial compatibility issues [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #49223:
URL: https://github.com/apache/arrow/pull/49223#issuecomment-3908837189
🎉 I've rebased and we're good (and a bit relieved there weren't _more_ places we'll need this workarounds)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Clean up any other C++20 partial compatibility issues [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49223:
URL: https://github.com/apache/arrow/pull/49223#issuecomment-3882256767
Revision: b7f6771330b35cb01c6570d9ae24737722742114
Submitted crossbow builds: [ursacomputing/crossbow @ actions-b0f1f7caea](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b0f1f7caea)
|Task|Status|
|----|------|
|test-r-macos-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/21893894502/job/63205668060)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Clean up any other C++20 partial compatibility issues [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #49223:
URL: https://github.com/apache/arrow/pull/49223#issuecomment-3882251744
@github-actions crossbow submit test-r-macos-as-cran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Clean up any other C++20 partial compatibility issues [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #49223:
URL: https://github.com/apache/arrow/pull/49223#issuecomment-3898623168
@github-actions crossbow submit test-r-macos-as-cran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49287: [C++][R] Clean up any other C++20 partial compatibility issues [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #49223:
URL: https://github.com/apache/arrow/pull/49223#issuecomment-3938098492
After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit b5eb42e7658c3cbd05cfc673297bf4a7e46da574.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/64370890515) has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49287: [C++][R] Clean up any other C++20 partial compatibility issues [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #49223:
URL: https://github.com/apache/arrow/pull/49223#issuecomment-3902077117
The failure for the old SDK crossbow job is resolved by #49221 We should merge that PR first, and rerun the CI jobs here to confirm this is the last place we need to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Clean up any other C++20 partial compatibility issues [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #49223:
URL: https://github.com/apache/arrow/pull/49223#issuecomment-3882200901
@github-actions crossbow submit test-r-macos-as-cran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org