You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@directmemory.apache.org by Simone Tripodi <si...@apache.org> on 2012/10/01 10:23:26 UTC

Re: [jira] [Commented] (DIRECTMEMORY-102) Lightning Serializer Contribution

Hi Guys,

that perfectly explains why I didn't understand the contribution,
please accept my apologize for misinterpreting it and, above all, for
not having followed the main thread.

So, big +1 for having lightning aboard as both subproject and
serializer module, my added proposal is to separate main DM trunk and
lightning lifecycle in order to not make releases depending each
other.

Before importing Christoph codebase: I already noticed he already
signed the ICLA, but what about the original codebase? If lightning
already published some releases outside the ASF, Christoph should
submit a SoftwareGrant[1] to donate his codebase to the ASF. If it was
already done, we are ready to import lightning!! :)

Have a nice day,
-Simo

[1] http://www.apache.org/licenses/software-grant.txt

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/


On Sun, Sep 30, 2012 at 3:47 PM, Raffaele P. Guidi
<ra...@gmail.com> wrote:
> We were talking about separating the contribution in two pieces: lightning
> itself as a subproject under the directmemory/lightning folder and then the
> serializer module for directmemory in the serialization folder.
>
> Agreed to the coding style consideration (I forgot about it) and -regarding
> the ignore annotation - I found many of them in the main package, I think
> the point is that they have been moved to another module (more appropriate)
> and never deleted.
>
> Ciao,
>     R
> Il giorno 30/set/2012 15:05, "Simone Tripodi (JIRA)" <ji...@apache.org> ha
> scritto:
>
>>
>>     [
>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466467#comment-13466467]
>>
>> Simone Tripodi commented on DIRECTMEMORY-102:
>> ---------------------------------------------
>>
>> Hi Christoph,
>>
>> thanks for contributing! Patch looks quiet good, I'd followup the
>> discussion on the dev@ ML first, I have some observations about the
>> inclusion before applying it. I am going to send a message following up the
>> current thread in a short while.
>> Thanks *a lot* for the hard work and congrats for that lib!
>>
>> In the case you are looking for some feedbacks, follow below few (ASF
>> general) suggestions to submit patches:
>>
>> _Higher priority_
>>
>>  * serializer modules are put under the [serializers|
>> https://svn.apache.org/repos/asf/directmemory/trunk/serializers/]
>> directory;
>>
>>  * no tabs; 2 spaces for XML sources, 4 spaces for Java sources -
>> generally, please respect the original source code format, people here if
>> following the Apache Maven [code conventions|
>> http://maven.apache.org/developers/conventions/code.html] (IDEs config
>> included);
>>
>>  * According to other serializer modules, the package should be moved to
>> {{org.apache.directmemory.serialization.lightning}};
>>
>>  * No needs to define and implement yet another logging abstraction
>> level/façade:
>>
>>  * No needs to define a {{Marshaller}}/{{Unmarshaller}}, the reference
>> interface can be directly the
>> [org.apache.directmemory.serialization.Serializer|
>> https://svn.apache.org/repos/asf/directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/serialization/Serializer.java]
>> class;
>>
>> _Lower priority_
>>
>>  * please name patch file with the issue key, i.e.
>> {{DIRECTMEMORY-102.patch}}, it helps committers that are reviewing and
>> applying patches;
>>
>>  * In the following code:
>>
>> {code}
>> +@SuppressWarnings("serial")
>> +public class ClassDefinitionInconsistentException extends
>> RuntimeException {
>> {code}
>>
>>   you don't need to suppress the serial, you can add serialVersionUID
>> field;
>>
>>  * same for {{IllegalAccessorException}};
>>
>>  * same for {{IllegalPropertyAccessException}};
>>
>>  * same for {{SerializerDefinitionException}};
>>
>>  * same for {{SerializerExecutionException}};
>>
>>  * same for {{SerializerMarshallerGeneratorException}};
>>
>>  * Please drop {{@author}} tags, feel free to add yourself in the
>> {{contributors}} section in the parent POM - this is the right place where
>> people are enlisted;
>>
>>  * no needs to define a {{StringUtil}} class unless [Guava|
>> http://code.google.com/p/guava-libraries/wiki/StringsExplained] doesn't
>> provide the functionalities you need; the DirectMemory core module relies
>> on Guava;
>>
>>  * same for {{TypeUtil}}
>>
>>  * why {{Benchmark}} class is annotated with {{@Ignore}}?
>>
>> > Lightning Serializer Contribution
>> > ---------------------------------
>> >
>> >                 Key: DIRECTMEMORY-102
>> >                 URL:
>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102
>> >             Project: Apache DirectMemory
>> >          Issue Type: New Feature
>> >          Components: Serializers
>> >            Reporter: Christoph Engelbert
>> >         Attachments: lightning_contribution.patch
>> >
>> >
>> > This is the first contribution patch attempt for the lightning
>> serializer. If there are any things need to be changed please let me know.
>> > PS: The issue tracker and sourcelocation values in the pom.xml aren't
>> set yet, since I had no clue what are the correct values but I guess that
>> could be set later on.
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA
>> administrators
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>

Re: [jira] [Commented] (DIRECTMEMORY-102) Lightning Serializer Contribution

Posted by Simone Tripodi <si...@apache.org>.

Hi Chris,

> Ah ok that means I just wait for the "account created" email to go
> on with the steps described in the "guide for new committers" :-)

I strongly suggest you to have a look at the "Get Involved"[1] article
that the ASF provide to better understand the ASF way ;)

Have a nice day, all the best,
-Simo

PS if you didn't notice already, Olivier already imported lightning
codebase in DM svn space :)

[1] http://www.apache.org/foundation/getinvolved.html

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/

Re: [jira] [Commented] (DIRECTMEMORY-102) Lightning Serializer Contribution

Posted by Noctarius <me...@noctarius.com>.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ah ok that means I just wait for the "account created" email to go
on with the steps described in the "guide for new committers" :-)

I thought there was a need to do something more. In some cases the
ASF is still a black hole to me, but that would just be a matter
of time :-)

Cheers Chris

Am 02.10.2012 10:09, schrieb Simone Tripodi:
> Good morning Chris,
> 
> no need to vote, community already accepted Lightining as
> subproject, your ICLA and SG have been registered, so now it is
> just a matter of time - hopefully a committer will have the
> chance/time to import the new codebase pretty soon! :)
> 
> Have a nice day, all the best, -Simo
> 
> http://people.apache.org/~simonetripodi/ 
> http://simonetripodi.livejournal.com/ 
> http://twitter.com/simonetripodi http://www.99soft.org/
> 
> 
> On Tue, Oct 2, 2012 at 9:55 AM, Noctarius <me...@noctarius.com>
> wrote: Good morning Simone,
> 
> so how does that voting take place? Do I need to officially 
> request it somewhere?
> 
> Cheers Chris
> 
> Am 02.10.2012 09:36, schrieb Simone Tripodi:
>>>> Hi Chris!
>>>> 
>>>> we just received Craig's acknowledge, we'll start the
>>>> import process ASAP! :)
>>>> 
>>>> Thanks a lot, have a nice day! all the best, -Simo
>>>> 
>>>> http://people.apache.org/~simonetripodi/ 
>>>> http://simonetripodi.livejournal.com/ 
>>>> http://twitter.com/simonetripodi http://www.99soft.org/
>>>> 
>>>> 
>>>> On Mon, Oct 1, 2012 at 10:23 PM, Noctarius
>>>> <me...@noctarius.com> wrote: Ok Craig confirmed the SG for
>>>> Lightning contribution :-)
>>>> 
>>>> Something more to do?
>>>> 
>>>> Am 01.10.2012 12:43, schrieb Simone Tripodi:
>>>>>>> No problem Chris ;)
>>>>>>> 
>>>>>>> we all committers are here also to welcome new 
>>>>>>> lifeblood, like you, and help them on being part of
>>>>>>> the ASF ecosystem in the easier way, so I am glad
>>>>>>> to provide you as much info as I can - being the
>>>>>>> discussion public, everybody can jump in and
>>>>>>> provide even more info... isn't that cool? :)
>>>>>>> 
>>>>>>> Have a nice day, all the best!!! -Simo
>>>>>>> 
>>>>>>> http://people.apache.org/~simonetripodi/ 
>>>>>>> http://simonetripodi.livejournal.com/ 
>>>>>>> http://twitter.com/simonetripodi
>>>>>>> http://www.99soft.org/
>>>>>>> 
>>>>>>> 
>>>>>>> On Mon, Oct 1, 2012 at 12:31 PM, Noctarius 
>>>>>>> <me...@noctarius.com> wrote: Hey Simone,
>>>>>>> 
>>>>>>> alright it's on it's way :-) Thanks for the
>>>>>>> explanation.
>>>>>>> 
>>>>>>> Like I mentioned earlier in the thread I never
>>>>>>> thought about contributing it to the ASF so I
>>>>>>> haven't really looked on how a contribution needs
>>>>>>> to be done.
>>>>>>> 
>>>>>>> Cheers Chris
>>>>>>> 
>>>>>>> Am 01.10.2012 12:22, schrieb Simone Tripodi:
>>>>>>>>>> Hi Chris,
>>>>>>>>>> 
>>>>>>>>>> thanks for the follow-up!
>>>>>>>>>> 
>>>>>>>>>> I that see releases haven't been pushed yet,
>>>>>>>>>> but unfortunately there is a rather that
>>>>>>>>>> small codebase that is going to be donated -
>>>>>>>>>> what I suggest you, in order to avoid any
>>>>>>>>>> possible legal mistake, is submitting the
>>>>>>>>>> SoftwareGrant[1] I linked you in the previous
>>>>>>>>>> message; that would make clear that the
>>>>>>>>>> codebase on github is going to be donated to
>>>>>>>>>> the ASF.
>>>>>>>>>> 
>>>>>>>>>> What you have to do is pretty simple: like
>>>>>>>>>> the ICLA, print the file, fill the few info,
>>>>>>>>>> sign it and send the scanned version to
>>>>>>>>>> secretary@, you should shortly receive the
>>>>>>>>>> recorded SG notification.
>>>>>>>>>> 
>>>>>>>>>> HTH, have a nice day! -Simo
>>>>>>>>>> 
>>>>>>>>>> [1] 
>>>>>>>>>> http://www.apache.org/licenses/software-grant.txt
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> 
http://people.apache.org/~simonetripodi/
>>>>>>>>>> http://simonetripodi.livejournal.com/ 
>>>>>>>>>> http://twitter.com/simonetripodi 
>>>>>>>>>> http://www.99soft.org/
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>> On Mon, Oct 1, 2012 at 12:03 PM, Noctarius 
>>>>>>>>>> <me...@noctarius.com> wrote: Hi Simone,
>>>>>>>>>> 
>>>>>>>>>> no problem for misinterpreting it :) I
>>>>>>>>>> thought something like that.
>>>>>>>>>> 
>>>>>>>>>> By now there is no release of Lightning, just
>>>>>>>>>> the original sourcecode on Github. Lightning
>>>>>>>>>> wasn't fully production ready and I worked on
>>>>>>>>>> releasing the first version. 
>>>>>>>>>> https://github.com/noctarius/Lightning/issues?milestone=1&state=open
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>
>>>>>>>>>>
>>>>
>>>>>>>>>>
>>>>>>>>>>
>
>>>>>>>>>> 
:-)
>>>>>>>>>> 
>>>>>>>>>> I'm not sure if this needs a "software
>>>>>>>>>> grant", whatever this is :-)
>>>>>>>>>> 
>>>>>>>>>> Cheers Chris
>>>>>>>>>> 
>>>>>>>>>> Am 01.10.2012 10:23, schrieb Simone Tripodi:
>>>>>>>>>>>>> Hi Guys,
>>>>>>>>>>>>> 
>>>>>>>>>>>>> that perfectly explains why I didn't 
>>>>>>>>>>>>> understand the contribution, please
>>>>>>>>>>>>> accept my apologize for misinterpreting
>>>>>>>>>>>>> it and, above all, for not having
>>>>>>>>>>>>> followed the main thread.
>>>>>>>>>>>>> 
>>>>>>>>>>>>> So, big +1 for having lightning aboard
>>>>>>>>>>>>> as both subproject and serializer
>>>>>>>>>>>>> module, my added proposal is to
>>>>>>>>>>>>> separate main DM trunk and lightning
>>>>>>>>>>>>> lifecycle in order to not make releases
>>>>>>>>>>>>> depending each other.
>>>>>>>>>>>>> 
>>>>>>>>>>>>> Before importing Christoph codebase: I 
>>>>>>>>>>>>> already noticed he already signed the
>>>>>>>>>>>>> ICLA, but what about the original
>>>>>>>>>>>>> codebase? If lightning already
>>>>>>>>>>>>> published some releases outside the
>>>>>>>>>>>>> ASF, Christoph should submit a 
>>>>>>>>>>>>> SoftwareGrant[1] to donate his codebase
>>>>>>>>>>>>> to the ASF. If it was already done, we
>>>>>>>>>>>>> are ready to import lightning!! :)
>>>>>>>>>>>>> 
>>>>>>>>>>>>> Have a nice day, -Simo
>>>>>>>>>>>>> 
>>>>>>>>>>>>> [1] 
>>>>>>>>>>>>> http://www.apache.org/licenses/software-grant.txt
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>
>>>>>>>>>>>>> 
http://people.apache.org/~simonetripodi/
>>>>>>>>>>>>> http://simonetripodi.livejournal.com/ 
>>>>>>>>>>>>> http://twitter.com/simonetripodi 
>>>>>>>>>>>>> http://www.99soft.org/
>>>>>>>>>>>>> 
>>>>>>>>>>>>> 
>>>>>>>>>>>>> On Sun, Sep 30, 2012 at 3:47 PM,
>>>>>>>>>>>>> Raffaele P. Guidi
>>>>>>>>>>>>> <ra...@gmail.com> wrote:
>>>>>>>>>>>>>> We were talking about separating the 
>>>>>>>>>>>>>> contribution in two pieces:
>>>>>>>>>>>>>> lightning itself as a subproject
>>>>>>>>>>>>>> under the directmemory/lightning
>>>>>>>>>>>>>> folder and then the serializer module
>>>>>>>>>>>>>> for directmemory in the serialization
>>>>>>>>>>>>>> folder.
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> Agreed to the coding style
>>>>>>>>>>>>>> consideration (I forgot about it) and
>>>>>>>>>>>>>> -regarding the ignore annotation - I
>>>>>>>>>>>>>> found many of them in the main
>>>>>>>>>>>>>> package, I think the point is that 
>>>>>>>>>>>>>> they have been moved to another
>>>>>>>>>>>>>> module (more appropriate) and never
>>>>>>>>>>>>>> deleted.
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> Ciao, R Il giorno 30/set/2012 15:05, 
>>>>>>>>>>>>>> "Simone Tripodi (JIRA)"
>>>>>>>>>>>>>> <ji...@apache.org> ha scritto:
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> [ 
>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466467#comment-13466467]
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>
>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>
>>>>>>>>>>>>>>> 
Simone Tripodi commented on DIRECTMEMORY-102:
>>>>>>>>>>>>>>> ---------------------------------------------
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>
>>>>>>>>>>>>>>> 
Hi Christoph,
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> thanks for contributing! Patch
>>>>>>>>>>>>>>> looks quiet good, I'd followup the
>>>>>>>>>>>>>>> discussion on the dev@ ML first, I
>>>>>>>>>>>>>>> have some observations about the
>>>>>>>>>>>>>>> inclusion before applying it. I am
>>>>>>>>>>>>>>> going to send a message following
>>>>>>>>>>>>>>> up the current thread in a short
>>>>>>>>>>>>>>> while. Thanks *a lot* for the hard
>>>>>>>>>>>>>>> work and congrats for that lib!
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> In the case you are looking for
>>>>>>>>>>>>>>> some feedbacks, follow below few
>>>>>>>>>>>>>>> (ASF general) suggestions to submit
>>>>>>>>>>>>>>> patches:
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> _Higher priority_
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> * serializer modules are put under
>>>>>>>>>>>>>>> the [serializers| 
>>>>>>>>>>>>>>> https://svn.apache.org/repos/asf/directmemory/trunk/serializers/]
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>
>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>
>>>>>>>>>>>>>>> 
directory;
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> * no tabs; 2 spaces for XML
>>>>>>>>>>>>>>> sources, 4 spaces for Java sources
>>>>>>>>>>>>>>> - generally, please respect the
>>>>>>>>>>>>>>> original source code format, people
>>>>>>>>>>>>>>> here if following the Apache Maven
>>>>>>>>>>>>>>> [code conventions| 
>>>>>>>>>>>>>>> http://maven.apache.org/developers/conventions/code.html]
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>
>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>
>>>>>>>>>>>>>>> 
(IDEs config included);
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> * According to other serializer
>>>>>>>>>>>>>>> modules, the package should be
>>>>>>>>>>>>>>> moved to 
>>>>>>>>>>>>>>> {{org.apache.directmemory.serialization.lightning}};
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>
>>>>>>>>>>>>>>> 
* No needs to define and implement yet another
>>>>>>>>>>>>>>> logging abstraction level/façade:
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> * No needs to define a 
>>>>>>>>>>>>>>> {{Marshaller}}/{{Unmarshaller}},
>>>>>>>>>>>>>>> the reference interface can be
>>>>>>>>>>>>>>> directly the 
>>>>>>>>>>>>>>> [org.apache.directmemory.serialization.Serializer|
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>
>>>>>>>>>>>>>>> 
https://svn.apache.org/repos/asf/directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/serialization/Serializer.java]
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>>>>>>> 
>>>>>>> class;
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> _Lower priority_
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> * please name patch file with the
>>>>>>>>>>>>>>> issue key, i.e.
>>>>>>>>>>>>>>> {{DIRECTMEMORY-102.patch}}, it 
>>>>>>>>>>>>>>> helps committers that are reviewing
>>>>>>>>>>>>>>> and applying patches;
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> * In the following code:
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> {code}
>>>>>>>>>>>>>>> +@SuppressWarnings("serial") 
>>>>>>>>>>>>>>> +public class 
>>>>>>>>>>>>>>> ClassDefinitionInconsistentException
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> 
extends RuntimeException { {code}
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> you don't need to suppress the
>>>>>>>>>>>>>>> serial, you can add
>>>>>>>>>>>>>>> serialVersionUID field;
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> * same for
>>>>>>>>>>>>>>> {{IllegalAccessorException}};
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> * same for 
>>>>>>>>>>>>>>> {{IllegalPropertyAccessException}};
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> 
* same for
>>>>>>>>>>>>>>> {{SerializerDefinitionException}};
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> * same for 
>>>>>>>>>>>>>>> {{SerializerExecutionException}};
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> * same for 
>>>>>>>>>>>>>>> {{SerializerMarshallerGeneratorException}};
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>
>>>>>>>>>>>>>>> 
* Please drop {{@author}} tags, feel free to
>>>>>>>>>>>>>>> add yourself in the
>>>>>>>>>>>>>>> {{contributors}} section in the
>>>>>>>>>>>>>>> parent POM - this is the right
>>>>>>>>>>>>>>> place where people are enlisted;
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> * no needs to define a
>>>>>>>>>>>>>>> {{StringUtil}} class unless
>>>>>>>>>>>>>>> [Guava| 
>>>>>>>>>>>>>>> http://code.google.com/p/guava-libraries/wiki/StringsExplained]
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>
>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>
>>>>>>>>>>>>>>> 
doesn't provide the functionalities you need; the
>>>>>>>>>>>>>>> DirectMemory core module relies on 
>>>>>>>>>>>>>>> Guava;
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> * same for {{TypeUtil}}
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> * why {{Benchmark}} class is
>>>>>>>>>>>>>>> annotated with {{@Ignore}}?
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>>> Lightning Serializer
>>>>>>>>>>>>>>>> Contribution 
>>>>>>>>>>>>>>>> ---------------------------------
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> 
Key: DIRECTMEMORY-102 URL:
>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>
>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>
>>>>>>>>>>>>>>> 
Project: Apache DirectMemory Issue Type: New Feature
>>>>>>>>>>>>>>>> Components: Serializers
>>>>>>>>>>>>>>>> Reporter: Christoph Engelbert
>>>>>>>>>>>>>>>> Attachments: 
>>>>>>>>>>>>>>>> lightning_contribution.patch
>>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>>> This is the first contribution
>>>>>>>>>>>>>>>> patch attempt for the lightning
>>>>>>>>>>>>>>> serializer. If there are any things
>>>>>>>>>>>>>>> need to be changed please let me
>>>>>>>>>>>>>>> know.
>>>>>>>>>>>>>>>> PS: The issue tracker and 
>>>>>>>>>>>>>>>> sourcelocation values in the
>>>>>>>>>>>>>>>> pom.xml aren't
>>>>>>>>>>>>>>> set yet, since I had no clue what
>>>>>>>>>>>>>>> are the correct values but I guess
>>>>>>>>>>>>>>> that could be set later on.
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> -- This message is automatically 
>>>>>>>>>>>>>>> generated by JIRA. If you think it
>>>>>>>>>>>>>>> was sent incorrectly, please
>>>>>>>>>>>>>>> contact your JIRA administrators
>>>>>>>>>>>>>>> For more information on JIRA, see: 
>>>>>>>>>>>>>>> http://www.atlassian.com/software/jira
>>>>>>>>>>>>>>>
>>>>>>>>>>
>>>>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (MingW32)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iQIcBAEBAgAGBQJQaqP3AAoJEH/g+YBfahrqitkQAK2vxq84Oxr+K34YflJqmspH
n3J3myMhIFRs3i5R1k95vglr63vbJQMcJ2OEGmu0nyl0KxNWXZbHJm7jvqjRPHFM
15K92KvZT829loiKUaCYzYXlbJUIrMF568E6O4LBCdgZ5MeX8jc6d0UyF64YRkYU
QYyqqsvfpYi0KgXVA32TlG6ReZpcap6c0qe+8vR5qR7fwmW4RFXbx88NWa6U+KSp
hb8OnjYDVxDWunaIbmwhS/XbyEYdzHFfqSw4zY25Ln23f+u5Ntjdeu7UzBUyPO0q
PL46jU1bR8uQpAJWRcywaGCZeWdxMUWUP5+YFFGqu9hY721iE2jNl9NNivCNekHm
1v/Cl+4EuSzRPfZzyl9Vso+4tIp/x9fXxsy/u6ZoocsoellAfzN7ET3hEKD2zqbQ
uB28wRzY4RMgT2UFoYx+qpdlK+VAclrUwOd8rmFt36GIxFcThshAzKTeXn33yiUG
cJ76TJEfqmuCR2fGPGJKivMr3wdq9mgge6tmeXfRmWQSmq0sWdMTesH8dQx/P1yc
LClAI0oqu466PZC7XykzaHTJWga1zklr94PGhcUT7HSDpqvJjZsa0aCzNa5oEwdR
DfmcbIyMwyhK+CRxJ/1LrqWKl4r1nZtQATSEw4Zt2E14KneFPR72nRin1GydB1CT
K0uy0FJPfiimNV/NJvf4
=M4D5
-----END PGP SIGNATURE-----

Re: [jira] [Commented] (DIRECTMEMORY-102) Lightning Serializer Contribution

Posted by Simone Tripodi <si...@apache.org>.

Good morning Chris,

no need to vote, community already accepted Lightining as subproject,
your ICLA and SG have been registered, so now it is just a matter of
time - hopefully a committer will have the chance/time to import the
new codebase pretty soon! :)

Have a nice day, all the best,
-Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/


On Tue, Oct 2, 2012 at 9:55 AM, Noctarius <me...@noctarius.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Good morning Simone,
>
> so how does that voting take place? Do I need to officially
> request it somewhere?
>
> Cheers Chris
>
> Am 02.10.2012 09:36, schrieb Simone Tripodi:
>> Hi Chris!
>>
>> we just received Craig's acknowledge, we'll start the import
>> process ASAP! :)
>>
>> Thanks a lot, have a nice day! all the best, -Simo
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi http://www.99soft.org/
>>
>>
>> On Mon, Oct 1, 2012 at 10:23 PM, Noctarius <me...@noctarius.com>
>> wrote: Ok Craig confirmed the SG for Lightning contribution
>> :-)
>>
>> Something more to do?
>>
>> Am 01.10.2012 12:43, schrieb Simone Tripodi:
>>>>> No problem Chris ;)
>>>>>
>>>>> we all committers are here also to welcome new
>>>>> lifeblood, like you, and help them on being part of the
>>>>> ASF ecosystem in the easier way, so I am glad to provide
>>>>> you as much info as I can - being the discussion public,
>>>>> everybody can jump in and provide even more info...
>>>>> isn't that cool? :)
>>>>>
>>>>> Have a nice day, all the best!!! -Simo
>>>>>
>>>>> http://people.apache.org/~simonetripodi/
>>>>> http://simonetripodi.livejournal.com/
>>>>> http://twitter.com/simonetripodi http://www.99soft.org/
>>>>>
>>>>>
>>>>> On Mon, Oct 1, 2012 at 12:31 PM, Noctarius
>>>>> <me...@noctarius.com> wrote: Hey Simone,
>>>>>
>>>>> alright it's on it's way :-) Thanks for the explanation.
>>>>>
>>>>> Like I mentioned earlier in the thread I never thought
>>>>> about contributing it to the ASF so I haven't really
>>>>> looked on how a contribution needs to be done.
>>>>>
>>>>> Cheers Chris
>>>>>
>>>>> Am 01.10.2012 12:22, schrieb Simone Tripodi:
>>>>>>>> Hi Chris,
>>>>>>>>
>>>>>>>> thanks for the follow-up!
>>>>>>>>
>>>>>>>> I that see releases haven't been pushed yet, but
>>>>>>>> unfortunately there is a rather that small
>>>>>>>> codebase that is going to be donated - what I
>>>>>>>> suggest you, in order to avoid any possible legal
>>>>>>>> mistake, is submitting the SoftwareGrant[1] I
>>>>>>>> linked you in the previous message; that would make
>>>>>>>> clear that the codebase on github is going to be
>>>>>>>> donated to the ASF.
>>>>>>>>
>>>>>>>> What you have to do is pretty simple: like the
>>>>>>>> ICLA, print the file, fill the few info, sign it
>>>>>>>> and send the scanned version to secretary@, you
>>>>>>>> should shortly receive the recorded SG
>>>>>>>> notification.
>>>>>>>>
>>>>>>>> HTH, have a nice day! -Simo
>>>>>>>>
>>>>>>>> [1]
>>>>>>>> http://www.apache.org/licenses/software-grant.txt
>>>>>>>>
>>>>>>>> http://people.apache.org/~simonetripodi/
>>>>>>>> http://simonetripodi.livejournal.com/
>>>>>>>> http://twitter.com/simonetripodi
>>>>>>>> http://www.99soft.org/
>>>>>>>>
>>>>>>>>
>>>>>>>> On Mon, Oct 1, 2012 at 12:03 PM, Noctarius
>>>>>>>> <me...@noctarius.com> wrote: Hi Simone,
>>>>>>>>
>>>>>>>> no problem for misinterpreting it :) I thought
>>>>>>>> something like that.
>>>>>>>>
>>>>>>>> By now there is no release of Lightning, just the
>>>>>>>> original sourcecode on Github. Lightning wasn't
>>>>>>>> fully production ready and I worked on releasing
>>>>>>>> the first version.
>>>>>>>> https://github.com/noctarius/Lightning/issues?milestone=1&state=open
>>>>>>>>
>>>>>>>>
>>>>>
>>>>>>>>
>>
>>>>>>>>
>>>>>>>>
> :-)
>>>>>>>>
>>>>>>>> I'm not sure if this needs a "software grant",
>>>>>>>> whatever this is :-)
>>>>>>>>
>>>>>>>> Cheers Chris
>>>>>>>>
>>>>>>>> Am 01.10.2012 10:23, schrieb Simone Tripodi:
>>>>>>>>>>> Hi Guys,
>>>>>>>>>>>
>>>>>>>>>>> that perfectly explains why I didn't
>>>>>>>>>>> understand the contribution, please accept
>>>>>>>>>>> my apologize for misinterpreting it and,
>>>>>>>>>>> above all, for not having followed the main
>>>>>>>>>>> thread.
>>>>>>>>>>>
>>>>>>>>>>> So, big +1 for having lightning aboard as
>>>>>>>>>>> both subproject and serializer module, my
>>>>>>>>>>> added proposal is to separate main DM trunk
>>>>>>>>>>> and lightning lifecycle in order to not make
>>>>>>>>>>> releases depending each other.
>>>>>>>>>>>
>>>>>>>>>>> Before importing Christoph codebase: I
>>>>>>>>>>> already noticed he already signed the ICLA,
>>>>>>>>>>> but what about the original codebase? If
>>>>>>>>>>> lightning already published some releases
>>>>>>>>>>> outside the ASF, Christoph should submit a
>>>>>>>>>>> SoftwareGrant[1] to donate his codebase to
>>>>>>>>>>> the ASF. If it was already done, we are
>>>>>>>>>>> ready to import lightning!! :)
>>>>>>>>>>>
>>>>>>>>>>> Have a nice day, -Simo
>>>>>>>>>>>
>>>>>>>>>>> [1]
>>>>>>>>>>> http://www.apache.org/licenses/software-grant.txt
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
> http://people.apache.org/~simonetripodi/
>>>>>>>>>>> http://simonetripodi.livejournal.com/
>>>>>>>>>>> http://twitter.com/simonetripodi
>>>>>>>>>>> http://www.99soft.org/
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Sun, Sep 30, 2012 at 3:47 PM, Raffaele P.
>>>>>>>>>>> Guidi <ra...@gmail.com> wrote:
>>>>>>>>>>>> We were talking about separating the
>>>>>>>>>>>> contribution in two pieces: lightning
>>>>>>>>>>>> itself as a subproject under the
>>>>>>>>>>>> directmemory/lightning folder and then the
>>>>>>>>>>>> serializer module for directmemory in the
>>>>>>>>>>>> serialization folder.
>>>>>>>>>>>>
>>>>>>>>>>>> Agreed to the coding style consideration (I
>>>>>>>>>>>> forgot about it) and -regarding the ignore
>>>>>>>>>>>> annotation - I found many of them in the
>>>>>>>>>>>> main package, I think the point is that
>>>>>>>>>>>> they have been moved to another module
>>>>>>>>>>>> (more appropriate) and never deleted.
>>>>>>>>>>>>
>>>>>>>>>>>> Ciao, R Il giorno 30/set/2012 15:05,
>>>>>>>>>>>> "Simone Tripodi (JIRA)" <ji...@apache.org>
>>>>>>>>>>>> ha scritto:
>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> [
>>>>>>>>>>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466467#comment-13466467]
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>
>>>>>
>>>>>>>>>>>>>
>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
> Simone Tripodi commented on DIRECTMEMORY-102:
>>>>>>>>>>>>> ---------------------------------------------
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
> Hi Christoph,
>>>>>>>>>>>>>
>>>>>>>>>>>>> thanks for contributing! Patch looks
>>>>>>>>>>>>> quiet good, I'd followup the discussion
>>>>>>>>>>>>> on the dev@ ML first, I have some
>>>>>>>>>>>>> observations about the inclusion before
>>>>>>>>>>>>> applying it. I am going to send a
>>>>>>>>>>>>> message following up the current thread
>>>>>>>>>>>>> in a short while. Thanks *a lot* for the
>>>>>>>>>>>>> hard work and congrats for that lib!
>>>>>>>>>>>>>
>>>>>>>>>>>>> In the case you are looking for some
>>>>>>>>>>>>> feedbacks, follow below few (ASF general)
>>>>>>>>>>>>> suggestions to submit patches:
>>>>>>>>>>>>>
>>>>>>>>>>>>> _Higher priority_
>>>>>>>>>>>>>
>>>>>>>>>>>>> * serializer modules are put under the
>>>>>>>>>>>>> [serializers|
>>>>>>>>>>>>> https://svn.apache.org/repos/asf/directmemory/trunk/serializers/]
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>
>>>>>
>>>>>>>>>>>>>
>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
> directory;
>>>>>>>>>>>>>
>>>>>>>>>>>>> * no tabs; 2 spaces for XML sources, 4
>>>>>>>>>>>>> spaces for Java sources - generally,
>>>>>>>>>>>>> please respect the original source code
>>>>>>>>>>>>> format, people here if following the
>>>>>>>>>>>>> Apache Maven [code conventions|
>>>>>>>>>>>>> http://maven.apache.org/developers/conventions/code.html]
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>
>>>>>>>>>>>>>
>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
> (IDEs config included);
>>>>>>>>>>>>>
>>>>>>>>>>>>> * According to other serializer modules,
>>>>>>>>>>>>> the package should be moved to
>>>>>>>>>>>>> {{org.apache.directmemory.serialization.lightning}};
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
> * No needs to define and implement yet another
>>>>>>>>>>>>> logging abstraction level/façade:
>>>>>>>>>>>>>
>>>>>>>>>>>>> * No needs to define a
>>>>>>>>>>>>> {{Marshaller}}/{{Unmarshaller}}, the
>>>>>>>>>>>>> reference interface can be directly the
>>>>>>>>>>>>> [org.apache.directmemory.serialization.Serializer|
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
> https://svn.apache.org/repos/asf/directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/serialization/Serializer.java]
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>
>>>>> class;
>>>>>>>>>>>>>
>>>>>>>>>>>>> _Lower priority_
>>>>>>>>>>>>>
>>>>>>>>>>>>> * please name patch file with the issue
>>>>>>>>>>>>> key, i.e. {{DIRECTMEMORY-102.patch}}, it
>>>>>>>>>>>>> helps committers that are reviewing and
>>>>>>>>>>>>> applying patches;
>>>>>>>>>>>>>
>>>>>>>>>>>>> * In the following code:
>>>>>>>>>>>>>
>>>>>>>>>>>>> {code} +@SuppressWarnings("serial")
>>>>>>>>>>>>> +public class
>>>>>>>>>>>>> ClassDefinitionInconsistentException
>>>>>>>>>>>>> extends RuntimeException { {code}
>>>>>>>>>>>>>
>>>>>>>>>>>>> you don't need to suppress the serial,
>>>>>>>>>>>>> you can add serialVersionUID field;
>>>>>>>>>>>>>
>>>>>>>>>>>>> * same for {{IllegalAccessorException}};
>>>>>>>>>>>>>
>>>>>>>>>>>>> * same for
>>>>>>>>>>>>> {{IllegalPropertyAccessException}};
>>>>>>>>>>>>>
>>>>>>>>>>>>> * same for
>>>>>>>>>>>>> {{SerializerDefinitionException}};
>>>>>>>>>>>>>
>>>>>>>>>>>>> * same for
>>>>>>>>>>>>> {{SerializerExecutionException}};
>>>>>>>>>>>>>
>>>>>>>>>>>>> * same for
>>>>>>>>>>>>> {{SerializerMarshallerGeneratorException}};
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
> * Please drop {{@author}} tags, feel free to
>>>>>>>>>>>>> add yourself in the {{contributors}}
>>>>>>>>>>>>> section in the parent POM - this is the
>>>>>>>>>>>>> right place where people are enlisted;
>>>>>>>>>>>>>
>>>>>>>>>>>>> * no needs to define a {{StringUtil}}
>>>>>>>>>>>>> class unless [Guava|
>>>>>>>>>>>>> http://code.google.com/p/guava-libraries/wiki/StringsExplained]
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>
>>>>>>>>>>>>>
>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
> doesn't provide the functionalities you need; the
>>>>>>>>>>>>> DirectMemory core module relies on
>>>>>>>>>>>>> Guava;
>>>>>>>>>>>>>
>>>>>>>>>>>>> * same for {{TypeUtil}}
>>>>>>>>>>>>>
>>>>>>>>>>>>> * why {{Benchmark}} class is annotated
>>>>>>>>>>>>> with {{@Ignore}}?
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Lightning Serializer Contribution
>>>>>>>>>>>>>> ---------------------------------
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Key: DIRECTMEMORY-102 URL:
>>>>>>>>>>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>
>>>>>>>>>>>>>
>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
> Project: Apache DirectMemory Issue Type: New Feature
>>>>>>>>>>>>>> Components: Serializers Reporter:
>>>>>>>>>>>>>> Christoph Engelbert Attachments:
>>>>>>>>>>>>>> lightning_contribution.patch
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> This is the first contribution patch
>>>>>>>>>>>>>> attempt for the lightning
>>>>>>>>>>>>> serializer. If there are any things need
>>>>>>>>>>>>> to be changed please let me know.
>>>>>>>>>>>>>> PS: The issue tracker and
>>>>>>>>>>>>>> sourcelocation values in the pom.xml
>>>>>>>>>>>>>> aren't
>>>>>>>>>>>>> set yet, since I had no clue what are the
>>>>>>>>>>>>> correct values but I guess that could be
>>>>>>>>>>>>> set later on.
>>>>>>>>>>>>>
>>>>>>>>>>>>> -- This message is automatically
>>>>>>>>>>>>> generated by JIRA. If you think it was
>>>>>>>>>>>>> sent incorrectly, please contact your
>>>>>>>>>>>>> JIRA administrators For more information
>>>>>>>>>>>>> on JIRA, see:
>>>>>>>>>>>>> http://www.atlassian.com/software/jira
>>>>>>>>>>>>>
>>>>>>>>
>>
>
> - --
>
>
> ##############################
> # A Digital's Life           #
> ##############################
> Nickname: Noctarius
> Location: Germany
>
> Meet me at:
> Ohloh: http://www.ohloh.net/accounts/noctarius
> Web: http://www.noctarius.com
> XMPP/Jabber: noctarius@jabber.ccc.de
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.12 (MingW32)
> Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
>
> iQIcBAEBAgAGBQJQap4CAAoJEH/g+YBfahrqX5EP/iZj/hloAMGm52xrDGUZ7sTW
> jPmJhxMpIkE5W7Iz6VKhVuIDILQH7b6Tv3vZRXOC6ELuHev4YfyxvCer0/SMi3YZ
> 95CPw9d4u30msrUe3JlbQg42cmQrrnzcUnxNlZ3L5pPgiznTXY9U8kc/EwPSMVEj
> A9h8tQmSNgCyj72elUDG5hCNI0nMbj/Ze/rWuWVQKDeCwKixXPxoM0cclGquHqK2
> XU0aKQP2BySGVA+MAvn0Oo60IVfzz9x7ytqg3JpCUYd/ZSJKFvzI5ng9E6JGGtG8
> +pG9uAsxnrXfwPO1FCBj8bYimUsAjDpHglLM5p5kuwolil4dntef5Uce6K0C+3wf
> 0dKkb8nHPb9jY5e8841A7oVHNYx41VlhMvQhycX02vM4RrtGguCemduzByLt9LU/
> fRHwpNbRc17tE5c4muwAPSA/uzLgFEoFy+aojWcI4EaocFeAJ+QvZM7JN9wWmraS
> bHb/EVhf1x5wWbf6lqXq/XhpvnIe5iZwACevdBrhFO15d6c8mu4xp0hjEJjtczkl
> b0j/UOB0xf3tSSNvLNI40LGJoeNpyiCJyRKCKsMHJ+i6XBLCj4utz6ttx+W8d20c
> SZzEOpNx5AIbchttUvKDEikF8m0ISVkEZ4VQPw9ClPsUhRlLaTC/EDXJlG50KvYc
> 3VgSRm8rMFIDAeVxB91b
> =+Jxn
> -----END PGP SIGNATURE-----

Re: [jira] [Commented] (DIRECTMEMORY-102) Lightning Serializer Contribution

Posted by Noctarius <me...@noctarius.com>.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Good morning Simone,

so how does that voting take place? Do I need to officially
request it somewhere?

Cheers Chris

Am 02.10.2012 09:36, schrieb Simone Tripodi:
> Hi Chris!
> 
> we just received Craig's acknowledge, we'll start the import 
> process ASAP! :)
> 
> Thanks a lot, have a nice day! all the best, -Simo
> 
> http://people.apache.org/~simonetripodi/ 
> http://simonetripodi.livejournal.com/ 
> http://twitter.com/simonetripodi http://www.99soft.org/
> 
> 
> On Mon, Oct 1, 2012 at 10:23 PM, Noctarius <me...@noctarius.com> 
> wrote: Ok Craig confirmed the SG for Lightning contribution 
> :-)
> 
> Something more to do?
> 
> Am 01.10.2012 12:43, schrieb Simone Tripodi:
>>>> No problem Chris ;)
>>>> 
>>>> we all committers are here also to welcome new
>>>> lifeblood, like you, and help them on being part of the
>>>> ASF ecosystem in the easier way, so I am glad to provide
>>>> you as much info as I can - being the discussion public, 
>>>> everybody can jump in and provide even more info...
>>>> isn't that cool? :)
>>>> 
>>>> Have a nice day, all the best!!! -Simo
>>>> 
>>>> http://people.apache.org/~simonetripodi/ 
>>>> http://simonetripodi.livejournal.com/ 
>>>> http://twitter.com/simonetripodi http://www.99soft.org/
>>>> 
>>>> 
>>>> On Mon, Oct 1, 2012 at 12:31 PM, Noctarius 
>>>> <me...@noctarius.com> wrote: Hey Simone,
>>>> 
>>>> alright it's on it's way :-) Thanks for the explanation.
>>>> 
>>>> Like I mentioned earlier in the thread I never thought 
>>>> about contributing it to the ASF so I haven't really 
>>>> looked on how a contribution needs to be done.
>>>> 
>>>> Cheers Chris
>>>> 
>>>> Am 01.10.2012 12:22, schrieb Simone Tripodi:
>>>>>>> Hi Chris,
>>>>>>> 
>>>>>>> thanks for the follow-up!
>>>>>>> 
>>>>>>> I that see releases haven't been pushed yet, but 
>>>>>>> unfortunately there is a rather that small
>>>>>>> codebase that is going to be donated - what I
>>>>>>> suggest you, in order to avoid any possible legal
>>>>>>> mistake, is submitting the SoftwareGrant[1] I
>>>>>>> linked you in the previous message; that would make
>>>>>>> clear that the codebase on github is going to be
>>>>>>> donated to the ASF.
>>>>>>> 
>>>>>>> What you have to do is pretty simple: like the 
>>>>>>> ICLA, print the file, fill the few info, sign it 
>>>>>>> and send the scanned version to secretary@, you 
>>>>>>> should shortly receive the recorded SG 
>>>>>>> notification.
>>>>>>> 
>>>>>>> HTH, have a nice day! -Simo
>>>>>>> 
>>>>>>> [1] 
>>>>>>> http://www.apache.org/licenses/software-grant.txt
>>>>>>> 
>>>>>>> http://people.apache.org/~simonetripodi/ 
>>>>>>> http://simonetripodi.livejournal.com/ 
>>>>>>> http://twitter.com/simonetripodi 
>>>>>>> http://www.99soft.org/
>>>>>>> 
>>>>>>> 
>>>>>>> On Mon, Oct 1, 2012 at 12:03 PM, Noctarius 
>>>>>>> <me...@noctarius.com> wrote: Hi Simone,
>>>>>>> 
>>>>>>> no problem for misinterpreting it :) I thought 
>>>>>>> something like that.
>>>>>>> 
>>>>>>> By now there is no release of Lightning, just the 
>>>>>>> original sourcecode on Github. Lightning wasn't 
>>>>>>> fully production ready and I worked on releasing 
>>>>>>> the first version. 
>>>>>>> https://github.com/noctarius/Lightning/issues?milestone=1&state=open
>>>>>>>
>>>>>>>
>>>>
>>>>>>>
>
>>>>>>>
>>>>>>> 
:-)
>>>>>>> 
>>>>>>> I'm not sure if this needs a "software grant", 
>>>>>>> whatever this is :-)
>>>>>>> 
>>>>>>> Cheers Chris
>>>>>>> 
>>>>>>> Am 01.10.2012 10:23, schrieb Simone Tripodi:
>>>>>>>>>> Hi Guys,
>>>>>>>>>> 
>>>>>>>>>> that perfectly explains why I didn't 
>>>>>>>>>> understand the contribution, please accept
>>>>>>>>>> my apologize for misinterpreting it and,
>>>>>>>>>> above all, for not having followed the main 
>>>>>>>>>> thread.
>>>>>>>>>> 
>>>>>>>>>> So, big +1 for having lightning aboard as 
>>>>>>>>>> both subproject and serializer module, my 
>>>>>>>>>> added proposal is to separate main DM trunk 
>>>>>>>>>> and lightning lifecycle in order to not make 
>>>>>>>>>> releases depending each other.
>>>>>>>>>> 
>>>>>>>>>> Before importing Christoph codebase: I 
>>>>>>>>>> already noticed he already signed the ICLA, 
>>>>>>>>>> but what about the original codebase? If 
>>>>>>>>>> lightning already published some releases 
>>>>>>>>>> outside the ASF, Christoph should submit a 
>>>>>>>>>> SoftwareGrant[1] to donate his codebase to 
>>>>>>>>>> the ASF. If it was already done, we are
>>>>>>>>>> ready to import lightning!! :)
>>>>>>>>>> 
>>>>>>>>>> Have a nice day, -Simo
>>>>>>>>>> 
>>>>>>>>>> [1] 
>>>>>>>>>> http://www.apache.org/licenses/software-grant.txt
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> 
http://people.apache.org/~simonetripodi/
>>>>>>>>>> http://simonetripodi.livejournal.com/ 
>>>>>>>>>> http://twitter.com/simonetripodi 
>>>>>>>>>> http://www.99soft.org/
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>> On Sun, Sep 30, 2012 at 3:47 PM, Raffaele P. 
>>>>>>>>>> Guidi <ra...@gmail.com> wrote:
>>>>>>>>>>> We were talking about separating the 
>>>>>>>>>>> contribution in two pieces: lightning 
>>>>>>>>>>> itself as a subproject under the 
>>>>>>>>>>> directmemory/lightning folder and then the 
>>>>>>>>>>> serializer module for directmemory in the 
>>>>>>>>>>> serialization folder.
>>>>>>>>>>> 
>>>>>>>>>>> Agreed to the coding style consideration (I
>>>>>>>>>>> forgot about it) and -regarding the ignore
>>>>>>>>>>> annotation - I found many of them in the
>>>>>>>>>>> main package, I think the point is that 
>>>>>>>>>>> they have been moved to another module 
>>>>>>>>>>> (more appropriate) and never deleted.
>>>>>>>>>>> 
>>>>>>>>>>> Ciao, R Il giorno 30/set/2012 15:05, 
>>>>>>>>>>> "Simone Tripodi (JIRA)" <ji...@apache.org> 
>>>>>>>>>>> ha scritto:
>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>>>> [ 
>>>>>>>>>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466467#comment-13466467]
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>
>>>>>>>>>>>>
>>>>
>>>>>>>>>>>>
>
>>>>>>>>>>>>
>>>>>>>>>>>> 
Simone Tripodi commented on DIRECTMEMORY-102:
>>>>>>>>>>>> ---------------------------------------------
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> 
Hi Christoph,
>>>>>>>>>>>> 
>>>>>>>>>>>> thanks for contributing! Patch looks 
>>>>>>>>>>>> quiet good, I'd followup the discussion 
>>>>>>>>>>>> on the dev@ ML first, I have some 
>>>>>>>>>>>> observations about the inclusion before 
>>>>>>>>>>>> applying it. I am going to send a
>>>>>>>>>>>> message following up the current thread
>>>>>>>>>>>> in a short while. Thanks *a lot* for the
>>>>>>>>>>>> hard work and congrats for that lib!
>>>>>>>>>>>> 
>>>>>>>>>>>> In the case you are looking for some 
>>>>>>>>>>>> feedbacks, follow below few (ASF general)
>>>>>>>>>>>> suggestions to submit patches:
>>>>>>>>>>>> 
>>>>>>>>>>>> _Higher priority_
>>>>>>>>>>>> 
>>>>>>>>>>>> * serializer modules are put under the 
>>>>>>>>>>>> [serializers| 
>>>>>>>>>>>> https://svn.apache.org/repos/asf/directmemory/trunk/serializers/]
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>
>>>>>>>>>>>>
>>>>
>>>>>>>>>>>>
>
>>>>>>>>>>>>
>>>>>>>>>>>> 
directory;
>>>>>>>>>>>> 
>>>>>>>>>>>> * no tabs; 2 spaces for XML sources, 4 
>>>>>>>>>>>> spaces for Java sources - generally, 
>>>>>>>>>>>> please respect the original source code 
>>>>>>>>>>>> format, people here if following the 
>>>>>>>>>>>> Apache Maven [code conventions| 
>>>>>>>>>>>> http://maven.apache.org/developers/conventions/code.html]
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>
>>>>>>>>>>>>
>
>>>>>>>>>>>>
>>>>>>>>>>>> 
(IDEs config included);
>>>>>>>>>>>> 
>>>>>>>>>>>> * According to other serializer modules, 
>>>>>>>>>>>> the package should be moved to 
>>>>>>>>>>>> {{org.apache.directmemory.serialization.lightning}};
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>
>>>>>>>>>>>>
>>>>>>>>>>>> 
* No needs to define and implement yet another
>>>>>>>>>>>> logging abstraction level/façade:
>>>>>>>>>>>> 
>>>>>>>>>>>> * No needs to define a 
>>>>>>>>>>>> {{Marshaller}}/{{Unmarshaller}}, the 
>>>>>>>>>>>> reference interface can be directly the 
>>>>>>>>>>>> [org.apache.directmemory.serialization.Serializer|
>>>>>>>>>>>>
>>>>>>>>>>>>
>
>>>>>>>>>>>>
>>>>>>>>>>>> 
https://svn.apache.org/repos/asf/directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/serialization/Serializer.java]
>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>> 
>>>>>>>>>>>> 
>>>> class;
>>>>>>>>>>>> 
>>>>>>>>>>>> _Lower priority_
>>>>>>>>>>>> 
>>>>>>>>>>>> * please name patch file with the issue 
>>>>>>>>>>>> key, i.e. {{DIRECTMEMORY-102.patch}}, it 
>>>>>>>>>>>> helps committers that are reviewing and 
>>>>>>>>>>>> applying patches;
>>>>>>>>>>>> 
>>>>>>>>>>>> * In the following code:
>>>>>>>>>>>> 
>>>>>>>>>>>> {code} +@SuppressWarnings("serial") 
>>>>>>>>>>>> +public class 
>>>>>>>>>>>> ClassDefinitionInconsistentException 
>>>>>>>>>>>> extends RuntimeException { {code}
>>>>>>>>>>>> 
>>>>>>>>>>>> you don't need to suppress the serial, 
>>>>>>>>>>>> you can add serialVersionUID field;
>>>>>>>>>>>> 
>>>>>>>>>>>> * same for {{IllegalAccessorException}};
>>>>>>>>>>>> 
>>>>>>>>>>>> * same for 
>>>>>>>>>>>> {{IllegalPropertyAccessException}};
>>>>>>>>>>>> 
>>>>>>>>>>>> * same for 
>>>>>>>>>>>> {{SerializerDefinitionException}};
>>>>>>>>>>>> 
>>>>>>>>>>>> * same for 
>>>>>>>>>>>> {{SerializerExecutionException}};
>>>>>>>>>>>> 
>>>>>>>>>>>> * same for 
>>>>>>>>>>>> {{SerializerMarshallerGeneratorException}};
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> 
* Please drop {{@author}} tags, feel free to
>>>>>>>>>>>> add yourself in the {{contributors}} 
>>>>>>>>>>>> section in the parent POM - this is the 
>>>>>>>>>>>> right place where people are enlisted;
>>>>>>>>>>>> 
>>>>>>>>>>>> * no needs to define a {{StringUtil}} 
>>>>>>>>>>>> class unless [Guava| 
>>>>>>>>>>>> http://code.google.com/p/guava-libraries/wiki/StringsExplained]
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>
>>>>>>>>>>>>
>
>>>>>>>>>>>>
>>>>>>>>>>>> 
doesn't provide the functionalities you need; the
>>>>>>>>>>>> DirectMemory core module relies on 
>>>>>>>>>>>> Guava;
>>>>>>>>>>>> 
>>>>>>>>>>>> * same for {{TypeUtil}}
>>>>>>>>>>>> 
>>>>>>>>>>>> * why {{Benchmark}} class is annotated 
>>>>>>>>>>>> with {{@Ignore}}?
>>>>>>>>>>>> 
>>>>>>>>>>>>> Lightning Serializer Contribution 
>>>>>>>>>>>>> ---------------------------------
>>>>>>>>>>>>> 
>>>>>>>>>>>>> Key: DIRECTMEMORY-102 URL:
>>>>>>>>>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>
>>>>>>>>>>>>
>
>>>>>>>>>>>>
>>>>>>>>>>>> 
Project: Apache DirectMemory Issue Type: New Feature
>>>>>>>>>>>>> Components: Serializers Reporter: 
>>>>>>>>>>>>> Christoph Engelbert Attachments: 
>>>>>>>>>>>>> lightning_contribution.patch
>>>>>>>>>>>>> 
>>>>>>>>>>>>> 
>>>>>>>>>>>>> This is the first contribution patch 
>>>>>>>>>>>>> attempt for the lightning
>>>>>>>>>>>> serializer. If there are any things need 
>>>>>>>>>>>> to be changed please let me know.
>>>>>>>>>>>>> PS: The issue tracker and 
>>>>>>>>>>>>> sourcelocation values in the pom.xml 
>>>>>>>>>>>>> aren't
>>>>>>>>>>>> set yet, since I had no clue what are the
>>>>>>>>>>>> correct values but I guess that could be
>>>>>>>>>>>> set later on.
>>>>>>>>>>>> 
>>>>>>>>>>>> -- This message is automatically 
>>>>>>>>>>>> generated by JIRA. If you think it was 
>>>>>>>>>>>> sent incorrectly, please contact your 
>>>>>>>>>>>> JIRA administrators For more information 
>>>>>>>>>>>> on JIRA, see: 
>>>>>>>>>>>> http://www.atlassian.com/software/jira
>>>>>>>>>>>> 
>>>>>>> 
> 

- -- 


##############################
# A Digital's Life           #
##############################
Nickname: Noctarius
Location: Germany

Meet me at:
Ohloh: http://www.ohloh.net/accounts/noctarius
Web: http://www.noctarius.com
XMPP/Jabber: noctarius@jabber.ccc.de
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (MingW32)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iQIcBAEBAgAGBQJQap4CAAoJEH/g+YBfahrqX5EP/iZj/hloAMGm52xrDGUZ7sTW
jPmJhxMpIkE5W7Iz6VKhVuIDILQH7b6Tv3vZRXOC6ELuHev4YfyxvCer0/SMi3YZ
95CPw9d4u30msrUe3JlbQg42cmQrrnzcUnxNlZ3L5pPgiznTXY9U8kc/EwPSMVEj
A9h8tQmSNgCyj72elUDG5hCNI0nMbj/Ze/rWuWVQKDeCwKixXPxoM0cclGquHqK2
XU0aKQP2BySGVA+MAvn0Oo60IVfzz9x7ytqg3JpCUYd/ZSJKFvzI5ng9E6JGGtG8
+pG9uAsxnrXfwPO1FCBj8bYimUsAjDpHglLM5p5kuwolil4dntef5Uce6K0C+3wf
0dKkb8nHPb9jY5e8841A7oVHNYx41VlhMvQhycX02vM4RrtGguCemduzByLt9LU/
fRHwpNbRc17tE5c4muwAPSA/uzLgFEoFy+aojWcI4EaocFeAJ+QvZM7JN9wWmraS
bHb/EVhf1x5wWbf6lqXq/XhpvnIe5iZwACevdBrhFO15d6c8mu4xp0hjEJjtczkl
b0j/UOB0xf3tSSNvLNI40LGJoeNpyiCJyRKCKsMHJ+i6XBLCj4utz6ttx+W8d20c
SZzEOpNx5AIbchttUvKDEikF8m0ISVkEZ4VQPw9ClPsUhRlLaTC/EDXJlG50KvYc
3VgSRm8rMFIDAeVxB91b
=+Jxn
-----END PGP SIGNATURE-----

Re: [jira] [Commented] (DIRECTMEMORY-102) Lightning Serializer Contribution

Posted by Simone Tripodi <si...@apache.org>.

> And there are some dups in parent poms dm and Lightning, maybe we
> could have a parent pom in a new path
> http://svn.apache.org/repos/asf/directmemory/parent/trunk
> WDYT ?

I am totally by your side about that!! :) If you are discussing it in
the ML you can already count on my +1!
best,
-Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/

Re: [jira] [Commented] (DIRECTMEMORY-102) Lightning Serializer Contribution

Posted by Olivier Lamy <ol...@apache.org>.

I did that yesterday :-)
Need probably more cleanup in poms.
And there are some dups in parent poms dm and Lightning, maybe we
could have a parent pom in a new path
http://svn.apache.org/repos/asf/directmemory/parent/trunk
WDYT ?

Maybe we could have DM parent pom
2012/10/2 Simone Tripodi <si...@apache.org>:
> Hi Chris!
>
> we just received Craig's acknowledge, we'll start the import process ASAP! :)
>
> Thanks a lot, have a nice day!
> all the best,
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
>
> On Mon, Oct 1, 2012 at 10:23 PM, Noctarius <me...@noctarius.com> wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Ok Craig confirmed the SG for Lightning contribution :-)
>>
>> Something more to do?
>>
>> Am 01.10.2012 12:43, schrieb Simone Tripodi:
>>> No problem Chris ;)
>>>
>>> we all committers are here also to welcome new lifeblood, like
>>> you, and help them on being part of the ASF ecosystem in the
>>> easier way, so I am glad to provide you as much info as I can -
>>> being the discussion public, everybody can jump in and provide
>>> even more info... isn't that cool? :)
>>>
>>> Have a nice day, all the best!!! -Simo
>>>
>>> http://people.apache.org/~simonetripodi/
>>> http://simonetripodi.livejournal.com/
>>> http://twitter.com/simonetripodi http://www.99soft.org/
>>>
>>>
>>> On Mon, Oct 1, 2012 at 12:31 PM, Noctarius <me...@noctarius.com>
>>> wrote: Hey Simone,
>>>
>>> alright it's on it's way :-) Thanks for the explanation.
>>>
>>> Like I mentioned earlier in the thread I never thought about
>>> contributing it to the ASF so I haven't really looked on how a
>>> contribution needs to be done.
>>>
>>> Cheers Chris
>>>
>>> Am 01.10.2012 12:22, schrieb Simone Tripodi:
>>>>>> Hi Chris,
>>>>>>
>>>>>> thanks for the follow-up!
>>>>>>
>>>>>> I that see releases haven't been pushed yet, but
>>>>>> unfortunately there is a rather that small codebase that
>>>>>> is going to be donated - what I suggest you, in order to
>>>>>> avoid any possible legal mistake, is submitting the
>>>>>> SoftwareGrant[1] I linked you in the previous message;
>>>>>> that would make clear that the codebase on github is
>>>>>> going to be donated to the ASF.
>>>>>>
>>>>>> What you have to do is pretty simple: like the ICLA,
>>>>>> print the file, fill the few info, sign it and send the
>>>>>> scanned version to secretary@, you should shortly receive
>>>>>> the recorded SG notification.
>>>>>>
>>>>>> HTH, have a nice day! -Simo
>>>>>>
>>>>>> [1] http://www.apache.org/licenses/software-grant.txt
>>>>>>
>>>>>> http://people.apache.org/~simonetripodi/
>>>>>> http://simonetripodi.livejournal.com/
>>>>>> http://twitter.com/simonetripodi http://www.99soft.org/
>>>>>>
>>>>>>
>>>>>> On Mon, Oct 1, 2012 at 12:03 PM, Noctarius
>>>>>> <me...@noctarius.com> wrote: Hi Simone,
>>>>>>
>>>>>> no problem for misinterpreting it :) I thought something
>>>>>> like that.
>>>>>>
>>>>>> By now there is no release of Lightning, just the
>>>>>> original sourcecode on Github. Lightning wasn't fully
>>>>>> production ready and I worked on releasing the first
>>>>>> version.
>>>>>> https://github.com/noctarius/Lightning/issues?milestone=1&state=open
>>>>>>
>>>>>>
>>>
>>>>>>
>> :-)
>>>>>>
>>>>>> I'm not sure if this needs a "software grant", whatever
>>>>>> this is :-)
>>>>>>
>>>>>> Cheers Chris
>>>>>>
>>>>>> Am 01.10.2012 10:23, schrieb Simone Tripodi:
>>>>>>>>> Hi Guys,
>>>>>>>>>
>>>>>>>>> that perfectly explains why I didn't understand
>>>>>>>>> the contribution, please accept my apologize for
>>>>>>>>> misinterpreting it and, above all, for not having
>>>>>>>>> followed the main thread.
>>>>>>>>>
>>>>>>>>> So, big +1 for having lightning aboard as both
>>>>>>>>> subproject and serializer module, my added proposal
>>>>>>>>> is to separate main DM trunk and lightning
>>>>>>>>> lifecycle in order to not make releases depending
>>>>>>>>> each other.
>>>>>>>>>
>>>>>>>>> Before importing Christoph codebase: I already
>>>>>>>>> noticed he already signed the ICLA, but what about
>>>>>>>>> the original codebase? If lightning already
>>>>>>>>> published some releases outside the ASF, Christoph
>>>>>>>>> should submit a SoftwareGrant[1] to donate his
>>>>>>>>> codebase to the ASF. If it was already done, we are
>>>>>>>>> ready to import lightning!! :)
>>>>>>>>>
>>>>>>>>> Have a nice day, -Simo
>>>>>>>>>
>>>>>>>>> [1]
>>>>>>>>> http://www.apache.org/licenses/software-grant.txt
>>>>>>>>>
>>>>>>>>> http://people.apache.org/~simonetripodi/
>>>>>>>>> http://simonetripodi.livejournal.com/
>>>>>>>>> http://twitter.com/simonetripodi
>>>>>>>>> http://www.99soft.org/
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Sun, Sep 30, 2012 at 3:47 PM, Raffaele P. Guidi
>>>>>>>>> <ra...@gmail.com> wrote:
>>>>>>>>>> We were talking about separating the contribution
>>>>>>>>>> in two pieces: lightning itself as a subproject
>>>>>>>>>> under the directmemory/lightning folder and then
>>>>>>>>>> the serializer module for directmemory in the
>>>>>>>>>> serialization folder.
>>>>>>>>>>
>>>>>>>>>> Agreed to the coding style consideration (I
>>>>>>>>>> forgot about it) and -regarding the ignore
>>>>>>>>>> annotation - I found many of them in the main
>>>>>>>>>> package, I think the point is that they have been
>>>>>>>>>> moved to another module (more appropriate) and
>>>>>>>>>> never deleted.
>>>>>>>>>>
>>>>>>>>>> Ciao, R Il giorno 30/set/2012 15:05, "Simone
>>>>>>>>>> Tripodi (JIRA)" <ji...@apache.org> ha scritto:
>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> [
>>>>>>>>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466467#comment-13466467]
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>
>>>>>>>>>>>
>>>
>>>>>>>>>>>
>> Simone Tripodi commented on DIRECTMEMORY-102:
>>>>>>>>>>> ---------------------------------------------
>>>>>>>>>>>
>>>>>>>>>>> Hi Christoph,
>>>>>>>>>>>
>>>>>>>>>>> thanks for contributing! Patch looks quiet
>>>>>>>>>>> good, I'd followup the discussion on the dev@
>>>>>>>>>>> ML first, I have some observations about the
>>>>>>>>>>> inclusion before applying it. I am going to
>>>>>>>>>>> send a message following up the current thread
>>>>>>>>>>> in a short while. Thanks *a lot* for the hard
>>>>>>>>>>> work and congrats for that lib!
>>>>>>>>>>>
>>>>>>>>>>> In the case you are looking for some
>>>>>>>>>>> feedbacks, follow below few (ASF general)
>>>>>>>>>>> suggestions to submit patches:
>>>>>>>>>>>
>>>>>>>>>>> _Higher priority_
>>>>>>>>>>>
>>>>>>>>>>> * serializer modules are put under the
>>>>>>>>>>> [serializers|
>>>>>>>>>>> https://svn.apache.org/repos/asf/directmemory/trunk/serializers/]
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>
>>>>>>>>>>>
>>>
>>>>>>>>>>>
>> directory;
>>>>>>>>>>>
>>>>>>>>>>> * no tabs; 2 spaces for XML sources, 4 spaces
>>>>>>>>>>> for Java sources - generally, please respect
>>>>>>>>>>> the original source code format, people here if
>>>>>>>>>>> following the Apache Maven [code conventions|
>>>>>>>>>>> http://maven.apache.org/developers/conventions/code.html]
>>>>>>>>>>>
>>>>>>>>>>>
>>>
>>>>>>>>>>>
>> (IDEs config included);
>>>>>>>>>>>
>>>>>>>>>>> * According to other serializer modules, the
>>>>>>>>>>> package should be moved to
>>>>>>>>>>> {{org.apache.directmemory.serialization.lightning}};
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>> * No needs to define and implement yet another
>>>>>>>>>>> logging abstraction level/façade:
>>>>>>>>>>>
>>>>>>>>>>> * No needs to define a
>>>>>>>>>>> {{Marshaller}}/{{Unmarshaller}}, the reference
>>>>>>>>>>> interface can be directly the
>>>>>>>>>>> [org.apache.directmemory.serialization.Serializer|
>>>>>>>>>>>
>>>>>>>>>>>
>> https://svn.apache.org/repos/asf/directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/serialization/Serializer.java]
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>
>>>>>>>>>>>
>>> class;
>>>>>>>>>>>
>>>>>>>>>>> _Lower priority_
>>>>>>>>>>>
>>>>>>>>>>> * please name patch file with the issue key,
>>>>>>>>>>> i.e. {{DIRECTMEMORY-102.patch}}, it helps
>>>>>>>>>>> committers that are reviewing and applying
>>>>>>>>>>> patches;
>>>>>>>>>>>
>>>>>>>>>>> * In the following code:
>>>>>>>>>>>
>>>>>>>>>>> {code} +@SuppressWarnings("serial") +public
>>>>>>>>>>> class ClassDefinitionInconsistentException
>>>>>>>>>>> extends RuntimeException { {code}
>>>>>>>>>>>
>>>>>>>>>>> you don't need to suppress the serial, you can
>>>>>>>>>>> add serialVersionUID field;
>>>>>>>>>>>
>>>>>>>>>>> * same for {{IllegalAccessorException}};
>>>>>>>>>>>
>>>>>>>>>>> * same for {{IllegalPropertyAccessException}};
>>>>>>>>>>>
>>>>>>>>>>> * same for {{SerializerDefinitionException}};
>>>>>>>>>>>
>>>>>>>>>>> * same for {{SerializerExecutionException}};
>>>>>>>>>>>
>>>>>>>>>>> * same for
>>>>>>>>>>> {{SerializerMarshallerGeneratorException}};
>>>>>>>>>>>
>>>>>>>>>>> * Please drop {{@author}} tags, feel free to
>>>>>>>>>>> add yourself in the {{contributors}} section in
>>>>>>>>>>> the parent POM - this is the right place where
>>>>>>>>>>> people are enlisted;
>>>>>>>>>>>
>>>>>>>>>>> * no needs to define a {{StringUtil}} class
>>>>>>>>>>> unless [Guava|
>>>>>>>>>>> http://code.google.com/p/guava-libraries/wiki/StringsExplained]
>>>>>>>>>>>
>>>>>>>>>>>
>>>
>>>>>>>>>>>
>> doesn't provide the functionalities you need; the
>>>>>>>>>>> DirectMemory core module relies on Guava;
>>>>>>>>>>>
>>>>>>>>>>> * same for {{TypeUtil}}
>>>>>>>>>>>
>>>>>>>>>>> * why {{Benchmark}} class is annotated with
>>>>>>>>>>> {{@Ignore}}?
>>>>>>>>>>>
>>>>>>>>>>>> Lightning Serializer Contribution
>>>>>>>>>>>> ---------------------------------
>>>>>>>>>>>>
>>>>>>>>>>>> Key: DIRECTMEMORY-102 URL:
>>>>>>>>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102
>>>>>>>>>>>>
>>>>>>>>>>>
>>>
>>>>>>>>>>>
>> Project: Apache DirectMemory Issue Type: New Feature
>>>>>>>>>>>> Components: Serializers Reporter: Christoph
>>>>>>>>>>>> Engelbert Attachments:
>>>>>>>>>>>> lightning_contribution.patch
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> This is the first contribution patch attempt
>>>>>>>>>>>> for the lightning
>>>>>>>>>>> serializer. If there are any things need to be
>>>>>>>>>>> changed please let me know.
>>>>>>>>>>>> PS: The issue tracker and sourcelocation
>>>>>>>>>>>> values in the pom.xml aren't
>>>>>>>>>>> set yet, since I had no clue what are the
>>>>>>>>>>> correct values but I guess that could be set
>>>>>>>>>>> later on.
>>>>>>>>>>>
>>>>>>>>>>> -- This message is automatically generated by
>>>>>>>>>>> JIRA. If you think it was sent incorrectly,
>>>>>>>>>>> please contact your JIRA administrators For
>>>>>>>>>>> more information on JIRA, see:
>>>>>>>>>>> http://www.atlassian.com/software/jira
>>>>>>>>>>>
>>>>>>
>>
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v2.0.12 (MingW32)
>> Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
>>
>> iQIcBAEBAgAGBQJQafvLAAoJEH/g+YBfahrqF+AQAK6J4G32QIUyLeCNcB87+fIR
>> J+FtxsPFIGNajoQGsgBsc+pE9DziiNfiZFzjHoWG8sCl/L21zGrR157qz7npc0dB
>> 9ty/wBqsLg294vZ0cxaBoBk6qZZAUUXMAFZVhf3farLikqYELEi5RKSxzKlyXX4z
>> rpha5f8elDTPIoZU+jnHV0gHhhqOeG1MRR+QrM69/LalnokgfhU38k1vORvDSabF
>> JxwYFGvFtVYQWQBp+Lfkc/a3cEoVGSn3Qd8zYU5NlobT8bIqsxn55HblCaiuMJ8f
>> 3JRXuSaMrAZaffEQN8743ucgy8cnosZDSGgBxWyVNsx+asn+KGlnhArMlAmgGgzl
>> /Veq9njhrPR6sAyAlvZ78YuzaAcziKX7JzF12wL+LHTbR2E1q5EWXPPbNmgfgBoL
>> u5z/L4XOWItA+MlNpKD8hxn2jmiY0M8NJNpEybuiCIf/nxOYtTk2K6JH1gckoLmW
>> ZhECft2LC7c/t24QpB1h62sBJ8Df+n02v+d4mJPShIYeYYDiaL47Ms5yjPaxu+pX
>> FuOqF97p6xaIq6fh73cQzGBZhbaXjudfOV9fcTSawkII8z0UA9vD9RovFqn7Otdv
>> jGhbyCC5Uajng9Ge7VuM+Xv3WKg4hduSZfKNXIP5/5WtmBQKIo3xGo4gnj5I39PI
>> NxkC48CLtTKRi8nJ1uzL
>> =fYJo
>> -----END PGP SIGNATURE-----



-- 
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

Re: [jira] [Commented] (DIRECTMEMORY-102) Lightning Serializer Contribution

Posted by Simone Tripodi <si...@apache.org>.

Hi Chris!

we just received Craig's acknowledge, we'll start the import process ASAP! :)

Thanks a lot, have a nice day!
all the best,
-Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/


On Mon, Oct 1, 2012 at 10:23 PM, Noctarius <me...@noctarius.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Ok Craig confirmed the SG for Lightning contribution :-)
>
> Something more to do?
>
> Am 01.10.2012 12:43, schrieb Simone Tripodi:
>> No problem Chris ;)
>>
>> we all committers are here also to welcome new lifeblood, like
>> you, and help them on being part of the ASF ecosystem in the
>> easier way, so I am glad to provide you as much info as I can -
>> being the discussion public, everybody can jump in and provide
>> even more info... isn't that cool? :)
>>
>> Have a nice day, all the best!!! -Simo
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi http://www.99soft.org/
>>
>>
>> On Mon, Oct 1, 2012 at 12:31 PM, Noctarius <me...@noctarius.com>
>> wrote: Hey Simone,
>>
>> alright it's on it's way :-) Thanks for the explanation.
>>
>> Like I mentioned earlier in the thread I never thought about
>> contributing it to the ASF so I haven't really looked on how a
>> contribution needs to be done.
>>
>> Cheers Chris
>>
>> Am 01.10.2012 12:22, schrieb Simone Tripodi:
>>>>> Hi Chris,
>>>>>
>>>>> thanks for the follow-up!
>>>>>
>>>>> I that see releases haven't been pushed yet, but
>>>>> unfortunately there is a rather that small codebase that
>>>>> is going to be donated - what I suggest you, in order to
>>>>> avoid any possible legal mistake, is submitting the
>>>>> SoftwareGrant[1] I linked you in the previous message;
>>>>> that would make clear that the codebase on github is
>>>>> going to be donated to the ASF.
>>>>>
>>>>> What you have to do is pretty simple: like the ICLA,
>>>>> print the file, fill the few info, sign it and send the
>>>>> scanned version to secretary@, you should shortly receive
>>>>> the recorded SG notification.
>>>>>
>>>>> HTH, have a nice day! -Simo
>>>>>
>>>>> [1] http://www.apache.org/licenses/software-grant.txt
>>>>>
>>>>> http://people.apache.org/~simonetripodi/
>>>>> http://simonetripodi.livejournal.com/
>>>>> http://twitter.com/simonetripodi http://www.99soft.org/
>>>>>
>>>>>
>>>>> On Mon, Oct 1, 2012 at 12:03 PM, Noctarius
>>>>> <me...@noctarius.com> wrote: Hi Simone,
>>>>>
>>>>> no problem for misinterpreting it :) I thought something
>>>>> like that.
>>>>>
>>>>> By now there is no release of Lightning, just the
>>>>> original sourcecode on Github. Lightning wasn't fully
>>>>> production ready and I worked on releasing the first
>>>>> version.
>>>>> https://github.com/noctarius/Lightning/issues?milestone=1&state=open
>>>>>
>>>>>
>>
>>>>>
> :-)
>>>>>
>>>>> I'm not sure if this needs a "software grant", whatever
>>>>> this is :-)
>>>>>
>>>>> Cheers Chris
>>>>>
>>>>> Am 01.10.2012 10:23, schrieb Simone Tripodi:
>>>>>>>> Hi Guys,
>>>>>>>>
>>>>>>>> that perfectly explains why I didn't understand
>>>>>>>> the contribution, please accept my apologize for
>>>>>>>> misinterpreting it and, above all, for not having
>>>>>>>> followed the main thread.
>>>>>>>>
>>>>>>>> So, big +1 for having lightning aboard as both
>>>>>>>> subproject and serializer module, my added proposal
>>>>>>>> is to separate main DM trunk and lightning
>>>>>>>> lifecycle in order to not make releases depending
>>>>>>>> each other.
>>>>>>>>
>>>>>>>> Before importing Christoph codebase: I already
>>>>>>>> noticed he already signed the ICLA, but what about
>>>>>>>> the original codebase? If lightning already
>>>>>>>> published some releases outside the ASF, Christoph
>>>>>>>> should submit a SoftwareGrant[1] to donate his
>>>>>>>> codebase to the ASF. If it was already done, we are
>>>>>>>> ready to import lightning!! :)
>>>>>>>>
>>>>>>>> Have a nice day, -Simo
>>>>>>>>
>>>>>>>> [1]
>>>>>>>> http://www.apache.org/licenses/software-grant.txt
>>>>>>>>
>>>>>>>> http://people.apache.org/~simonetripodi/
>>>>>>>> http://simonetripodi.livejournal.com/
>>>>>>>> http://twitter.com/simonetripodi
>>>>>>>> http://www.99soft.org/
>>>>>>>>
>>>>>>>>
>>>>>>>> On Sun, Sep 30, 2012 at 3:47 PM, Raffaele P. Guidi
>>>>>>>> <ra...@gmail.com> wrote:
>>>>>>>>> We were talking about separating the contribution
>>>>>>>>> in two pieces: lightning itself as a subproject
>>>>>>>>> under the directmemory/lightning folder and then
>>>>>>>>> the serializer module for directmemory in the
>>>>>>>>> serialization folder.
>>>>>>>>>
>>>>>>>>> Agreed to the coding style consideration (I
>>>>>>>>> forgot about it) and -regarding the ignore
>>>>>>>>> annotation - I found many of them in the main
>>>>>>>>> package, I think the point is that they have been
>>>>>>>>> moved to another module (more appropriate) and
>>>>>>>>> never deleted.
>>>>>>>>>
>>>>>>>>> Ciao, R Il giorno 30/set/2012 15:05, "Simone
>>>>>>>>> Tripodi (JIRA)" <ji...@apache.org> ha scritto:
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> [
>>>>>>>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466467#comment-13466467]
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>
>>>>>>>>>>
>>
>>>>>>>>>>
> Simone Tripodi commented on DIRECTMEMORY-102:
>>>>>>>>>> ---------------------------------------------
>>>>>>>>>>
>>>>>>>>>> Hi Christoph,
>>>>>>>>>>
>>>>>>>>>> thanks for contributing! Patch looks quiet
>>>>>>>>>> good, I'd followup the discussion on the dev@
>>>>>>>>>> ML first, I have some observations about the
>>>>>>>>>> inclusion before applying it. I am going to
>>>>>>>>>> send a message following up the current thread
>>>>>>>>>> in a short while. Thanks *a lot* for the hard
>>>>>>>>>> work and congrats for that lib!
>>>>>>>>>>
>>>>>>>>>> In the case you are looking for some
>>>>>>>>>> feedbacks, follow below few (ASF general)
>>>>>>>>>> suggestions to submit patches:
>>>>>>>>>>
>>>>>>>>>> _Higher priority_
>>>>>>>>>>
>>>>>>>>>> * serializer modules are put under the
>>>>>>>>>> [serializers|
>>>>>>>>>> https://svn.apache.org/repos/asf/directmemory/trunk/serializers/]
>>>>>>>>>>
>>>>>>>>>>
>>>>>
>>>>>>>>>>
>>
>>>>>>>>>>
> directory;
>>>>>>>>>>
>>>>>>>>>> * no tabs; 2 spaces for XML sources, 4 spaces
>>>>>>>>>> for Java sources - generally, please respect
>>>>>>>>>> the original source code format, people here if
>>>>>>>>>> following the Apache Maven [code conventions|
>>>>>>>>>> http://maven.apache.org/developers/conventions/code.html]
>>>>>>>>>>
>>>>>>>>>>
>>
>>>>>>>>>>
> (IDEs config included);
>>>>>>>>>>
>>>>>>>>>> * According to other serializer modules, the
>>>>>>>>>> package should be moved to
>>>>>>>>>> {{org.apache.directmemory.serialization.lightning}};
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
> * No needs to define and implement yet another
>>>>>>>>>> logging abstraction level/façade:
>>>>>>>>>>
>>>>>>>>>> * No needs to define a
>>>>>>>>>> {{Marshaller}}/{{Unmarshaller}}, the reference
>>>>>>>>>> interface can be directly the
>>>>>>>>>> [org.apache.directmemory.serialization.Serializer|
>>>>>>>>>>
>>>>>>>>>>
> https://svn.apache.org/repos/asf/directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/serialization/Serializer.java]
>>>>>>>>>>
>>>>>>>>>>
>>>>>
>>>>>>>>>>
>> class;
>>>>>>>>>>
>>>>>>>>>> _Lower priority_
>>>>>>>>>>
>>>>>>>>>> * please name patch file with the issue key,
>>>>>>>>>> i.e. {{DIRECTMEMORY-102.patch}}, it helps
>>>>>>>>>> committers that are reviewing and applying
>>>>>>>>>> patches;
>>>>>>>>>>
>>>>>>>>>> * In the following code:
>>>>>>>>>>
>>>>>>>>>> {code} +@SuppressWarnings("serial") +public
>>>>>>>>>> class ClassDefinitionInconsistentException
>>>>>>>>>> extends RuntimeException { {code}
>>>>>>>>>>
>>>>>>>>>> you don't need to suppress the serial, you can
>>>>>>>>>> add serialVersionUID field;
>>>>>>>>>>
>>>>>>>>>> * same for {{IllegalAccessorException}};
>>>>>>>>>>
>>>>>>>>>> * same for {{IllegalPropertyAccessException}};
>>>>>>>>>>
>>>>>>>>>> * same for {{SerializerDefinitionException}};
>>>>>>>>>>
>>>>>>>>>> * same for {{SerializerExecutionException}};
>>>>>>>>>>
>>>>>>>>>> * same for
>>>>>>>>>> {{SerializerMarshallerGeneratorException}};
>>>>>>>>>>
>>>>>>>>>> * Please drop {{@author}} tags, feel free to
>>>>>>>>>> add yourself in the {{contributors}} section in
>>>>>>>>>> the parent POM - this is the right place where
>>>>>>>>>> people are enlisted;
>>>>>>>>>>
>>>>>>>>>> * no needs to define a {{StringUtil}} class
>>>>>>>>>> unless [Guava|
>>>>>>>>>> http://code.google.com/p/guava-libraries/wiki/StringsExplained]
>>>>>>>>>>
>>>>>>>>>>
>>
>>>>>>>>>>
> doesn't provide the functionalities you need; the
>>>>>>>>>> DirectMemory core module relies on Guava;
>>>>>>>>>>
>>>>>>>>>> * same for {{TypeUtil}}
>>>>>>>>>>
>>>>>>>>>> * why {{Benchmark}} class is annotated with
>>>>>>>>>> {{@Ignore}}?
>>>>>>>>>>
>>>>>>>>>>> Lightning Serializer Contribution
>>>>>>>>>>> ---------------------------------
>>>>>>>>>>>
>>>>>>>>>>> Key: DIRECTMEMORY-102 URL:
>>>>>>>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102
>>>>>>>>>>>
>>>>>>>>>>
>>
>>>>>>>>>>
> Project: Apache DirectMemory Issue Type: New Feature
>>>>>>>>>>> Components: Serializers Reporter: Christoph
>>>>>>>>>>> Engelbert Attachments:
>>>>>>>>>>> lightning_contribution.patch
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> This is the first contribution patch attempt
>>>>>>>>>>> for the lightning
>>>>>>>>>> serializer. If there are any things need to be
>>>>>>>>>> changed please let me know.
>>>>>>>>>>> PS: The issue tracker and sourcelocation
>>>>>>>>>>> values in the pom.xml aren't
>>>>>>>>>> set yet, since I had no clue what are the
>>>>>>>>>> correct values but I guess that could be set
>>>>>>>>>> later on.
>>>>>>>>>>
>>>>>>>>>> -- This message is automatically generated by
>>>>>>>>>> JIRA. If you think it was sent incorrectly,
>>>>>>>>>> please contact your JIRA administrators For
>>>>>>>>>> more information on JIRA, see:
>>>>>>>>>> http://www.atlassian.com/software/jira
>>>>>>>>>>
>>>>>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.12 (MingW32)
> Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
>
> iQIcBAEBAgAGBQJQafvLAAoJEH/g+YBfahrqF+AQAK6J4G32QIUyLeCNcB87+fIR
> J+FtxsPFIGNajoQGsgBsc+pE9DziiNfiZFzjHoWG8sCl/L21zGrR157qz7npc0dB
> 9ty/wBqsLg294vZ0cxaBoBk6qZZAUUXMAFZVhf3farLikqYELEi5RKSxzKlyXX4z
> rpha5f8elDTPIoZU+jnHV0gHhhqOeG1MRR+QrM69/LalnokgfhU38k1vORvDSabF
> JxwYFGvFtVYQWQBp+Lfkc/a3cEoVGSn3Qd8zYU5NlobT8bIqsxn55HblCaiuMJ8f
> 3JRXuSaMrAZaffEQN8743ucgy8cnosZDSGgBxWyVNsx+asn+KGlnhArMlAmgGgzl
> /Veq9njhrPR6sAyAlvZ78YuzaAcziKX7JzF12wL+LHTbR2E1q5EWXPPbNmgfgBoL
> u5z/L4XOWItA+MlNpKD8hxn2jmiY0M8NJNpEybuiCIf/nxOYtTk2K6JH1gckoLmW
> ZhECft2LC7c/t24QpB1h62sBJ8Df+n02v+d4mJPShIYeYYDiaL47Ms5yjPaxu+pX
> FuOqF97p6xaIq6fh73cQzGBZhbaXjudfOV9fcTSawkII8z0UA9vD9RovFqn7Otdv
> jGhbyCC5Uajng9Ge7VuM+Xv3WKg4hduSZfKNXIP5/5WtmBQKIo3xGo4gnj5I39PI
> NxkC48CLtTKRi8nJ1uzL
> =fYJo
> -----END PGP SIGNATURE-----

Re: [jira] [Commented] (DIRECTMEMORY-102) Lightning Serializer Contribution

Posted by Noctarius <me...@noctarius.com>.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ok Craig confirmed the SG for Lightning contribution :-)

Something more to do?

Am 01.10.2012 12:43, schrieb Simone Tripodi:
> No problem Chris ;)
> 
> we all committers are here also to welcome new lifeblood, like
> you, and help them on being part of the ASF ecosystem in the
> easier way, so I am glad to provide you as much info as I can -
> being the discussion public, everybody can jump in and provide
> even more info... isn't that cool? :)
> 
> Have a nice day, all the best!!! -Simo
> 
> http://people.apache.org/~simonetripodi/ 
> http://simonetripodi.livejournal.com/ 
> http://twitter.com/simonetripodi http://www.99soft.org/
> 
> 
> On Mon, Oct 1, 2012 at 12:31 PM, Noctarius <me...@noctarius.com>
> wrote: Hey Simone,
> 
> alright it's on it's way :-) Thanks for the explanation.
> 
> Like I mentioned earlier in the thread I never thought about 
> contributing it to the ASF so I haven't really looked on how a 
> contribution needs to be done.
> 
> Cheers Chris
> 
> Am 01.10.2012 12:22, schrieb Simone Tripodi:
>>>> Hi Chris,
>>>> 
>>>> thanks for the follow-up!
>>>> 
>>>> I that see releases haven't been pushed yet, but
>>>> unfortunately there is a rather that small codebase that
>>>> is going to be donated - what I suggest you, in order to
>>>> avoid any possible legal mistake, is submitting the
>>>> SoftwareGrant[1] I linked you in the previous message;
>>>> that would make clear that the codebase on github is
>>>> going to be donated to the ASF.
>>>> 
>>>> What you have to do is pretty simple: like the ICLA,
>>>> print the file, fill the few info, sign it and send the
>>>> scanned version to secretary@, you should shortly receive
>>>> the recorded SG notification.
>>>> 
>>>> HTH, have a nice day! -Simo
>>>> 
>>>> [1] http://www.apache.org/licenses/software-grant.txt
>>>> 
>>>> http://people.apache.org/~simonetripodi/ 
>>>> http://simonetripodi.livejournal.com/ 
>>>> http://twitter.com/simonetripodi http://www.99soft.org/
>>>> 
>>>> 
>>>> On Mon, Oct 1, 2012 at 12:03 PM, Noctarius
>>>> <me...@noctarius.com> wrote: Hi Simone,
>>>> 
>>>> no problem for misinterpreting it :) I thought something
>>>> like that.
>>>> 
>>>> By now there is no release of Lightning, just the
>>>> original sourcecode on Github. Lightning wasn't fully
>>>> production ready and I worked on releasing the first
>>>> version. 
>>>> https://github.com/noctarius/Lightning/issues?milestone=1&state=open
>>>>
>>>>
>
>>>> 
:-)
>>>> 
>>>> I'm not sure if this needs a "software grant", whatever
>>>> this is :-)
>>>> 
>>>> Cheers Chris
>>>> 
>>>> Am 01.10.2012 10:23, schrieb Simone Tripodi:
>>>>>>> Hi Guys,
>>>>>>> 
>>>>>>> that perfectly explains why I didn't understand
>>>>>>> the contribution, please accept my apologize for 
>>>>>>> misinterpreting it and, above all, for not having 
>>>>>>> followed the main thread.
>>>>>>> 
>>>>>>> So, big +1 for having lightning aboard as both
>>>>>>> subproject and serializer module, my added proposal
>>>>>>> is to separate main DM trunk and lightning
>>>>>>> lifecycle in order to not make releases depending
>>>>>>> each other.
>>>>>>> 
>>>>>>> Before importing Christoph codebase: I already
>>>>>>> noticed he already signed the ICLA, but what about
>>>>>>> the original codebase? If lightning already
>>>>>>> published some releases outside the ASF, Christoph
>>>>>>> should submit a SoftwareGrant[1] to donate his
>>>>>>> codebase to the ASF. If it was already done, we are
>>>>>>> ready to import lightning!! :)
>>>>>>> 
>>>>>>> Have a nice day, -Simo
>>>>>>> 
>>>>>>> [1]
>>>>>>> http://www.apache.org/licenses/software-grant.txt
>>>>>>> 
>>>>>>> http://people.apache.org/~simonetripodi/ 
>>>>>>> http://simonetripodi.livejournal.com/ 
>>>>>>> http://twitter.com/simonetripodi
>>>>>>> http://www.99soft.org/
>>>>>>> 
>>>>>>> 
>>>>>>> On Sun, Sep 30, 2012 at 3:47 PM, Raffaele P. Guidi 
>>>>>>> <ra...@gmail.com> wrote:
>>>>>>>> We were talking about separating the contribution
>>>>>>>> in two pieces: lightning itself as a subproject
>>>>>>>> under the directmemory/lightning folder and then
>>>>>>>> the serializer module for directmemory in the
>>>>>>>> serialization folder.
>>>>>>>> 
>>>>>>>> Agreed to the coding style consideration (I
>>>>>>>> forgot about it) and -regarding the ignore
>>>>>>>> annotation - I found many of them in the main
>>>>>>>> package, I think the point is that they have been
>>>>>>>> moved to another module (more appropriate) and
>>>>>>>> never deleted.
>>>>>>>> 
>>>>>>>> Ciao, R Il giorno 30/set/2012 15:05, "Simone
>>>>>>>> Tripodi (JIRA)" <ji...@apache.org> ha scritto:
>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> [ 
>>>>>>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466467#comment-13466467]
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>
>>>>>>>>>
>
>>>>>>>>> 
Simone Tripodi commented on DIRECTMEMORY-102:
>>>>>>>>> ---------------------------------------------
>>>>>>>>> 
>>>>>>>>> Hi Christoph,
>>>>>>>>> 
>>>>>>>>> thanks for contributing! Patch looks quiet
>>>>>>>>> good, I'd followup the discussion on the dev@
>>>>>>>>> ML first, I have some observations about the
>>>>>>>>> inclusion before applying it. I am going to
>>>>>>>>> send a message following up the current thread
>>>>>>>>> in a short while. Thanks *a lot* for the hard
>>>>>>>>> work and congrats for that lib!
>>>>>>>>> 
>>>>>>>>> In the case you are looking for some
>>>>>>>>> feedbacks, follow below few (ASF general)
>>>>>>>>> suggestions to submit patches:
>>>>>>>>> 
>>>>>>>>> _Higher priority_
>>>>>>>>> 
>>>>>>>>> * serializer modules are put under the
>>>>>>>>> [serializers| 
>>>>>>>>> https://svn.apache.org/repos/asf/directmemory/trunk/serializers/]
>>>>>>>>>
>>>>>>>>>
>>>>
>>>>>>>>>
>
>>>>>>>>> 
directory;
>>>>>>>>> 
>>>>>>>>> * no tabs; 2 spaces for XML sources, 4 spaces
>>>>>>>>> for Java sources - generally, please respect
>>>>>>>>> the original source code format, people here if
>>>>>>>>> following the Apache Maven [code conventions| 
>>>>>>>>> http://maven.apache.org/developers/conventions/code.html]
>>>>>>>>>
>>>>>>>>>
>
>>>>>>>>> 
(IDEs config included);
>>>>>>>>> 
>>>>>>>>> * According to other serializer modules, the
>>>>>>>>> package should be moved to 
>>>>>>>>> {{org.apache.directmemory.serialization.lightning}};
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> 
* No needs to define and implement yet another
>>>>>>>>> logging abstraction level/façade:
>>>>>>>>> 
>>>>>>>>> * No needs to define a 
>>>>>>>>> {{Marshaller}}/{{Unmarshaller}}, the reference 
>>>>>>>>> interface can be directly the 
>>>>>>>>> [org.apache.directmemory.serialization.Serializer|
>>>>>>>>>
>>>>>>>>> 
https://svn.apache.org/repos/asf/directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/serialization/Serializer.java]
>>>>>>>>> 
>>>>>>>>> 
>>>> 
>>>>>>>>> 
> class;
>>>>>>>>> 
>>>>>>>>> _Lower priority_
>>>>>>>>> 
>>>>>>>>> * please name patch file with the issue key,
>>>>>>>>> i.e. {{DIRECTMEMORY-102.patch}}, it helps
>>>>>>>>> committers that are reviewing and applying
>>>>>>>>> patches;
>>>>>>>>> 
>>>>>>>>> * In the following code:
>>>>>>>>> 
>>>>>>>>> {code} +@SuppressWarnings("serial") +public
>>>>>>>>> class ClassDefinitionInconsistentException
>>>>>>>>> extends RuntimeException { {code}
>>>>>>>>> 
>>>>>>>>> you don't need to suppress the serial, you can
>>>>>>>>> add serialVersionUID field;
>>>>>>>>> 
>>>>>>>>> * same for {{IllegalAccessorException}};
>>>>>>>>> 
>>>>>>>>> * same for {{IllegalPropertyAccessException}};
>>>>>>>>> 
>>>>>>>>> * same for {{SerializerDefinitionException}};
>>>>>>>>> 
>>>>>>>>> * same for {{SerializerExecutionException}};
>>>>>>>>> 
>>>>>>>>> * same for 
>>>>>>>>> {{SerializerMarshallerGeneratorException}};
>>>>>>>>> 
>>>>>>>>> * Please drop {{@author}} tags, feel free to
>>>>>>>>> add yourself in the {{contributors}} section in
>>>>>>>>> the parent POM - this is the right place where
>>>>>>>>> people are enlisted;
>>>>>>>>> 
>>>>>>>>> * no needs to define a {{StringUtil}} class
>>>>>>>>> unless [Guava| 
>>>>>>>>> http://code.google.com/p/guava-libraries/wiki/StringsExplained]
>>>>>>>>>
>>>>>>>>>
>
>>>>>>>>> 
doesn't provide the functionalities you need; the
>>>>>>>>> DirectMemory core module relies on Guava;
>>>>>>>>> 
>>>>>>>>> * same for {{TypeUtil}}
>>>>>>>>> 
>>>>>>>>> * why {{Benchmark}} class is annotated with 
>>>>>>>>> {{@Ignore}}?
>>>>>>>>> 
>>>>>>>>>> Lightning Serializer Contribution 
>>>>>>>>>> ---------------------------------
>>>>>>>>>> 
>>>>>>>>>> Key: DIRECTMEMORY-102 URL:
>>>>>>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102
>>>>>>>>>>
>>>>>>>>>
>
>>>>>>>>> 
Project: Apache DirectMemory Issue Type: New Feature
>>>>>>>>>> Components: Serializers Reporter: Christoph 
>>>>>>>>>> Engelbert Attachments: 
>>>>>>>>>> lightning_contribution.patch
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>> This is the first contribution patch attempt
>>>>>>>>>> for the lightning
>>>>>>>>> serializer. If there are any things need to be 
>>>>>>>>> changed please let me know.
>>>>>>>>>> PS: The issue tracker and sourcelocation
>>>>>>>>>> values in the pom.xml aren't
>>>>>>>>> set yet, since I had no clue what are the
>>>>>>>>> correct values but I guess that could be set
>>>>>>>>> later on.
>>>>>>>>> 
>>>>>>>>> -- This message is automatically generated by
>>>>>>>>> JIRA. If you think it was sent incorrectly,
>>>>>>>>> please contact your JIRA administrators For
>>>>>>>>> more information on JIRA, see:
>>>>>>>>> http://www.atlassian.com/software/jira
>>>>>>>>> 
>>>> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (MingW32)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iQIcBAEBAgAGBQJQafvLAAoJEH/g+YBfahrqF+AQAK6J4G32QIUyLeCNcB87+fIR
J+FtxsPFIGNajoQGsgBsc+pE9DziiNfiZFzjHoWG8sCl/L21zGrR157qz7npc0dB
9ty/wBqsLg294vZ0cxaBoBk6qZZAUUXMAFZVhf3farLikqYELEi5RKSxzKlyXX4z
rpha5f8elDTPIoZU+jnHV0gHhhqOeG1MRR+QrM69/LalnokgfhU38k1vORvDSabF
JxwYFGvFtVYQWQBp+Lfkc/a3cEoVGSn3Qd8zYU5NlobT8bIqsxn55HblCaiuMJ8f
3JRXuSaMrAZaffEQN8743ucgy8cnosZDSGgBxWyVNsx+asn+KGlnhArMlAmgGgzl
/Veq9njhrPR6sAyAlvZ78YuzaAcziKX7JzF12wL+LHTbR2E1q5EWXPPbNmgfgBoL
u5z/L4XOWItA+MlNpKD8hxn2jmiY0M8NJNpEybuiCIf/nxOYtTk2K6JH1gckoLmW
ZhECft2LC7c/t24QpB1h62sBJ8Df+n02v+d4mJPShIYeYYDiaL47Ms5yjPaxu+pX
FuOqF97p6xaIq6fh73cQzGBZhbaXjudfOV9fcTSawkII8z0UA9vD9RovFqn7Otdv
jGhbyCC5Uajng9Ge7VuM+Xv3WKg4hduSZfKNXIP5/5WtmBQKIo3xGo4gnj5I39PI
NxkC48CLtTKRi8nJ1uzL
=fYJo
-----END PGP SIGNATURE-----

Re: [jira] [Commented] (DIRECTMEMORY-102) Lightning Serializer Contribution

Posted by Simone Tripodi <si...@apache.org>.

No problem Chris ;)

we all committers are here also to welcome new lifeblood, like you,
and help them on being part of the ASF ecosystem in the easier way, so
I am glad to provide you as much info as I can - being the discussion
public, everybody can jump in and provide even more info... isn't that
cool? :)

Have a nice day, all the best!!!
-Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/


On Mon, Oct 1, 2012 at 12:31 PM, Noctarius <me...@noctarius.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hey Simone,
>
> alright it's on it's way :-) Thanks for the explanation.
>
> Like I mentioned earlier in the thread I never thought about
> contributing it to the ASF so I haven't really looked on how a
> contribution needs to be done.
>
> Cheers Chris
>
> Am 01.10.2012 12:22, schrieb Simone Tripodi:
>> Hi Chris,
>>
>> thanks for the follow-up!
>>
>> I that see releases haven't been pushed yet, but unfortunately
>> there is a rather that small codebase that is going to be
>> donated - what I suggest you, in order to avoid any possible
>> legal mistake, is submitting the SoftwareGrant[1] I linked you
>> in the previous message; that would make clear that the
>> codebase on github is going to be donated to the ASF.
>>
>> What you have to do is pretty simple: like the ICLA, print the
>> file, fill the few info, sign it and send the scanned version
>> to secretary@, you should shortly receive the recorded SG
>> notification.
>>
>> HTH, have a nice day! -Simo
>>
>> [1] http://www.apache.org/licenses/software-grant.txt
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi http://www.99soft.org/
>>
>>
>> On Mon, Oct 1, 2012 at 12:03 PM, Noctarius <me...@noctarius.com>
>> wrote: Hi Simone,
>>
>> no problem for misinterpreting it :) I thought something like
>> that.
>>
>> By now there is no release of Lightning, just the original
>> sourcecode on Github. Lightning wasn't fully production ready
>> and I worked on releasing the first version.
>> https://github.com/noctarius/Lightning/issues?milestone=1&state=open
>>
>>
> :-)
>>
>> I'm not sure if this needs a "software grant", whatever this is
>> :-)
>>
>> Cheers Chris
>>
>> Am 01.10.2012 10:23, schrieb Simone Tripodi:
>>>>> Hi Guys,
>>>>>
>>>>> that perfectly explains why I didn't understand the
>>>>> contribution, please accept my apologize for
>>>>> misinterpreting it and, above all, for not having
>>>>> followed the main thread.
>>>>>
>>>>> So, big +1 for having lightning aboard as both subproject
>>>>> and serializer module, my added proposal is to separate
>>>>> main DM trunk and lightning lifecycle in order to not
>>>>> make releases depending each other.
>>>>>
>>>>> Before importing Christoph codebase: I already noticed
>>>>> he already signed the ICLA, but what about the original
>>>>> codebase? If lightning already published some releases
>>>>> outside the ASF, Christoph should submit a
>>>>> SoftwareGrant[1] to donate his codebase to the ASF. If it
>>>>> was already done, we are ready to import lightning!! :)
>>>>>
>>>>> Have a nice day, -Simo
>>>>>
>>>>> [1] http://www.apache.org/licenses/software-grant.txt
>>>>>
>>>>> http://people.apache.org/~simonetripodi/
>>>>> http://simonetripodi.livejournal.com/
>>>>> http://twitter.com/simonetripodi http://www.99soft.org/
>>>>>
>>>>>
>>>>> On Sun, Sep 30, 2012 at 3:47 PM, Raffaele P. Guidi
>>>>> <ra...@gmail.com> wrote:
>>>>>> We were talking about separating the contribution in
>>>>>> two pieces: lightning itself as a subproject under the
>>>>>> directmemory/lightning folder and then the serializer
>>>>>> module for directmemory in the serialization folder.
>>>>>>
>>>>>> Agreed to the coding style consideration (I forgot
>>>>>> about it) and -regarding the ignore annotation - I
>>>>>> found many of them in the main package, I think the
>>>>>> point is that they have been moved to another module
>>>>>> (more appropriate) and never deleted.
>>>>>>
>>>>>> Ciao, R Il giorno 30/set/2012 15:05, "Simone Tripodi
>>>>>> (JIRA)" <ji...@apache.org> ha scritto:
>>>>>>
>>>>>>>
>>>>>>> [
>>>>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466467#comment-13466467]
>>>>>>>
>>>>>>>
>>>>>>>
>>
>>>>>>>
> Simone Tripodi commented on DIRECTMEMORY-102:
>>>>>>> ---------------------------------------------
>>>>>>>
>>>>>>> Hi Christoph,
>>>>>>>
>>>>>>> thanks for contributing! Patch looks quiet good, I'd
>>>>>>> followup the discussion on the dev@ ML first, I have
>>>>>>> some observations about the inclusion before applying
>>>>>>> it. I am going to send a message following up the
>>>>>>> current thread in a short while. Thanks *a lot* for
>>>>>>> the hard work and congrats for that lib!
>>>>>>>
>>>>>>> In the case you are looking for some feedbacks,
>>>>>>> follow below few (ASF general) suggestions to submit
>>>>>>> patches:
>>>>>>>
>>>>>>> _Higher priority_
>>>>>>>
>>>>>>> * serializer modules are put under the [serializers|
>>>>>>> https://svn.apache.org/repos/asf/directmemory/trunk/serializers/]
>>>>>>>
>>>>>>>
>>
>>>>>>>
> directory;
>>>>>>>
>>>>>>> * no tabs; 2 spaces for XML sources, 4 spaces for
>>>>>>> Java sources - generally, please respect the original
>>>>>>> source code format, people here if following the
>>>>>>> Apache Maven [code conventions|
>>>>>>> http://maven.apache.org/developers/conventions/code.html]
>>>>>>>
>>>>>>>
> (IDEs config included);
>>>>>>>
>>>>>>> * According to other serializer modules, the package
>>>>>>> should be moved to
>>>>>>> {{org.apache.directmemory.serialization.lightning}};
>>>>>>>
>>>>>>> * No needs to define and implement yet another
>>>>>>> logging abstraction level/façade:
>>>>>>>
>>>>>>> * No needs to define a
>>>>>>> {{Marshaller}}/{{Unmarshaller}}, the reference
>>>>>>> interface can be directly the
>>>>>>> [org.apache.directmemory.serialization.Serializer|
>>>>>>> https://svn.apache.org/repos/asf/directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/serialization/Serializer.java]
>>>>>>>
>>>>>>>
>>
>>>>>>>
> class;
>>>>>>>
>>>>>>> _Lower priority_
>>>>>>>
>>>>>>> * please name patch file with the issue key, i.e.
>>>>>>> {{DIRECTMEMORY-102.patch}}, it helps committers that
>>>>>>> are reviewing and applying patches;
>>>>>>>
>>>>>>> * In the following code:
>>>>>>>
>>>>>>> {code} +@SuppressWarnings("serial") +public class
>>>>>>> ClassDefinitionInconsistentException extends
>>>>>>> RuntimeException { {code}
>>>>>>>
>>>>>>> you don't need to suppress the serial, you can add
>>>>>>> serialVersionUID field;
>>>>>>>
>>>>>>> * same for {{IllegalAccessorException}};
>>>>>>>
>>>>>>> * same for {{IllegalPropertyAccessException}};
>>>>>>>
>>>>>>> * same for {{SerializerDefinitionException}};
>>>>>>>
>>>>>>> * same for {{SerializerExecutionException}};
>>>>>>>
>>>>>>> * same for
>>>>>>> {{SerializerMarshallerGeneratorException}};
>>>>>>>
>>>>>>> * Please drop {{@author}} tags, feel free to add
>>>>>>> yourself in the {{contributors}} section in the
>>>>>>> parent POM - this is the right place where people are
>>>>>>> enlisted;
>>>>>>>
>>>>>>> * no needs to define a {{StringUtil}} class unless
>>>>>>> [Guava|
>>>>>>> http://code.google.com/p/guava-libraries/wiki/StringsExplained]
>>>>>>>
>>>>>>>
> doesn't provide the functionalities you need; the
>>>>>>> DirectMemory core module relies on Guava;
>>>>>>>
>>>>>>> * same for {{TypeUtil}}
>>>>>>>
>>>>>>> * why {{Benchmark}} class is annotated with
>>>>>>> {{@Ignore}}?
>>>>>>>
>>>>>>>> Lightning Serializer Contribution
>>>>>>>> ---------------------------------
>>>>>>>>
>>>>>>>> Key: DIRECTMEMORY-102 URL:
>>>>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102
>>>>>>>>
>>>>>>>
> Project: Apache DirectMemory Issue Type: New Feature
>>>>>>>> Components: Serializers Reporter: Christoph
>>>>>>>> Engelbert Attachments:
>>>>>>>> lightning_contribution.patch
>>>>>>>>
>>>>>>>>
>>>>>>>> This is the first contribution patch attempt for
>>>>>>>> the lightning
>>>>>>> serializer. If there are any things need to be
>>>>>>> changed please let me know.
>>>>>>>> PS: The issue tracker and sourcelocation values in
>>>>>>>> the pom.xml aren't
>>>>>>> set yet, since I had no clue what are the correct
>>>>>>> values but I guess that could be set later on.
>>>>>>>
>>>>>>> -- This message is automatically generated by JIRA.
>>>>>>> If you think it was sent incorrectly, please contact
>>>>>>> your JIRA administrators For more information on
>>>>>>> JIRA, see: http://www.atlassian.com/software/jira
>>>>>>>
>>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.12 (MingW32)
> Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
>
> iQIcBAEBAgAGBQJQaXECAAoJEH/g+YBfahrqux4P/iDCsqLQMayyINcnTOaWyo9B
> hJMVvouMB1Lf+l5QSjm0BnYJs2JTVfw1uAG+7EpU2IGE1F98+NMNnTkyGa9hDZQG
> /+/FRlm9WEu4yk6tWDf7v4RYbZp9qyfrEbKzYCIMoI00KcE9qGW3jmQiWO+alEPJ
> LP6/1idnvAiJGy3RCuEpwP9hS746C6zPazV4pJS7V+aX8d5eW73fJ3dGKMMUSNx6
> 74PxLUfRd/JOhzmiKZaggUL4vSNRS4ICwj9F3n1XNnXF0hvGpFR+hA3sQ8qEXlW0
> +xbgDzYZ2r1D3l1bMWItXP/67k8DJMDl5ye81//ZYPHXBRkcDmXTUOariNizHle9
> Q78ZqEQLjfoiqQD5g/D5WCzZf/yOMKaC76i8d0YI0yk0wsSHaN/5vM5zSaUFzh7E
> sTNGchZDTSacTowcyWQWZ5V+U6tDQThbZVMxu4aenS5CS4qCNChiZiQAevyaHb5V
> JPKPXgy/WJ/M/y7oCszRmIuSyuEz0qvH4ECzQ339POKkA3ZU8N0LrcH4NZzuI5df
> qjBMV+pyVjGc643ASERl5P/9k+HpMM8VFLtKmxVswj9T8G40qdLx0nLtspdH0Es1
> THNe80mQ9jZ9DerMdsBHWvdm/Qv72E78SRdIGD9x1ZDOtFwFACrFs7y0xevocenc
> Q+Rmltfp8AK9WUUs8pDK
> =Qlrj
> -----END PGP SIGNATURE-----

Re: [jira] [Commented] (DIRECTMEMORY-102) Lightning Serializer Contribution

Posted by Noctarius <me...@noctarius.com>.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hey Simone,

alright it's on it's way :-) Thanks for the explanation.

Like I mentioned earlier in the thread I never thought about
contributing it to the ASF so I haven't really looked on how a
contribution needs to be done.

Cheers Chris

Am 01.10.2012 12:22, schrieb Simone Tripodi:
> Hi Chris,
> 
> thanks for the follow-up!
> 
> I that see releases haven't been pushed yet, but unfortunately
> there is a rather that small codebase that is going to be
> donated - what I suggest you, in order to avoid any possible
> legal mistake, is submitting the SoftwareGrant[1] I linked you
> in the previous message; that would make clear that the
> codebase on github is going to be donated to the ASF.
> 
> What you have to do is pretty simple: like the ICLA, print the
> file, fill the few info, sign it and send the scanned version
> to secretary@, you should shortly receive the recorded SG
> notification.
> 
> HTH, have a nice day! -Simo
> 
> [1] http://www.apache.org/licenses/software-grant.txt
> 
> http://people.apache.org/~simonetripodi/ 
> http://simonetripodi.livejournal.com/ 
> http://twitter.com/simonetripodi http://www.99soft.org/
> 
> 
> On Mon, Oct 1, 2012 at 12:03 PM, Noctarius <me...@noctarius.com>
> wrote: Hi Simone,
> 
> no problem for misinterpreting it :) I thought something like
> that.
> 
> By now there is no release of Lightning, just the original 
> sourcecode on Github. Lightning wasn't fully production ready
> and I worked on releasing the first version. 
> https://github.com/noctarius/Lightning/issues?milestone=1&state=open
>
> 
:-)
> 
> I'm not sure if this needs a "software grant", whatever this is
> :-)
> 
> Cheers Chris
> 
> Am 01.10.2012 10:23, schrieb Simone Tripodi:
>>>> Hi Guys,
>>>> 
>>>> that perfectly explains why I didn't understand the 
>>>> contribution, please accept my apologize for
>>>> misinterpreting it and, above all, for not having
>>>> followed the main thread.
>>>> 
>>>> So, big +1 for having lightning aboard as both subproject
>>>> and serializer module, my added proposal is to separate
>>>> main DM trunk and lightning lifecycle in order to not
>>>> make releases depending each other.
>>>> 
>>>> Before importing Christoph codebase: I already noticed
>>>> he already signed the ICLA, but what about the original
>>>> codebase? If lightning already published some releases
>>>> outside the ASF, Christoph should submit a
>>>> SoftwareGrant[1] to donate his codebase to the ASF. If it
>>>> was already done, we are ready to import lightning!! :)
>>>> 
>>>> Have a nice day, -Simo
>>>> 
>>>> [1] http://www.apache.org/licenses/software-grant.txt
>>>> 
>>>> http://people.apache.org/~simonetripodi/ 
>>>> http://simonetripodi.livejournal.com/ 
>>>> http://twitter.com/simonetripodi http://www.99soft.org/
>>>> 
>>>> 
>>>> On Sun, Sep 30, 2012 at 3:47 PM, Raffaele P. Guidi 
>>>> <ra...@gmail.com> wrote:
>>>>> We were talking about separating the contribution in
>>>>> two pieces: lightning itself as a subproject under the 
>>>>> directmemory/lightning folder and then the serializer
>>>>> module for directmemory in the serialization folder.
>>>>> 
>>>>> Agreed to the coding style consideration (I forgot
>>>>> about it) and -regarding the ignore annotation - I
>>>>> found many of them in the main package, I think the
>>>>> point is that they have been moved to another module
>>>>> (more appropriate) and never deleted.
>>>>> 
>>>>> Ciao, R Il giorno 30/set/2012 15:05, "Simone Tripodi
>>>>> (JIRA)" <ji...@apache.org> ha scritto:
>>>>> 
>>>>>> 
>>>>>> [ 
>>>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466467#comment-13466467]
>>>>>>
>>>>>>
>>>>>>
>
>>>>>> 
Simone Tripodi commented on DIRECTMEMORY-102:
>>>>>> ---------------------------------------------
>>>>>> 
>>>>>> Hi Christoph,
>>>>>> 
>>>>>> thanks for contributing! Patch looks quiet good, I'd 
>>>>>> followup the discussion on the dev@ ML first, I have
>>>>>> some observations about the inclusion before applying
>>>>>> it. I am going to send a message following up the
>>>>>> current thread in a short while. Thanks *a lot* for
>>>>>> the hard work and congrats for that lib!
>>>>>> 
>>>>>> In the case you are looking for some feedbacks,
>>>>>> follow below few (ASF general) suggestions to submit
>>>>>> patches:
>>>>>> 
>>>>>> _Higher priority_
>>>>>> 
>>>>>> * serializer modules are put under the [serializers| 
>>>>>> https://svn.apache.org/repos/asf/directmemory/trunk/serializers/]
>>>>>>
>>>>>>
>
>>>>>> 
directory;
>>>>>> 
>>>>>> * no tabs; 2 spaces for XML sources, 4 spaces for
>>>>>> Java sources - generally, please respect the original
>>>>>> source code format, people here if following the
>>>>>> Apache Maven [code conventions| 
>>>>>> http://maven.apache.org/developers/conventions/code.html]
>>>>>>
>>>>>> 
(IDEs config included);
>>>>>> 
>>>>>> * According to other serializer modules, the package
>>>>>> should be moved to 
>>>>>> {{org.apache.directmemory.serialization.lightning}};
>>>>>> 
>>>>>> * No needs to define and implement yet another
>>>>>> logging abstraction level/façade:
>>>>>> 
>>>>>> * No needs to define a
>>>>>> {{Marshaller}}/{{Unmarshaller}}, the reference
>>>>>> interface can be directly the 
>>>>>> [org.apache.directmemory.serialization.Serializer| 
>>>>>> https://svn.apache.org/repos/asf/directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/serialization/Serializer.java]
>>>>>>
>>>>>>
>
>>>>>> 
class;
>>>>>> 
>>>>>> _Lower priority_
>>>>>> 
>>>>>> * please name patch file with the issue key, i.e. 
>>>>>> {{DIRECTMEMORY-102.patch}}, it helps committers that
>>>>>> are reviewing and applying patches;
>>>>>> 
>>>>>> * In the following code:
>>>>>> 
>>>>>> {code} +@SuppressWarnings("serial") +public class 
>>>>>> ClassDefinitionInconsistentException extends 
>>>>>> RuntimeException { {code}
>>>>>> 
>>>>>> you don't need to suppress the serial, you can add 
>>>>>> serialVersionUID field;
>>>>>> 
>>>>>> * same for {{IllegalAccessorException}};
>>>>>> 
>>>>>> * same for {{IllegalPropertyAccessException}};
>>>>>> 
>>>>>> * same for {{SerializerDefinitionException}};
>>>>>> 
>>>>>> * same for {{SerializerExecutionException}};
>>>>>> 
>>>>>> * same for
>>>>>> {{SerializerMarshallerGeneratorException}};
>>>>>> 
>>>>>> * Please drop {{@author}} tags, feel free to add
>>>>>> yourself in the {{contributors}} section in the
>>>>>> parent POM - this is the right place where people are
>>>>>> enlisted;
>>>>>> 
>>>>>> * no needs to define a {{StringUtil}} class unless
>>>>>> [Guava| 
>>>>>> http://code.google.com/p/guava-libraries/wiki/StringsExplained]
>>>>>>
>>>>>> 
doesn't provide the functionalities you need; the
>>>>>> DirectMemory core module relies on Guava;
>>>>>> 
>>>>>> * same for {{TypeUtil}}
>>>>>> 
>>>>>> * why {{Benchmark}} class is annotated with
>>>>>> {{@Ignore}}?
>>>>>> 
>>>>>>> Lightning Serializer Contribution 
>>>>>>> ---------------------------------
>>>>>>> 
>>>>>>> Key: DIRECTMEMORY-102 URL:
>>>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102
>>>>>>>
>>>>>> 
Project: Apache DirectMemory Issue Type: New Feature
>>>>>>> Components: Serializers Reporter: Christoph
>>>>>>> Engelbert Attachments:
>>>>>>> lightning_contribution.patch
>>>>>>> 
>>>>>>> 
>>>>>>> This is the first contribution patch attempt for
>>>>>>> the lightning
>>>>>> serializer. If there are any things need to be
>>>>>> changed please let me know.
>>>>>>> PS: The issue tracker and sourcelocation values in
>>>>>>> the pom.xml aren't
>>>>>> set yet, since I had no clue what are the correct
>>>>>> values but I guess that could be set later on.
>>>>>> 
>>>>>> -- This message is automatically generated by JIRA.
>>>>>> If you think it was sent incorrectly, please contact
>>>>>> your JIRA administrators For more information on
>>>>>> JIRA, see: http://www.atlassian.com/software/jira
>>>>>> 
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (MingW32)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iQIcBAEBAgAGBQJQaXECAAoJEH/g+YBfahrqux4P/iDCsqLQMayyINcnTOaWyo9B
hJMVvouMB1Lf+l5QSjm0BnYJs2JTVfw1uAG+7EpU2IGE1F98+NMNnTkyGa9hDZQG
/+/FRlm9WEu4yk6tWDf7v4RYbZp9qyfrEbKzYCIMoI00KcE9qGW3jmQiWO+alEPJ
LP6/1idnvAiJGy3RCuEpwP9hS746C6zPazV4pJS7V+aX8d5eW73fJ3dGKMMUSNx6
74PxLUfRd/JOhzmiKZaggUL4vSNRS4ICwj9F3n1XNnXF0hvGpFR+hA3sQ8qEXlW0
+xbgDzYZ2r1D3l1bMWItXP/67k8DJMDl5ye81//ZYPHXBRkcDmXTUOariNizHle9
Q78ZqEQLjfoiqQD5g/D5WCzZf/yOMKaC76i8d0YI0yk0wsSHaN/5vM5zSaUFzh7E
sTNGchZDTSacTowcyWQWZ5V+U6tDQThbZVMxu4aenS5CS4qCNChiZiQAevyaHb5V
JPKPXgy/WJ/M/y7oCszRmIuSyuEz0qvH4ECzQ339POKkA3ZU8N0LrcH4NZzuI5df
qjBMV+pyVjGc643ASERl5P/9k+HpMM8VFLtKmxVswj9T8G40qdLx0nLtspdH0Es1
THNe80mQ9jZ9DerMdsBHWvdm/Qv72E78SRdIGD9x1ZDOtFwFACrFs7y0xevocenc
Q+Rmltfp8AK9WUUs8pDK
=Qlrj
-----END PGP SIGNATURE-----

Re: [jira] [Commented] (DIRECTMEMORY-102) Lightning Serializer Contribution

Posted by Simone Tripodi <si...@apache.org>.

Hi Chris,

thanks for the follow-up!

I that see releases haven't been pushed yet, but unfortunately there
is a rather that small codebase that is going to be donated - what I
suggest you, in order to avoid any possible legal mistake, is
submitting the SoftwareGrant[1] I linked you in the previous message;
that would make clear that the codebase on github is going to be
donated to the ASF.

What you have to do is pretty simple: like the ICLA, print the file,
fill the few info, sign it and send the scanned version to secretary@,
you should shortly receive the recorded SG notification.

HTH, have a nice day!
-Simo

[1] http://www.apache.org/licenses/software-grant.txt

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/


On Mon, Oct 1, 2012 at 12:03 PM, Noctarius <me...@noctarius.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi Simone,
>
> no problem for misinterpreting it :) I thought something like that.
>
> By now there is no release of Lightning, just the original
> sourcecode on Github. Lightning wasn't fully production ready and
> I worked on releasing the first version.
> https://github.com/noctarius/Lightning/issues?milestone=1&state=open
> :-)
>
> I'm not sure if this needs a "software grant", whatever this is :-)
>
> Cheers Chris
>
> Am 01.10.2012 10:23, schrieb Simone Tripodi:
>> Hi Guys,
>>
>> that perfectly explains why I didn't understand the
>> contribution, please accept my apologize for misinterpreting it
>> and, above all, for not having followed the main thread.
>>
>> So, big +1 for having lightning aboard as both subproject and
>> serializer module, my added proposal is to separate main DM
>> trunk and lightning lifecycle in order to not make releases
>> depending each other.
>>
>> Before importing Christoph codebase: I already noticed he
>> already signed the ICLA, but what about the original codebase?
>> If lightning already published some releases outside the ASF,
>> Christoph should submit a SoftwareGrant[1] to donate his
>> codebase to the ASF. If it was already done, we are ready to
>> import lightning!! :)
>>
>> Have a nice day, -Simo
>>
>> [1] http://www.apache.org/licenses/software-grant.txt
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi http://www.99soft.org/
>>
>>
>> On Sun, Sep 30, 2012 at 3:47 PM, Raffaele P. Guidi
>> <ra...@gmail.com> wrote:
>>> We were talking about separating the contribution in two
>>> pieces: lightning itself as a subproject under the
>>> directmemory/lightning folder and then the serializer module
>>> for directmemory in the serialization folder.
>>>
>>> Agreed to the coding style consideration (I forgot about it)
>>> and -regarding the ignore annotation - I found many of them
>>> in the main package, I think the point is that they have been
>>> moved to another module (more appropriate) and never
>>> deleted.
>>>
>>> Ciao, R Il giorno 30/set/2012 15:05, "Simone Tripodi (JIRA)"
>>> <ji...@apache.org> ha scritto:
>>>
>>>>
>>>> [
>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466467#comment-13466467]
>>>>
>>>>
>>>>
> Simone Tripodi commented on DIRECTMEMORY-102:
>>>> ---------------------------------------------
>>>>
>>>> Hi Christoph,
>>>>
>>>> thanks for contributing! Patch looks quiet good, I'd
>>>> followup the discussion on the dev@ ML first, I have some
>>>> observations about the inclusion before applying it. I am
>>>> going to send a message following up the current thread in
>>>> a short while. Thanks *a lot* for the hard work and
>>>> congrats for that lib!
>>>>
>>>> In the case you are looking for some feedbacks, follow
>>>> below few (ASF general) suggestions to submit patches:
>>>>
>>>> _Higher priority_
>>>>
>>>> * serializer modules are put under the [serializers|
>>>> https://svn.apache.org/repos/asf/directmemory/trunk/serializers/]
>>>>
>>>>
> directory;
>>>>
>>>> * no tabs; 2 spaces for XML sources, 4 spaces for Java
>>>> sources - generally, please respect the original source
>>>> code format, people here if following the Apache Maven
>>>> [code conventions|
>>>> http://maven.apache.org/developers/conventions/code.html]
>>>> (IDEs config included);
>>>>
>>>> * According to other serializer modules, the package should
>>>> be moved to
>>>> {{org.apache.directmemory.serialization.lightning}};
>>>>
>>>> * No needs to define and implement yet another logging
>>>> abstraction level/façade:
>>>>
>>>> * No needs to define a {{Marshaller}}/{{Unmarshaller}}, the
>>>> reference interface can be directly the
>>>> [org.apache.directmemory.serialization.Serializer|
>>>> https://svn.apache.org/repos/asf/directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/serialization/Serializer.java]
>>>>
>>>>
> class;
>>>>
>>>> _Lower priority_
>>>>
>>>> * please name patch file with the issue key, i.e.
>>>> {{DIRECTMEMORY-102.patch}}, it helps committers that are
>>>> reviewing and applying patches;
>>>>
>>>> * In the following code:
>>>>
>>>> {code} +@SuppressWarnings("serial") +public class
>>>> ClassDefinitionInconsistentException extends
>>>> RuntimeException { {code}
>>>>
>>>> you don't need to suppress the serial, you can add
>>>> serialVersionUID field;
>>>>
>>>> * same for {{IllegalAccessorException}};
>>>>
>>>> * same for {{IllegalPropertyAccessException}};
>>>>
>>>> * same for {{SerializerDefinitionException}};
>>>>
>>>> * same for {{SerializerExecutionException}};
>>>>
>>>> * same for {{SerializerMarshallerGeneratorException}};
>>>>
>>>> * Please drop {{@author}} tags, feel free to add yourself
>>>> in the {{contributors}} section in the parent POM - this is
>>>> the right place where people are enlisted;
>>>>
>>>> * no needs to define a {{StringUtil}} class unless [Guava|
>>>> http://code.google.com/p/guava-libraries/wiki/StringsExplained]
>>>> doesn't provide the functionalities you need; the
>>>> DirectMemory core module relies on Guava;
>>>>
>>>> * same for {{TypeUtil}}
>>>>
>>>> * why {{Benchmark}} class is annotated with {{@Ignore}}?
>>>>
>>>>> Lightning Serializer Contribution
>>>>> ---------------------------------
>>>>>
>>>>> Key: DIRECTMEMORY-102 URL:
>>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102
>>>>> Project: Apache DirectMemory Issue Type: New Feature
>>>>> Components: Serializers Reporter: Christoph Engelbert
>>>>> Attachments: lightning_contribution.patch
>>>>>
>>>>>
>>>>> This is the first contribution patch attempt for the
>>>>> lightning
>>>> serializer. If there are any things need to be changed
>>>> please let me know.
>>>>> PS: The issue tracker and sourcelocation values in the
>>>>> pom.xml aren't
>>>> set yet, since I had no clue what are the correct values
>>>> but I guess that could be set later on.
>>>>
>>>> -- This message is automatically generated by JIRA. If you
>>>> think it was sent incorrectly, please contact your JIRA
>>>> administrators For more information on JIRA, see:
>>>> http://www.atlassian.com/software/jira
>>>>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.12 (MingW32)
> Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
>
> iQIcBAEBAgAGBQJQaWqIAAoJEH/g+YBfahrqNPIP/0OM0ar4VEFBQpSaPqHsdAGR
> jMUndcS5exZ5SEHFoAVsi5L8kicmfDrXfoBEnLpxWiE75acy/4pBiLBzSv6sxzrC
> RBfamUhCUgJ696bWW2S4cGI2geHl+d4SW+BGBmbmZZGd8dchUL09wua+WhI44ObS
> aX4TRENRKWCfiK5MDB/Cqxykhw6S5kPHYVgOjJKZy0nSuX7TQ1LWtCnCvt4yKZDi
> dlq443nf1dbsceVT10FLc3FTzi56Xa814utXu/tywH/+xr25hbh6nTC1kx6T3T7T
> bCxJd8gFWdDGWgOQ6zGMCBC213ARH4VtI1/0aqXjhn6OwBvJQmQEAt58+NLl5mHd
> ZCEM7yF8FbVMmceR6xaUo1NDGd6qcvY2erghZTzUzEGF0Retiro9roRZ/6cUIR8C
> 3YGdRcJptRawX3LsVNQduWvUuT+z4U9+aL6OVU2FtXwoNNeApiIyGPvlQwDYfBoj
> 2cx8PNtiEGUh7411l97PyEFy7l90Q0onG/GCCCF8jU9HigwUdSOqWrzIe+Pb5jQd
> vTMwPP0OqyevMfH4oRhQTfDc63bcGJhbdX+kebaG86U4/xBU0ohCATFXrK59di/Q
> U1Qxk0j0ZOKKiJ6Ub1Hf+kRabsj/aowuiFrE03TwyUjLYe2ZcOWHFHRBT4C6X/bP
> l4wWfIeLg3bwgsTOZwuC
> =U5gv
> -----END PGP SIGNATURE-----

Re: [jira] [Commented] (DIRECTMEMORY-102) Lightning Serializer Contribution

Posted by Noctarius <me...@noctarius.com>.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Simone,

no problem for misinterpreting it :) I thought something like that.

By now there is no release of Lightning, just the original
sourcecode on Github. Lightning wasn't fully production ready and
I worked on releasing the first version.
https://github.com/noctarius/Lightning/issues?milestone=1&state=open
:-)

I'm not sure if this needs a "software grant", whatever this is :-)

Cheers Chris

Am 01.10.2012 10:23, schrieb Simone Tripodi:
> Hi Guys,
> 
> that perfectly explains why I didn't understand the
> contribution, please accept my apologize for misinterpreting it
> and, above all, for not having followed the main thread.
> 
> So, big +1 for having lightning aboard as both subproject and 
> serializer module, my added proposal is to separate main DM
> trunk and lightning lifecycle in order to not make releases
> depending each other.
> 
> Before importing Christoph codebase: I already noticed he
> already signed the ICLA, but what about the original codebase?
> If lightning already published some releases outside the ASF,
> Christoph should submit a SoftwareGrant[1] to donate his
> codebase to the ASF. If it was already done, we are ready to
> import lightning!! :)
> 
> Have a nice day, -Simo
> 
> [1] http://www.apache.org/licenses/software-grant.txt
> 
> http://people.apache.org/~simonetripodi/ 
> http://simonetripodi.livejournal.com/ 
> http://twitter.com/simonetripodi http://www.99soft.org/
> 
> 
> On Sun, Sep 30, 2012 at 3:47 PM, Raffaele P. Guidi 
> <ra...@gmail.com> wrote:
>> We were talking about separating the contribution in two
>> pieces: lightning itself as a subproject under the
>> directmemory/lightning folder and then the serializer module
>> for directmemory in the serialization folder.
>> 
>> Agreed to the coding style consideration (I forgot about it)
>> and -regarding the ignore annotation - I found many of them
>> in the main package, I think the point is that they have been
>> moved to another module (more appropriate) and never
>> deleted.
>> 
>> Ciao, R Il giorno 30/set/2012 15:05, "Simone Tripodi (JIRA)"
>> <ji...@apache.org> ha scritto:
>> 
>>> 
>>> [ 
>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466467#comment-13466467]
>>>
>>>
>>> 
Simone Tripodi commented on DIRECTMEMORY-102:
>>> ---------------------------------------------
>>> 
>>> Hi Christoph,
>>> 
>>> thanks for contributing! Patch looks quiet good, I'd
>>> followup the discussion on the dev@ ML first, I have some
>>> observations about the inclusion before applying it. I am
>>> going to send a message following up the current thread in
>>> a short while. Thanks *a lot* for the hard work and
>>> congrats for that lib!
>>> 
>>> In the case you are looking for some feedbacks, follow
>>> below few (ASF general) suggestions to submit patches:
>>> 
>>> _Higher priority_
>>> 
>>> * serializer modules are put under the [serializers| 
>>> https://svn.apache.org/repos/asf/directmemory/trunk/serializers/]
>>>
>>> 
directory;
>>> 
>>> * no tabs; 2 spaces for XML sources, 4 spaces for Java
>>> sources - generally, please respect the original source
>>> code format, people here if following the Apache Maven
>>> [code conventions| 
>>> http://maven.apache.org/developers/conventions/code.html]
>>> (IDEs config included);
>>> 
>>> * According to other serializer modules, the package should
>>> be moved to 
>>> {{org.apache.directmemory.serialization.lightning}};
>>> 
>>> * No needs to define and implement yet another logging
>>> abstraction level/façade:
>>> 
>>> * No needs to define a {{Marshaller}}/{{Unmarshaller}}, the
>>> reference interface can be directly the 
>>> [org.apache.directmemory.serialization.Serializer| 
>>> https://svn.apache.org/repos/asf/directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/serialization/Serializer.java]
>>>
>>> 
class;
>>> 
>>> _Lower priority_
>>> 
>>> * please name patch file with the issue key, i.e. 
>>> {{DIRECTMEMORY-102.patch}}, it helps committers that are
>>> reviewing and applying patches;
>>> 
>>> * In the following code:
>>> 
>>> {code} +@SuppressWarnings("serial") +public class
>>> ClassDefinitionInconsistentException extends 
>>> RuntimeException { {code}
>>> 
>>> you don't need to suppress the serial, you can add
>>> serialVersionUID field;
>>> 
>>> * same for {{IllegalAccessorException}};
>>> 
>>> * same for {{IllegalPropertyAccessException}};
>>> 
>>> * same for {{SerializerDefinitionException}};
>>> 
>>> * same for {{SerializerExecutionException}};
>>> 
>>> * same for {{SerializerMarshallerGeneratorException}};
>>> 
>>> * Please drop {{@author}} tags, feel free to add yourself
>>> in the {{contributors}} section in the parent POM - this is
>>> the right place where people are enlisted;
>>> 
>>> * no needs to define a {{StringUtil}} class unless [Guava| 
>>> http://code.google.com/p/guava-libraries/wiki/StringsExplained]
>>> doesn't provide the functionalities you need; the
>>> DirectMemory core module relies on Guava;
>>> 
>>> * same for {{TypeUtil}}
>>> 
>>> * why {{Benchmark}} class is annotated with {{@Ignore}}?
>>> 
>>>> Lightning Serializer Contribution 
>>>> ---------------------------------
>>>> 
>>>> Key: DIRECTMEMORY-102 URL:
>>> https://issues.apache.org/jira/browse/DIRECTMEMORY-102
>>>> Project: Apache DirectMemory Issue Type: New Feature 
>>>> Components: Serializers Reporter: Christoph Engelbert 
>>>> Attachments: lightning_contribution.patch
>>>> 
>>>> 
>>>> This is the first contribution patch attempt for the
>>>> lightning
>>> serializer. If there are any things need to be changed
>>> please let me know.
>>>> PS: The issue tracker and sourcelocation values in the
>>>> pom.xml aren't
>>> set yet, since I had no clue what are the correct values
>>> but I guess that could be set later on.
>>> 
>>> -- This message is automatically generated by JIRA. If you
>>> think it was sent incorrectly, please contact your JIRA 
>>> administrators For more information on JIRA, see:
>>> http://www.atlassian.com/software/jira
>>> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (MingW32)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iQIcBAEBAgAGBQJQaWqIAAoJEH/g+YBfahrqNPIP/0OM0ar4VEFBQpSaPqHsdAGR
jMUndcS5exZ5SEHFoAVsi5L8kicmfDrXfoBEnLpxWiE75acy/4pBiLBzSv6sxzrC
RBfamUhCUgJ696bWW2S4cGI2geHl+d4SW+BGBmbmZZGd8dchUL09wua+WhI44ObS
aX4TRENRKWCfiK5MDB/Cqxykhw6S5kPHYVgOjJKZy0nSuX7TQ1LWtCnCvt4yKZDi
dlq443nf1dbsceVT10FLc3FTzi56Xa814utXu/tywH/+xr25hbh6nTC1kx6T3T7T
bCxJd8gFWdDGWgOQ6zGMCBC213ARH4VtI1/0aqXjhn6OwBvJQmQEAt58+NLl5mHd
ZCEM7yF8FbVMmceR6xaUo1NDGd6qcvY2erghZTzUzEGF0Retiro9roRZ/6cUIR8C
3YGdRcJptRawX3LsVNQduWvUuT+z4U9+aL6OVU2FtXwoNNeApiIyGPvlQwDYfBoj
2cx8PNtiEGUh7411l97PyEFy7l90Q0onG/GCCCF8jU9HigwUdSOqWrzIe+Pb5jQd
vTMwPP0OqyevMfH4oRhQTfDc63bcGJhbdX+kebaG86U4/xBU0ohCATFXrK59di/Q
U1Qxk0j0ZOKKiJ6Ub1Hf+kRabsj/aowuiFrE03TwyUjLYe2ZcOWHFHRBT4C6X/bP
l4wWfIeLg3bwgsTOZwuC
=U5gv
-----END PGP SIGNATURE-----