You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/02/25 01:19:21 UTC
[GitHub] [incubator-yunikorn-k8shim] yangwwei opened a new pull request #235: [YUNIKORN-549] Scheduler recovery failure occasionally while recovering a large number of applications.
yangwwei opened a new pull request #235:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/235
The fix removes the flag `AddApplicationRequest#ApplicationMetadata#Recovery`, the recovery process no longer depends on which pod is seen by the shim to determine if the app needs recovery or not. Instead, it calls the K8s lister to list all apps that needs to be recovered, and then trigger recovery for them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #235: [YUNIKORN-549] Scheduler recovery failure occasionally while recovering a large number of applications.
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #235:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/235
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #235: [YUNIKORN-549] Scheduler recovery failure occasionally while recovering a large number of applications.
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #235:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/235#issuecomment-785508430
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/235?src=pr&el=h1) Report
> Merging [#235](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/235?src=pr&el=desc) (0c202e2) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **increase** coverage by `0.16%`.
> The diff coverage is `48.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/235?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
+ Coverage 59.75% 59.91% +0.16%
==========================================
Files 35 35
Lines 3133 3126 -7
==========================================
+ Hits 1872 1873 +1
+ Misses 1180 1171 -9
- Partials 81 82 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/235?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/appmgmt/appmgmt\_recovery.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/235/diff?src=pr&el=tree#diff-cGtnL2FwcG1nbXQvYXBwbWdtdF9yZWNvdmVyeS5nbw==) | `67.50% <0.00%> (-8.18%)` | :arrow_down: |
| [pkg/appmgmt/general/general.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/235/diff?src=pr&el=tree#diff-cGtnL2FwcG1nbXQvZ2VuZXJhbC9nZW5lcmFsLmdv) | `59.21% <ø> (-0.27%)` | :arrow_down: |
| [pkg/cache/amprotocol\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/235/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FtcHJvdG9jb2xfbW9jay5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/235/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `79.36% <ø> (-0.33%)` | :arrow_down: |
| [pkg/controller/application/app\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/235/diff?src=pr&el=tree#diff-cGtnL2NvbnRyb2xsZXIvYXBwbGljYXRpb24vYXBwX2NvbnRyb2xsZXIuZ28=) | `71.05% <ø> (-0.26%)` | :arrow_down: |
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/235/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/235/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `78.27% <100.00%> (+1.53%)` | :arrow_up: |
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/235/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `40.27% <100.00%> (-0.81%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/235?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/235?src=pr&el=footer). Last update [3b54b92...0c202e2](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/235?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org