You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by "Gordon Sim (JIRA)" <ji...@apache.org> on 2012/11/28 17:12:57 UTC
[jira] [Created] (PROTON-170) generated pkg config file doesn't
actually include paths if a different install location is used
Gordon Sim created PROTON-170:
---------------------------------
Summary: generated pkg config file doesn't actually include paths if a different install location is used
Key: PROTON-170
URL: https://issues.apache.org/jira/browse/PROTON-170
Project: Qpid Proton
Issue Type: Bug
Components: proton-c
Affects Versions: 0.2
Reporter: Gordon Sim
E.g. cmake -DCMAKE_INSTALL_PREFIX=/path/to/non-standard/install && make install will install a pkg config file that doesn't have the include and lib directories set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PROTON-170) generated pkg config file doesn't
actually include paths if a different install location is used
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gordon Sim reassigned PROTON-170:
---------------------------------
Assignee: Andrew Stitcher
Andrew, requesting review from someone more expert in cmake and pkgconfig...
> generated pkg config file doesn't actually include paths if a different install location is used
> ------------------------------------------------------------------------------------------------
>
> Key: PROTON-170
> URL: https://issues.apache.org/jira/browse/PROTON-170
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Affects Versions: 0.2
> Reporter: Gordon Sim
> Assignee: Andrew Stitcher
> Attachments: PROTON-170.patch
>
>
> E.g. cmake -DCMAKE_INSTALL_PREFIX=/path/to/non-standard/install && make install will install a pkg config file that doesn't have the include and lib directories set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-170) generated pkg config file is broken
Posted by "Andrew Stitcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507600#comment-13507600 ]
Andrew Stitcher commented on PROTON-170:
----------------------------------------
No problem with the comment change! (although I did copy the initial file directly from qpid so I expect the same problem exists there)
I'm not 100% sure about the fix you've got there since I don't think that CMAKE_INSTALL_PREFIX has to be an absolute path (and I seem to remember discussing with Rafi that in fact that is the way he uses CMAKE_INSTALL_PREFIX).
I think it'd be more flexible to add in definitions for LIBDIR and INCLUDEDIR to CMakeLists.txt rather than change the .pc file (that is how we do it in qpid) - it seems I just failed to copy it over correctly from qpid and didn't notice
> generated pkg config file is broken
> -----------------------------------
>
> Key: PROTON-170
> URL: https://issues.apache.org/jira/browse/PROTON-170
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Affects Versions: 0.2
> Reporter: Gordon Sim
> Assignee: Andrew Stitcher
> Attachments: PROTON-170.patch
>
>
> E.g. cmake -DCMAKE_INSTALL_PREFIX=/path/to/non-standard/install && make install will install a pkg config file that doesn't have the include and lib directories set.
> Also Cflags is set to -I${includedir} which breaks compilation even for a standard install if the includedir is not set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-170) generated pkg config file is broken
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gordon Sim updated PROTON-170:
------------------------------
Description:
E.g. cmake -DCMAKE_INSTALL_PREFIX=/path/to/non-standard/install && make install will install a pkg config file that doesn't have the include and lib directories set.
Also Cflags is set to -I${includedir} which breaks compilation even for a standard install if the includedir is not set.
was:E.g. cmake -DCMAKE_INSTALL_PREFIX=/path/to/non-standard/install && make install will install a pkg config file that doesn't have the include and lib directories set.
Summary: generated pkg config file is broken (was: generated pkg config file doesn't actually include paths if a different install location is used)
> generated pkg config file is broken
> -----------------------------------
>
> Key: PROTON-170
> URL: https://issues.apache.org/jira/browse/PROTON-170
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Affects Versions: 0.2
> Reporter: Gordon Sim
> Assignee: Andrew Stitcher
> Attachments: PROTON-170.patch
>
>
> E.g. cmake -DCMAKE_INSTALL_PREFIX=/path/to/non-standard/install && make install will install a pkg config file that doesn't have the include and lib directories set.
> Also Cflags is set to -I${includedir} which breaks compilation even for a standard install if the includedir is not set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-170) generated pkg config file doesn't
actually include paths if a different install location is used
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gordon Sim updated PROTON-170:
------------------------------
Attachment: PROTON-170.patch
This alters the template for the pkgconfig file such that the correct (at least in my case!) lib and include are written into the generated file.
It also changes the commenting style to what I believe is the standard for .pc files (though this may not be strictly necessary).
> generated pkg config file doesn't actually include paths if a different install location is used
> ------------------------------------------------------------------------------------------------
>
> Key: PROTON-170
> URL: https://issues.apache.org/jira/browse/PROTON-170
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Affects Versions: 0.2
> Reporter: Gordon Sim
> Attachments: PROTON-170.patch
>
>
> E.g. cmake -DCMAKE_INSTALL_PREFIX=/path/to/non-standard/install && make install will install a pkg config file that doesn't have the include and lib directories set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-170) generated pkg config file is broken
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507609#comment-13507609 ]
Gordon Sim commented on PROTON-170:
-----------------------------------
The comment was added after you put the template into protons tree (I think as part of some automated process in response to RAT), so in qpid it has no comment (which I actually think is probably not a problem anyway).
> generated pkg config file is broken
> -----------------------------------
>
> Key: PROTON-170
> URL: https://issues.apache.org/jira/browse/PROTON-170
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Affects Versions: 0.2
> Reporter: Gordon Sim
> Assignee: Andrew Stitcher
> Attachments: PROTON-170.patch
>
>
> E.g. cmake -DCMAKE_INSTALL_PREFIX=/path/to/non-standard/install && make install will install a pkg config file that doesn't have the include and lib directories set.
> Also Cflags is set to -I${includedir} which breaks compilation even for a standard install if the includedir is not set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira