You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Aditya Auradkar <aa...@linkedin.com> on 2015/02/03 19:49:29 UTC
Review Request 30570: Patch for KAFKA-1914
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30570/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1914
https://issues.apache.org/jira/browse/KAFKA-1914
Repository: kafka
Description
-------
Fixing KAFKA-1914. Adding metrics to count total number of produce and fetch metrics
Diffs
-----
core/src/main/scala/kafka/server/KafkaRequestHandler.scala e4053fbe8ef78bf8bc39cb3f8ea4c21032613a16
core/src/main/scala/kafka/server/ReplicaManager.scala fb948b9ab28c516e81dab14dcbe211dcd99842b6
core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala ccf5e2e36260b2484181b81d1b06e81de972674b
Diff: https://reviews.apache.org/r/30570/diff/
Testing
-------
Thanks,
Aditya Auradkar
Re: Review Request 30570: Patch for KAFKA-1914
Posted by Aditya Auradkar <aa...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30570/
-----------------------------------------------------------
(Updated Feb. 3, 2015, 6:50 p.m.)
Review request for kafka.
Bugs: KAFKA-1914
https://issues.apache.org/jira/browse/KAFKA-1914
Repository: kafka
Description
-------
Fixing KAFKA-1914. Adding metrics to count total number of produce and fetch metrics
Diffs
-----
core/src/main/scala/kafka/server/KafkaRequestHandler.scala e4053fbe8ef78bf8bc39cb3f8ea4c21032613a16
core/src/main/scala/kafka/server/ReplicaManager.scala fb948b9ab28c516e81dab14dcbe211dcd99842b6
core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala ccf5e2e36260b2484181b81d1b06e81de972674b
Diff: https://reviews.apache.org/r/30570/diff/
Testing (updated)
-------
I've added asserts to the SimpleFetchTest to count the number of fetch requests. I'm going to file an additional jira to add unit tests for all the BrokerTopicMetrics updated via ReplicaManager
Thanks,
Aditya Auradkar