You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2019/12/07 20:54:21 UTC

[camel] 05/08: CAMEL-14263: camel-crypto should use source code generated configurer to avoid reflection configuration.

This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 577570105381a110982ed1715abb620556329e2e
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Sat Dec 7 21:27:00 2019 +0100

    CAMEL-14263: camel-crypto should use source code generated configurer to avoid reflection configuration.
---
 .../camel/component/crypto/DigitalSignatureComponent.java      | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/components/camel-crypto/src/main/java/org/apache/camel/component/crypto/DigitalSignatureComponent.java b/components/camel-crypto/src/main/java/org/apache/camel/component/crypto/DigitalSignatureComponent.java
index d7d3f71..b6d7d35 100644
--- a/components/camel-crypto/src/main/java/org/apache/camel/component/crypto/DigitalSignatureComponent.java
+++ b/components/camel-crypto/src/main/java/org/apache/camel/component/crypto/DigitalSignatureComponent.java
@@ -31,7 +31,7 @@ import org.apache.camel.util.ObjectHelper;
 public class DigitalSignatureComponent extends DefaultComponent {
 
     @Metadata(label = "advanced")
-    private DigitalSignatureConfiguration configuration;
+    private DigitalSignatureConfiguration configuration = new DigitalSignatureConfiguration();
 
     public DigitalSignatureComponent() {
     }
@@ -46,7 +46,6 @@ public class DigitalSignatureComponent extends DefaultComponent {
 
         DigitalSignatureConfiguration config = getConfiguration().copy();
 
-        setProperties(config, parameters);
         config.setCamelContext(getCamelContext());
         try {
             config.setCryptoOperation(new URI(remaining).getScheme());
@@ -54,13 +53,12 @@ public class DigitalSignatureComponent extends DefaultComponent {
             throw new MalformedURLException(String.format("An invalid crypto uri was provided '%s'."
                     + " Check the uri matches the format crypto:sign or crypto:verify", uri));
         }
-        return new DigitalSignatureEndpoint(uri, this, config);
+        Endpoint endpoint = new DigitalSignatureEndpoint(uri, this, config);
+        setProperties(endpoint, parameters);
+        return endpoint;
     }
 
     public DigitalSignatureConfiguration getConfiguration() {
-        if (configuration == null) {
-            configuration = new DigitalSignatureConfiguration();
-        }
         return configuration;
     }