You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Paul Benedict (JIRA)" <ji...@apache.org> on 2007/08/20 11:59:34 UTC

[jira] Updated: (STR-1455) [taglib] BaseFieldTag don't use ConvertUtils as String output formatting

     [ https://issues.apache.org/struts/browse/STR-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Benedict updated STR-1455:
-------------------------------

    Fix Version/s: Future
         Assignee:     (was: Struts Developers)

> [taglib] BaseFieldTag don't use ConvertUtils as String output formatting
> ------------------------------------------------------------------------
>
>                 Key: STR-1455
>                 URL: https://issues.apache.org/struts/browse/STR-1455
>             Project: Struts 1
>          Issue Type: Improvement
>          Components: Taglibs
>    Affects Versions: 1.1 RC1
>         Environment: Operating System: other
> Platform: Other
>            Reporter: Tong Ka Man
>            Priority: Minor
>             Fix For: Future
>
>         Attachments: BaseFieldTag.java.diff
>
>
> As the tag value does not necessariliy output by .toString() method, such as
> Date object.  I think it would be better to call a converter to do the
> Object-to-String output formatting and let the developer decide to load a
> Converter by ConvertUtils.
> Below is my little patch.
> Index: src/share/org/apache/struts/taglib/html/BaseFieldTag.java
> ===================================================================
> RCS file:
> /home/cvspublic/jakarta-struts/src/share/org/apache/struts/taglib/html/BaseFieldTag.java,v
> retrieving revision 1.17
> diff -r1.17 BaseFieldTag.java
> 66a67
> > import org.apache.commons.beanutils.ConvertUtils;
> 179c180
> <             results.append(ResponseUtils.filter(value.toString()));
> ---
> >             results.append(ResponseUtils.filter(ConvertUtils.convert(value)));

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.