You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2023/02/21 03:50:59 UTC
[GitHub] [kyuubi] turboFei opened a new pull request, #4389: [KYUUBI #3951][FOLLOWUP] Audit the rest request params
turboFei opened a new pull request, #4389:
URL: https://github.com/apache/kyuubi/pull/4389
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei commented on pull request #4389: [KYUUBI #3951][FOLLOWUP] Audit the rest request params
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #4389:
URL: https://github.com/apache/kyuubi/pull/4389#issuecomment-1437860337
thanks, merged to master and branch-1.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] cxzl25 commented on a diff in pull request #4389: [KYUUBI #3951][FOLLOWUP] Audit the rest request params
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #4389:
URL: https://github.com/apache/kyuubi/pull/4389#discussion_r1112509354
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/http/authentication/AuthenticationAuditLogger.scala:
##########
@@ -35,6 +35,7 @@ object AuthenticationAuditLogger extends Logging {
sb.append(s"proxyIp=${HTTP_PROXY_HEADER_CLIENT_IP_ADDRESS.get()}").append("\t")
sb.append(s"method=${request.getMethod}").append("\t")
sb.append(s"uri=${request.getRequestURI}").append("\t")
+ Option(request.getQueryString).foreach(params => sb.append(s"params=$params").append("\t"))
Review Comment:
If `params` has no parameters, can we also output `params=` to ensure the same format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei commented on a diff in pull request #4389: [KYUUBI #3951][FOLLOWUP] Audit the rest request params
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #4389:
URL: https://github.com/apache/kyuubi/pull/4389#discussion_r1112509937
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/http/authentication/AuthenticationAuditLogger.scala:
##########
@@ -35,6 +35,7 @@ object AuthenticationAuditLogger extends Logging {
sb.append(s"proxyIp=${HTTP_PROXY_HEADER_CLIENT_IP_ADDRESS.get()}").append("\t")
sb.append(s"method=${request.getMethod}").append("\t")
sb.append(s"uri=${request.getRequestURI}").append("\t")
+ Option(request.getQueryString).foreach(params => sb.append(s"params=$params").append("\t"))
Review Comment:
sounds good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei commented on a diff in pull request #4389: [KYUUBI #3951][FOLLOWUP] Audit the rest request params
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #4389:
URL: https://github.com/apache/kyuubi/pull/4389#discussion_r1112511035
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/http/authentication/AuthenticationAuditLogger.scala:
##########
@@ -35,7 +35,7 @@ object AuthenticationAuditLogger extends Logging {
sb.append(s"proxyIp=${HTTP_PROXY_HEADER_CLIENT_IP_ADDRESS.get()}").append("\t")
sb.append(s"method=${request.getMethod}").append("\t")
sb.append(s"uri=${request.getRequestURI}").append("\t")
- Option(request.getQueryString).foreach(params => sb.append(s"params=$params").append("\t"))
+ Option(request.getQueryString).foreach(params => sb.append(s"params='$params'").append("\t"))
Review Comment:
revert it, because we need record the null params
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei commented on a diff in pull request #4389: [KYUUBI #3951][FOLLOWUP] Audit the rest request params
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #4389:
URL: https://github.com/apache/kyuubi/pull/4389#discussion_r1112509672
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/http/authentication/AuthenticationAuditLogger.scala:
##########
@@ -35,7 +35,7 @@ object AuthenticationAuditLogger extends Logging {
sb.append(s"proxyIp=${HTTP_PROXY_HEADER_CLIENT_IP_ADDRESS.get()}").append("\t")
sb.append(s"method=${request.getMethod}").append("\t")
sb.append(s"uri=${request.getRequestURI}").append("\t")
- Option(request.getQueryString).foreach(params => sb.append(s"params=$params").append("\t"))
+ Option(request.getQueryString).foreach(params => sb.append(s"params='$params'").append("\t"))
Review Comment:
```
params='maxrows=2&fetchorientation=FETCH_NEXT'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei commented on pull request #4389: [KYUUBI #3951][FOLLOWUP] Audit the rest request params
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #4389:
URL: https://github.com/apache/kyuubi/pull/4389#issuecomment-1437825293
cc @lightning-L
with this pr, we can know the current max_rows specified by customers, and notify them to make change.
and set up the server side limitation (#4388 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei closed pull request #4389: [KYUUBI #3951][FOLLOWUP] Audit the rest request params
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei closed pull request #4389: [KYUUBI #3951][FOLLOWUP] Audit the rest request params
URL: https://github.com/apache/kyuubi/pull/4389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org