You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Ian Boston (JIRA)" <ji...@apache.org> on 2013/02/25 06:58:12 UTC

[jira] [Created] (SLING-2749) Inconsistent synchronization in org.apache.sling.event.impl.jobs.jcr.LockManager surrounding backgroundSession and backgroundLock

Ian Boston created SLING-2749:
---------------------------------

             Summary: Inconsistent synchronization in org.apache.sling.event.impl.jobs.jcr.LockManager surrounding backgroundSession and backgroundLock
                 Key: SLING-2749
                 URL: https://issues.apache.org/jira/browse/SLING-2749
             Project: Sling
          Issue Type: Bug
          Components: Extensions
    Affects Versions: Extensions Event 3.1.4
            Reporter: Ian Boston
            Assignee: Ian Boston
             Fix For: Extensions Event 3.1.6


There are 2 areas of inconsistent synchronisation. First not all writes to to backgroundSession are synchronized and in the activate method, synchronization is on the private field background session which is created new moments before, making the synchronization ineffective.

I think the intention was to use backgroundLock throughout.

In addition the deactivate method has the potential to generate NPEs if more than one thread deactivates concurrently.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira