You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/22 23:10:44 UTC

[GitHub] [airflow] blag commented on a diff in pull request #25799: Add Airflow specific warning classes

blag commented on code in PR #25799:
URL: https://github.com/apache/airflow/pull/25799#discussion_r951991494


##########
airflow/exceptions.py:
##########
@@ -338,3 +338,17 @@ class TaskDeferralError(AirflowException):
 
 class PodReconciliationError(AirflowException):
     """Raised when an error is encountered while trying to merge pod configs."""
+
+
+class RemoveInAirflow3DeprecationWarning(DeprecationWarning):

Review Comment:
   ```suggestion
   class RemovedInAirflow3DeprecationWarning(DeprecationWarning):
   ```
   
   Nitpick: Make this a past-tense description of the warning, instead of a command. This makes it consistent with its docstring and other exceptions in `airflow.exception`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org