You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/09 02:53:46 UTC

[GitHub] [pulsar] jeffgrunewald commented on issue #6680: [Issue 5979][pulsar-websocket] Add cumulative acknowledgement to websocket consumer

jeffgrunewald commented on issue #6680: [Issue 5979][pulsar-websocket] Add cumulative acknowledgement to websocket consumer
URL: https://github.com/apache/pulsar/pull/6680#issuecomment-611299281
 
 
   > I have a question about `pendingMessages`.
   > 
   > In pulsar-websocket, manage received but not-acked message by `pendingMessages`.
   > ex:
   > 
   > https://github.com/apache/pulsar/blob/a463d2a639cc8424970f3a663b70af45b84785f9/pulsar-websocket/src/main/java/org/apache/pulsar/websocket/ConsumerHandler.java#L244-L250
   > 
   > It seems that changes not support `pendingMessages`(currently, simply decrement). Is my understanding correct?
   
   That seems correct and my apologies. I've pushed a new change that I hope should address this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services