You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/12 10:09:50 UTC
[GitHub] [doris] luozenglin opened a new pull request, #15874: [fix](brokerload) fix be core dump casued by broker load
luozenglin opened a new pull request, #15874:
URL: https://github.com/apache/doris/pull/15874
# Proposed changes
Issue Number: close 15846
## Problem summary
The BrokerFileReader is refactored in #15622, but the _client is not initialized
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yangzhg merged pull request #15874: [fix](brokerload) fix be core dump casued by broker load
Posted by GitBox <gi...@apache.org>.
yangzhg merged PR #15874:
URL: https://github.com/apache/doris/pull/15874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15874: [fix](brokerload) fix be core dump casued by broker load
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15874:
URL: https://github.com/apache/doris/pull/15874#issuecomment-1383390279
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15874: [fix](brokerload) fix be core dump casued by broker load
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15874:
URL: https://github.com/apache/doris/pull/15874#issuecomment-1381284704
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15874: [fix](brokerload) fix be core dump casued by broker load
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15874:
URL: https://github.com/apache/doris/pull/15874#issuecomment-1383950139
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15874: [fix](brokerload) fix be core dump casued by broker load
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15874:
URL: https://github.com/apache/doris/pull/15874#issuecomment-1380151721
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15874: [fix](brokerload) fix be core dump casued by broker load
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15874:
URL: https://github.com/apache/doris/pull/15874#issuecomment-1380099710
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luozenglin commented on pull request #15874: [fix](brokerload) fix be core dump casued by broker load
Posted by GitBox <gi...@apache.org>.
luozenglin commented on PR #15874:
URL: https://github.com/apache/doris/pull/15874#issuecomment-1381239614
> why not call ·`_fs->get_client` in BrokerFileReader Contructor ?
The BrokerFileReader may be constructed before connect(), when the client is not yet constructed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15874: [fix](brokerload) fix be core dump casued by broker load
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15874:
URL: https://github.com/apache/doris/pull/15874#issuecomment-1380471335
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.3 seconds
load time: 493 seconds
storage size: 17123128975 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230112144550_clickbench_pr_78863.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15874: [fix](brokerload) fix be core dump casued by broker load
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15874:
URL: https://github.com/apache/doris/pull/15874#issuecomment-1380151781
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring commented on pull request #15874: [fix](brokerload) fix be core dump casued by broker load
Posted by GitBox <gi...@apache.org>.
dataroaring commented on PR #15874:
URL: https://github.com/apache/doris/pull/15874#issuecomment-1380151176
We should add regression test for broker load.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15874: [fix](brokerload) fix be core dump casued by broker load
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15874:
URL: https://github.com/apache/doris/pull/15874#issuecomment-1383552768
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15874: [fix](brokerload) fix be core dump casued by broker load
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15874:
URL: https://github.com/apache/doris/pull/15874#issuecomment-1384331597
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luozenglin commented on pull request #15874: [fix](brokerload) fix be core dump casued by broker load
Posted by GitBox <gi...@apache.org>.
luozenglin commented on PR #15874:
URL: https://github.com/apache/doris/pull/15874#issuecomment-1385274519
> > why not call ·`_fs->get_client` in BrokerFileReader Contructor ?
>
> The BrokerFileReader may be constructed before connect(), when the client is not yet constructed.
Sorry, I made a mistake in my reply above. There is no problem getting the client in the constructor and the logic is much clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org