You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by xoiss <gi...@git.apache.org> on 2017/09/05 12:51:07 UTC

[GitHub] zookeeper pull request #360: branch-3.4 -- bugfix -- ZOOKEEPER-2891

GitHub user xoiss opened a pull request:

    https://github.com/apache/zookeeper/pull/360

    branch-3.4 -- bugfix -- ZOOKEEPER-2891

    Fixes https://issues.apache.org/jira/browse/ZOOKEEPER-2891

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xoiss/zookeeper branch-3.4-bugfix-zookeeper-2891

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/360.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #360
    
----
commit 2dc3664e52a0f1ae82c5c4fdc800921548bfc087
Author: xoiss <xo...@ubuntu>
Date:   2017-09-05T11:28:36Z

    ZOOKEEPER-2890 - fix freing by uninitialized address.

commit b6da551a38bcfe834038c44f94da0bbfb2c881a5
Author: xoiss <xo...@ubuntu>
Date:   2017-09-05T12:48:33Z

    ZOOKEEPER-2891 - fix endless loop and assertion on fake multi response.

----


---

[GitHub] zookeeper issue #360: branch-3.4 -- bugfix -- ZOOKEEPER-2891

Posted by phunt <gi...@git.apache.org>.
Github user phunt commented on the issue:

    https://github.com/apache/zookeeper/pull/360
  
    ps. You accidentally included the patch for 2890 in this PR, perhaps you can fix that at the same time? Thx.


---

[GitHub] zookeeper issue #360: branch-3.4 -- bugfix -- ZOOKEEPER-2891

Posted by phunt <gi...@git.apache.org>.
Github user phunt commented on the issue:

    https://github.com/apache/zookeeper/pull/360
  
    Hi @xoiss please update this PR to follow the guidelines in "generate a pull request" here: https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute - in particular wrt the summary and description text which really helps folks identifying which PRs to prioritize. Thanks!


---

[GitHub] zookeeper issue #360: branch-3.4 -- bugfix -- ZOOKEEPER-2891

Posted by phunt <gi...@git.apache.org>.
Github user phunt commented on the issue:

    https://github.com/apache/zookeeper/pull/360
  
    @xoiss I like this patch but it's missing tests. Can you include the tests from https://issues.apache.org/jira/secure/attachment/12671215/ZOOKEEPER-1636.patch and resubmit?


---