[GitHub] [spark] yhuai commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles

[GitBox <gi...@apache.org>]

yhuai commented on issue #26619: [SPARK-29981][BUILD] Add hive-1.2/2.3 profiles
URL: https://github.com/apache/spark/pull/26619#issuecomment-583802901
 
 
   @dongjoon-hyun i found hive storage api and hive common have the following common class files
   ```
   org/apache/hadoop/hive/common/ValidReadTxnList.class
   org/apache/hadoop/hive/common/ValidTxnList.class
   org/apache/hadoop/hive/common/ValidTxnList$RangeResponse.class
   ```
   For example, https://github.com/apache/hive/blob/rel/storage-release-2.6.0/storage-api/src/java/org/apache/hadoop/hive/common/ValidReadTxnList.java (pulled in by orc 1.5.8) and https://github.com/apache/hive/blob/rel/release-2.3.6/common/src/java/org/apache/hadoop/hive/common/ValidReadTxnList.java (from hive-common 2.3.6) both are in the classpath and they are different. I am worried that users may hit issues due to classloading order. I think it will be safe to still use nohive classifier for orc, which shades storage api.
   
   I think there is no downside of using orc nohive, right? Why not just keep using that. So, we will not need to worry about having class conflicts.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org