You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2014/11/29 13:47:20 UTC

svn commit: r1642423 - /ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementServices.java

Author: jleroux
Date: Sat Nov 29 12:47:19 2014
New Revision: 1642423

URL: http://svn.apache.org/r1642423
Log:
A fix from bill hongs for "ImageManagementServices.createContentAndDataResource() method might uses DataResource.dataResourceName field to store too long names" https://issues.apache.org/jira/browse/OFBIZ-5501

This issue was only on windows, except if you use filenames longer than 100 chars which unlikely (path not included)

Modified:
    ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementServices.java

Modified: ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementServices.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementServices.java?rev=1642423&r1=1642422&r2=1642423&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementServices.java (original)
+++ ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementServices.java Sat Nov 29 12:47:19 2014
@@ -35,6 +35,7 @@ import javax.imageio.ImageIO;
 
 import javolution.util.FastList;
 import javolution.util.FastMap;
+
 import org.jdom.JDOMException;
 import org.ofbiz.base.util.Debug;
 import org.ofbiz.base.util.UtilDateTime;
@@ -160,7 +161,7 @@ public class ImageManagementServices {
             file = checkExistsImage(file);
             if (UtilValidate.isNotEmpty(file)) {
                 imageName = file.getPath();
-                imageName = imageName.substring(imageName.lastIndexOf("/") + 1);
+                imageName = imageName.substring(imageName.lastIndexOf(File.separator) + 1);
             }
             
             if (UtilValidate.isEmpty(imageResize)) {