[GitHub] [arrow-rs] alamb commented on a change in pull request #1054: Preserve Parquet Bitmask (#1037)

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #1054:
URL: https://github.com/apache/arrow-rs/pull/1054#discussion_r773196971



##########
File path: parquet/src/column/reader.rs
##########
@@ -102,36 +101,60 @@ pub fn get_typed_column_reader<T: DataType>(
 }
 
 /// Typed value reader for a particular primitive column.
-pub struct ColumnReaderImpl<T: DataType> {
+pub type ColumnReaderImpl<T> = GenericColumnReader<
+    decoder::ColumnLevelDecoderImpl,
+    decoder::ColumnLevelDecoderImpl,
+    decoder::ColumnValueDecoderImpl<T>,
+>;
+
+#[doc(hidden)]
+pub struct GenericColumnReader<R, D, V> {

Review comment:
       It would help me to document somewhere what `R`, `D` and `V` are intended for (to make reading this code easier)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org