[GitHub] [hudi] dongkelun commented on a change in pull request #3700: [HUDI-2471] Add support ignoring case when column name matches in merge into

[GitBox <gi...@apache.org>]

dongkelun commented on a change in pull request #3700:
URL: https://github.com/apache/hudi/pull/3700#discussion_r735231887



##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala
##########
@@ -163,15 +163,15 @@ case class HoodieResolveReferences(sparkSession: SparkSession) extends Rule[Logi
           // assignments is empty means insert * or update set *
           val resolvedSourceOutputWithoutMetaFields = resolvedSource.output.filter(attr => !HoodieSqlUtils.isMetaField(attr.name))
           val targetOutputWithoutMetaFields = target.output.filter(attr => !HoodieSqlUtils.isMetaField(attr.name))
-          val resolvedSourceColumnNamesWithoutMetaFields = resolvedSourceOutputWithoutMetaFields.map(_.name)
-          val targetColumnNamesWithoutMetaFields = targetOutputWithoutMetaFields.map(_.name)
+          val resolvedSourceColumnNamesWithoutMetaFields = resolvedSourceOutputWithoutMetaFields.map(_.name.toLowerCase)

Review comment:
       @YannByron  yes,it can work in column name matching.Do I need to add a test case for upper case column name definition? 
   However, ignoring case matching has not been implemented in condition and action. I think we should support it. Do I submit another PR or support it in this PR?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org