You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/03/13 02:13:45 UTC
Review Request 70201: Added a method to check
`ResourceLimits::contains(ResourceQuantities)`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70201/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Also added tests.
Diffs
-----
src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae
src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7
src/tests/resource_quantities_tests.cpp 435a4949b95e9a83be73781388eb4be9c7da695b
Diff: https://reviews.apache.org/r/70201/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 70201: Added a method to check
`ResourceLimits::contains(ResourceQuantities)`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70201/#review213739
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70061', '70148', '70062', '70069', '70063', '70149', '70150', '70151', '70152', '70201']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2967/mesos-review-70201
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2967/mesos-review-70201/logs/mesos-tests.log):
```
I0315 00:56:49.175040 11792 master.cpp:1295] Agent 79319e71-360f-4d87-990a-33ec491107eb-S0 at slave(494)@192.10.1.7:54511 (windows-03.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0315 00:56:49.175040 11792 master.cpp:3330] Disconnecting agent 79319e71-360f-4d87-990a-33ec491107eb-S0 at slave(494)@192.10.1.7:54511 (windows-03.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0315 00:56:49.175040 11792 master.cpp:3349] Deactivating agent 79319e71-360f-4d87-990a-33ec491107eb-S0 at slave(494)@192.10.1.7:54511 (windows-03.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0315 00:56:49.176046 17280 hierarchical.cpp:391] Removed framework 79319e71-360f-4d87-990a-33ec491107eb-0000
I0315 00:56:49.176046 17280 hierarchical.cpp:828] Agent 79319e71-360f-4d87-990a-33ec491107eb-S0 deactivated
I0315 00:56:49.176046 14548 containerizer.cpp:2576] Destroying container 928b47a7-dc89-4fac-948b-411a06aed997 in RUNNING state
I0315 00:56:49.176046 14548 containerizer.cpp:3278] Transitioning the state of container 928b47a7-dc89-4fac-948b-411a06aed997 from RUNNING to DESTROYING
I0315 00:56:49.177052 14548 launcher.cpp:161] Asked to destroy container 928b47a7-dc89-4fac-948b-411a06aed997
W0315 00:56:49.178294 17864 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=6792 to peer '192.10.1.7:56888': IO failed with error code: The specified network name is no longer available.
W0315 00:56:49.179039 17864 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=5396 to peer '192.10.1.7:56889': IO failed with error code: The specified network name is no longer available.
I0315 00:56:49.260226 216 containerizer.cpp:3117] Container 928b[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (685 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (703 ms total)
[----------] Global test environment tear-down
[==========] 1122 tests from 107 test cases ran. (547176 ms total)
[ PASSED ] 1120 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchBlob
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName
2 FAILED TESTS
YOU HAVE 232 DISABLED TESTS
47a7-dc89-4fac-948b-411a06aed997 has exited
I0315 00:56:49.290216 17856 master.cpp:1135] Master terminating
I0315 00:56:49.292227 14508 hierarchical.cpp:679] Removed agent 79319e71-360f-4d87-990a-33ec491107eb-S0
I0315 00:56:49.621239 17864 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 12, 2019, 7:13 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70201/
> -----------------------------------------------------------
>
> (Updated March 12, 2019, 7:13 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also added tests.
>
>
> Diffs
> -----
>
> src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae
> src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7
> src/tests/resource_quantities_tests.cpp 435a4949b95e9a83be73781388eb4be9c7da695b
>
>
> Diff: https://reviews.apache.org/r/70201/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70201: Added a method to check
`ResourceLimits::contains(ResourceQuantities)`.
Posted by Meng Zhu <mz...@mesosphere.io>.
> On March 13, 2019, 12:37 p.m., Benjamin Mahler wrote:
> > src/common/resource_quantities.cpp
> > Lines 406-418 (patched)
> > <https://reviews.apache.org/r/70201/diff/1/?file=2131685#file2131685line406>
> >
> > This is very clean and readable! I guess we're ok with the re-scanning approach instead of walking both alphabetically for now?
> >
> > (I think it's fine, we can consider optimizing it later if needed)
Yep, agreed.
> On March 13, 2019, 12:37 p.m., Benjamin Mahler wrote:
> > src/common/resource_quantities.cpp
> > Lines 408-409 (patched)
> > <https://reviews.apache.org/r/70201/diff/1/?file=2131685#file2131685line408>
> >
> > How about s/quantityScalar/quantity/ ?
> >
> > Also fits cleanly on one line that way:
> >
> > ```
> > >>> len(' foreachpair (const string& name, const Value::Scalar& quantity, quantities) {')
> > 78
> > ```
Sounds good.
- Meng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70201/#review213682
-----------------------------------------------------------
On March 12, 2019, 7:13 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70201/
> -----------------------------------------------------------
>
> (Updated March 12, 2019, 7:13 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also added tests.
>
>
> Diffs
> -----
>
> src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae
> src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7
> src/tests/resource_quantities_tests.cpp 435a4949b95e9a83be73781388eb4be9c7da695b
>
>
> Diff: https://reviews.apache.org/r/70201/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70201: Added a method to check
`ResourceLimits::contains(ResourceQuantities)`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70201/#review213682
-----------------------------------------------------------
Ship it!
src/common/resource_quantities.cpp
Lines 406-418 (patched)
<https://reviews.apache.org/r/70201/#comment299682>
This is very clean and readable! I guess we're ok with the re-scanning approach instead of walking both alphabetically for now?
(I think it's fine, we can consider optimizing it later if needed)
src/common/resource_quantities.cpp
Lines 408-409 (patched)
<https://reviews.apache.org/r/70201/#comment299681>
How about s/quantityScalar/quantity/ ?
Also fits cleanly on one line that way:
```
>>> len(' foreachpair (const string& name, const Value::Scalar& quantity, quantities) {')
78
```
src/tests/resource_quantities_tests.cpp
Lines 434-473 (patched)
<https://reviews.apache.org/r/70201/#comment299683>
This was easy to read, thanks!
- Benjamin Mahler
On March 13, 2019, 2:13 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70201/
> -----------------------------------------------------------
>
> (Updated March 13, 2019, 2:13 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also added tests.
>
>
> Diffs
> -----
>
> src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae
> src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7
> src/tests/resource_quantities_tests.cpp 435a4949b95e9a83be73781388eb4be9c7da695b
>
>
> Diff: https://reviews.apache.org/r/70201/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70201: Added a method to check
`ResourceLimits::contains(ResourceQuantities)`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70201/#review213699
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70061', '70062', '70069', '70063', '70148', '70149', '70150', '70151', '70152', '70201']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2947/mesos-review-70201
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2947/mesos-review-70201/logs/mesos-tests.log):
```
I0313 23:16:16.362215 6332 master.cpp:11596] Removing task 0ea3b1ed-35e0-4293-961a-30d0ab5ad9fc with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 7ee2d1a3-1972-408f-aeac-0d08b0404979-0000 on agent 7ee2d1a3-1972-408f-aeac-0d08b0404979-S0 at slave(494)@192.10.1.4:49939 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0313 23:16:16.365253 6332 master.cpp:1295] Agent 7ee2d1a3-1972-408f-aeac-0d08b0404979-S0 at slave(494)@192.10.1.4:49939 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0313 23:16:16.365253 6332 master.cpp:3330] Disconnecting agent 7ee2d1a3-1972-408f-aeac-0d08b0404979-S0 at slave(494)@192.10.1.4:49939 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0313 23:16:16.365253 6332 master.cpp:3349] Deactivating agent 7ee2d1a3-1972-408f-aeac-0d08b0404979-S0 at slave(494)@192.10.1.4:49939 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0313 23:16:16.366219 10364 hierarchical.cpp:391] Removed framework 7ee2d1a3-1972-408f-aeac-0d08b0404979-0000
I0313 23:16:16.366219 10364 hierarchical.cpp:828] Agent 7ee2d1a3-1972-408f-aeac-0d08b0404979-S0 deactivated
I0313 23:16:16.366219 7156 containerizer.cpp:2576] Destroying container 9efd9e6f-c104-48b6-8eca-4bb5fb80c00a in RUNNING state
I0313 23:16:16.366219 7156 containerizer.cpp:3278] Transitioning the state of container 9efd9e6f-c104-48b6-8eca-4bb5fb80c00a from RUNNING to DESTROYING
I0313 23:16:16.367223 7156 launcher.cpp:161] Asked to destroy container 9efd9e6f-c104-48b6-8eca-4bb5fb80c00a
W0313 23:16:16.368203 10476 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=492[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (691 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (710 ms total)
[----------] Global test environment tear-down
[==========] 1122 tests from 107 test cases ran. (534305 ms total)
[ PASSED ] 1121 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchBlob
1 FAILED TEST
YOU HAVE 232 DISABLED TESTS
4 to peer '192.10.1.4:52280': IO failed with error code: The specified network name is no longer available.
W0313 23:16:16.369210 10476 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=4688 to peer '192.10.1.4:52281': IO failed with error code: The specified network name is no longer available.
I0313 23:16:16.440227 6332 containerizer.cpp:3117] Container 9efd9e6f-c104-48b6-8eca-4bb5fb80c00a has exited
I0313 23:16:16.469226 9224 master.cpp:1135] Master terminating
I0313 23:16:16.471221 12100 hierarchical.cpp:679] Removed agent 7ee2d1a3-1972-408f-aeac-0d08b0404979-S0
I0313 23:16:16.801226 10476 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 13, 2019, 2:13 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70201/
> -----------------------------------------------------------
>
> (Updated March 13, 2019, 2:13 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also added tests.
>
>
> Diffs
> -----
>
> src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae
> src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7
> src/tests/resource_quantities_tests.cpp 435a4949b95e9a83be73781388eb4be9c7da695b
>
>
> Diff: https://reviews.apache.org/r/70201/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70201: Added a method to check
`ResourceLimits::contains(ResourceQuantities)`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70201/#review213665
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70061, 70062, 70069, 70063, 70148, 70149, 70150, 70151, 70152, 70201]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 12, 2019, 7:13 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70201/
> -----------------------------------------------------------
>
> (Updated March 12, 2019, 7:13 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also added tests.
>
>
> Diffs
> -----
>
> src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae
> src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7
> src/tests/resource_quantities_tests.cpp 435a4949b95e9a83be73781388eb4be9c7da695b
>
>
> Diff: https://reviews.apache.org/r/70201/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>