You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by davidhaller <gi...@git.apache.org> on 2017/01/20 20:29:26 UTC

[GitHub] drill pull request #724: JDBC proxy driver: Do not put null value in map

GitHub user davidhaller opened a pull request:

    https://github.com/apache/drill/pull/724

    JDBC proxy driver: Do not put null value in map

    Hello everyone,
    
    proxyReturnClass is always null, so interfacesToProxyClassesMap will contain null values only. Adding newProxyReturnClass should be correct.
    
    This bug does not affect functionality, but probably decreases performance because you get "cache misses" all the time.
    
    Best regards,
    David.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davidhaller/drill master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/724.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #724
    
----
commit ec440bcc51e71b7fde41b7fd3339ffc79fe993f8
Author: David Haller <da...@mailbox.org>
Date:   2017-01-20T20:22:52Z

    Do not put null value in map

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill issue #724: DRILL-5241: JDBC proxy driver: Do not put null value in ma...

Posted by davidhaller <gi...@git.apache.org>.

Github user davidhaller commented on the issue:

    https://github.com/apache/drill/pull/724
  
    JIRA issue created at https://issues.apache.org/jira/browse/DRILL-5241


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #724: DRILL-5241: JDBC proxy driver: Do not put null valu...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/724


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill issue #724: JDBC proxy driver: Do not put null value in map

Posted by paul-rogers <gi...@git.apache.org>.

Github user paul-rogers commented on the issue:

    https://github.com/apache/drill/pull/724
  
    Hi David,
    
    Thanks much for the fix! Is there a JIRA entry for this fix? If not, please go ahead and create one. Then, rename the PR to:
    ```
    DRILL-xxxx: DBC proxy driver: Do not put null value in map
    ```
    
    That name format is needed by our committers to trace each PR back to the JIRA entry that describes it.
    
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---