[GitHub] [incubator-superset] willbarrett commented on a change in pull request #9517: [Build] Add Github workflows

[GitBox <gi...@apache.org>]

willbarrett commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407655048
 
 

 ##########
 File path: .github/workflows/superset-e2e.yml
 ##########
 @@ -0,0 +1,66 @@
+name: E2E
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+
+jobs:
+  cypress:
+    name: Cypress
+    runs-on: ubuntu-18.04
+    strategy:
+      fail-fast: false
+      matrix:
+        browser: ['chrome']
+    env:
+      SUPERSET_CONFIG: tests.superset_test_config
+      PYTHONPATH: ${{ github.workspace }}
+      REDIS_PORT: 16379
+      CI: github-actions
+      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
+    services:
 
 Review comment:
   We are going to remove it entirely. For now, yes, we should run unit tests in SQLite as the work to deprecate hasn't been started.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org