You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "PickBas (via GitHub)" <gi...@apache.org> on 2023/10/12 16:09:58 UTC
[PR] [ISSUE #8810] replaced .size() > 0 with isEmpty() [iceberg]
PickBas opened a new pull request, #8813:
URL: https://github.com/apache/iceberg/pull/8813
fixes #8810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] [ISSUE #8810] replaced .size() > 0 with isEmpty() [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #8813:
URL: https://github.com/apache/iceberg/pull/8813#issuecomment-1759955441
Thanks for opening this PR @PickBas. There are a couple more in the codebase. What do you think of doing a PR per module? So we keep it manageable. In this case everything in `core/*`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] [ISSUE #8810] replaced .size() > 0 with isEmpty() [iceberg]
Posted by "PickBas (via GitHub)" <gi...@apache.org>.
PickBas commented on PR #8813:
URL: https://github.com/apache/iceberg/pull/8813#issuecomment-1759958867
@Fokko Sure, will be done. PR per module works for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Replace `.size() > 0` with `!.isEmpty()` [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar merged PR #8813:
URL: https://github.com/apache/iceberg/pull/8813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org