You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zivali (via GitHub)" <gi...@apache.org> on 2023/11/05 14:32:55 UTC
[PR] [#1094] docs: split client_guide.md [incubator-uniffle]
zivali opened a new pull request, #1299:
URL: https://github.com/apache/incubator-uniffle/pull/1299
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
- Modify client_guide.md to include only shared configurations
- Add three subpages to it for 3 different clients: spark, mapreduce, and tez
### Why are the changes needed?
Fix: #1094
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Modifying documentation only.
### Additional Notes
- Netty configs are found in [common/src/main/java/org/apache/uniffle/common/config/RssClientConf.java](https://github.com/apache/incubator-uniffle/blob/master/common/src/main/java/org/apache/uniffle/common/config/RssClientConf.java). I presume they are shared configurations.
- Remote Spill is available in Tez as well. Reference [commit](https://github.com/apache/incubator-uniffle/commit/4f56e59ea886f4504358f9a24a85575e23b049f2) / [RssTezConfig.java](https://github.com/apache/incubator-uniffle/blob/master/client-tez/src/main/java/org/apache/tez/common/RssTezConfig.java)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1094] docs: split client_guide.md [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #1299:
URL: https://github.com/apache/incubator-uniffle/pull/1299#discussion_r1382711122
##########
docs/client_guide/client_guide.md:
##########
@@ -21,105 +21,21 @@ license: |
---
# Uniffle Shuffle Client Guide
-Uniffle is designed as a unified shuffle engine for multiple computing frameworks, including Apache Spark and Apache Hadoop.
-Uniffle has provided pluggable client plugins to enable remote shuffle in Spark and MapReduce.
+Uniffle is designed as a unified shuffle engine for multiple computing frameworks, including Apache Spark, Apache Hadoop, and Apache Tez.
+Uniffle has provided pluggable client plugins to enable remote shuffle in Spark, MapReduce, and Tez.
Review Comment:
`MapReduce, ` -> `MapReduce`?
##########
docs/client_guide/client_guide.md:
##########
@@ -21,105 +21,21 @@ license: |
---
# Uniffle Shuffle Client Guide
-Uniffle is designed as a unified shuffle engine for multiple computing frameworks, including Apache Spark and Apache Hadoop.
-Uniffle has provided pluggable client plugins to enable remote shuffle in Spark and MapReduce.
+Uniffle is designed as a unified shuffle engine for multiple computing frameworks, including Apache Spark, Apache Hadoop, and Apache Tez.
Review Comment:
`Apache Hadoop, ` -> `Apache Hadoop`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1094] docs: split client_guide.md [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #1299:
URL: https://github.com/apache/incubator-uniffle/pull/1299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org