You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/28 15:54:00 UTC
[jira] [Commented] (ZOOKEEPER-2415) SessionTest is using Thread
deprecated API.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417596#comment-16417596 ]
ASF GitHub Bot commented on ZOOKEEPER-2415:
-------------------------------------------
GitHub user anmolnar opened a pull request:
https://github.com/apache/zookeeper/pull/497
ZOOKEEPER-2415. SessionTest is using Thread deprecated API
Refactored `SessionTest` class.
`testSessionTimeout()` has been extracted to a separate class and split into multiple tests to validate the different scenarios in a more readable way.
Removed deprecated Thread API `suspend()` and reduced the server ticktime and session timeout for better performance.
Hopefully this will help on test's flakyness too.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-2415
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/497.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #497
----
commit 64d5af67c4eeb34b6a06c057b5ecf0cdeb4b11df
Author: Andor Molnar <an...@...>
Date: 2018-03-28T15:50:15Z
ZOOKEEPER-2415. Refactor testSessionTimeout() to live in separate class and not to use deprecated API. Also improved performance.
----
> SessionTest is using Thread deprecated API.
> -------------------------------------------
>
> Key: ZOOKEEPER-2415
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2415
> Project: ZooKeeper
> Issue Type: Test
> Components: tests
> Affects Versions: 3.4.8, 3.5.1, 3.6.0
> Reporter: Flavio Junqueira
> Assignee: Andor Molnar
> Priority: Major
>
> The test class is using calls such as {{Thread.suspend}} and {{Thread.resume}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)