You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Przemo Pakulski (JIRA)" <ji...@apache.org> on 2007/09/04 17:52:46 UTC
[jira] Created: (JCR-1111) Accesss to version history results in
reading all versions of versionable node
Accesss to version history results in reading all versions of versionable node
------------------------------------------------------------------------------
Key: JCR-1111
URL: https://issues.apache.org/jira/browse/JCR-1111
Project: Jackrabbit
Issue Type: Improvement
Components: versioning
Affects Versions: 1.4
Reporter: Przemo Pakulski
InternalVersionHistoryImpl loads all versions at once during initialization. Because of that all versioning operations (incl. checkin, label, restore) are significantly slower when node has many versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1111) Accesss to version history results in
reading all versions of versionable node
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1111:
-------------------------------
Component/s: jackrabbit-core
Affects Version/s: (was: 1.4)
> Accesss to version history results in reading all versions of versionable node
> ------------------------------------------------------------------------------
>
> Key: JCR-1111
> URL: https://issues.apache.org/jira/browse/JCR-1111
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, versioning
> Reporter: Przemo Pakulski
> Fix For: 1.4
>
> Attachments: JCR-1111.patch
>
>
> InternalVersionHistoryImpl loads all versions at once during initialization. Because of that all versioning operations (incl. checkin, label, restore) are significantly slower when node has many versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1111) Accesss to version history results in
reading all versions of versionable node
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541019 ]
Stefan Guggisberg commented on JCR-1111:
----------------------------------------
przemo, i appreciate that you provided a patch with the suggested changes to give other committers a chance to review them. however, there's no point in doing so if you apply the patch 14 minutes later anyway... if you'd like to get feedback on the suggested changes you should wait at least a couple of days before committing the patch ;-)
thanks
stefan
> Accesss to version history results in reading all versions of versionable node
> ------------------------------------------------------------------------------
>
> Key: JCR-1111
> URL: https://issues.apache.org/jira/browse/JCR-1111
> Project: Jackrabbit
> Issue Type: Improvement
> Components: versioning
> Affects Versions: 1.4
> Reporter: Przemo Pakulski
> Fix For: 1.4
>
> Attachments: JCR-1111.patch
>
>
> InternalVersionHistoryImpl loads all versions at once during initialization. Because of that all versioning operations (incl. checkin, label, restore) are significantly slower when node has many versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1111) Accesss to version history results in
reading all versions of versionable node
Posted by "Przemo Pakulski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Przemo Pakulski updated JCR-1111:
---------------------------------
Attachment: JCR-1111.patch
Patch attached. Only root version instance is created during intitiaization of InternalVersionHistoryImpl. Other versions are lazy loaded.
It has big impact on performance of versioning operations and reduces significantly memory allocations when importing/cloning big trees of versionable nodes.
> Accesss to version history results in reading all versions of versionable node
> ------------------------------------------------------------------------------
>
> Key: JCR-1111
> URL: https://issues.apache.org/jira/browse/JCR-1111
> Project: Jackrabbit
> Issue Type: Improvement
> Components: versioning
> Affects Versions: 1.4
> Reporter: Przemo Pakulski
> Attachments: JCR-1111.patch
>
>
> InternalVersionHistoryImpl loads all versions at once during initialization. Because of that all versioning operations (incl. checkin, label, restore) are significantly slower when node has many versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1111) Accesss to version history results in
reading all versions of versionable node
Posted by "Przemo Pakulski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541025 ]
Przemo Pakulski commented on JCR-1111:
--------------------------------------
Well, you are right, I didn't give any chance to review it by anyone :-(.
I can say that all test passes and I was working with this fix for some time.
> Accesss to version history results in reading all versions of versionable node
> ------------------------------------------------------------------------------
>
> Key: JCR-1111
> URL: https://issues.apache.org/jira/browse/JCR-1111
> Project: Jackrabbit
> Issue Type: Improvement
> Components: versioning
> Affects Versions: 1.4
> Reporter: Przemo Pakulski
> Fix For: 1.4
>
> Attachments: JCR-1111.patch
>
>
> InternalVersionHistoryImpl loads all versions at once during initialization. Because of that all versioning operations (incl. checkin, label, restore) are significantly slower when node has many versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1111) Accesss to version history results in
reading all versions of versionable node
Posted by "Przemo Pakulski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524767 ]
Przemo Pakulski commented on JCR-1111:
--------------------------------------
I'm working on patch to load versions when it is needed only.
> Accesss to version history results in reading all versions of versionable node
> ------------------------------------------------------------------------------
>
> Key: JCR-1111
> URL: https://issues.apache.org/jira/browse/JCR-1111
> Project: Jackrabbit
> Issue Type: Improvement
> Components: versioning
> Affects Versions: 1.4
> Reporter: Przemo Pakulski
>
> InternalVersionHistoryImpl loads all versions at once during initialization. Because of that all versioning operations (incl. checkin, label, restore) are significantly slower when node has many versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1111) Accesss to version history results in
reading all versions of versionable node
Posted by "Przemo Pakulski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Przemo Pakulski resolved JCR-1111.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.4
patch applied in rev. 592947
> Accesss to version history results in reading all versions of versionable node
> ------------------------------------------------------------------------------
>
> Key: JCR-1111
> URL: https://issues.apache.org/jira/browse/JCR-1111
> Project: Jackrabbit
> Issue Type: Improvement
> Components: versioning
> Affects Versions: 1.4
> Reporter: Przemo Pakulski
> Fix For: 1.4
>
> Attachments: JCR-1111.patch
>
>
> InternalVersionHistoryImpl loads all versions at once during initialization. Because of that all versioning operations (incl. checkin, label, restore) are significantly slower when node has many versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.