[jira] [Commented] (MAPREDUCE-2944) Improve checking of input for Api displayTasks()

["Harsh J (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176118#comment-13176118 ] 

Harsh J commented on MAPREDUCE-2944:
------------------------------------

Hey Xie,

Good catch. Patch is OK, but I have a few nitpicky comments:

- Use a set of types and states instead? Would appear much cleaner :)
- The exception message can also carry something like "Valid types are: X,Y,Z". This'd be immensely helpful to the developer doing it wrong (Its already covered by javadocs though).
                
> Improve checking of input for Api displayTasks() 
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2944
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2944
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.24.0
>            Reporter: XieXianshan
>            Assignee: XieXianshan
>            Priority: Trivial
>             Fix For: 0.24.0
>
>         Attachments: MAPREDUCE-2944.patch
>
>
> The JobClient.displayTasks() will do nothing and won't throw any exception either, 
> while user call it with invalid type/state of task.
> To be more friendly,it's better to remain user to check his parameters with an exception. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira