You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "universalmind303 (via GitHub)" <gi...@apache.org> on 2023/09/09 22:35:13 UTC
[GitHub] [arrow-datafusion] universalmind303 opened a new issue, #7516: Move `FileCompressionType` out of `common` and into `core`
universalmind303 opened a new issue, #7516:
URL: https://github.com/apache/arrow-datafusion/issues/7516
### Is your feature request related to a problem or challenge?
`FileCompressionType` appears to be the only item in `common` that uses several heavy dependencies in the `common` crate such as `tokio`. As result causes it to be a dependency of all crates using `common`, such as `expr`. Other than for `FileCompressionType` there is no usage of async in any crate except `core` _(tests excluded)_
By moving `FileCompressionType`, or the associated `convert_X` functions to `core`, we'd remove several heavy dependencies from all crates except core
### Describe the solution you'd like
A quick look over the codebase, it seems that `FileCompressionType` is only used in `core`. So it seems natural that it could easily be moved in to `core`.
### Describe alternatives you've considered
- Make all async dependencies optional & control them via feature flags.
- Keep FileCompressionType in `common`, but move the `convert_X` functions in to `core`.
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed issue #7516: Move `FileCompressionType` out of `common` and into `core`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #7516: Move `FileCompressionType` out of `common` and into `core`
URL: https://github.com/apache/arrow-datafusion/issues/7516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] haohuaijin commented on issue #7516: Move `FileCompressionType` out of `common` and into `core`
Posted by "haohuaijin (via GitHub)" <gi...@apache.org>.
haohuaijin commented on issue #7516:
URL: https://github.com/apache/arrow-datafusion/issues/7516#issuecomment-1723295603
I want to work on this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #7516: Move `FileCompressionType` out of `common` and into `core`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #7516:
URL: https://github.com/apache/arrow-datafusion/issues/7516#issuecomment-1722213940
I agree -- thank you @universalmind303 -- marking this as a good first issue as it is primarily a code motion exercise and does not require deep datafusion internals knowledge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org