You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "lifulong (via GitHub)" <gi...@apache.org> on 2024/04/24 04:47:44 UTC

[PR] [CELEBORN-1399] MR job CelebornMapOutputCollector should checkExcepti… [celeborn]

lifulong opened a new pull request, #2477:
URL: https://github.com/apache/celeborn/pull/2477

   …on after flush
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   check exception and throw it if exist after CelebornMapOutputCollector flush
   
   ### Why are the changes needed?
   
   For small shuffle mr job, shuffle push maybe only happend one time when map task finished deal all task records and do flush before close  MapOutputCollector
   In this case, CelebornMapOutputCollector should checkException after flush, and throw exceptions when flush has exception, if not, job status is wrong
   
   ### Does this PR introduce _any_ user-facing change?
   
   no
   
   ### How was this patch tested?
   
   test use mr job


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1399] MR CelebornMapOutputCollector should check exception after flush [celeborn]

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX closed pull request #2477: [CELEBORN-1399] MR CelebornMapOutputCollector should check exception after flush
URL: https://github.com/apache/celeborn/pull/2477


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1399] MR job CelebornMapOutputCollector should checkExcepti… [celeborn]

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #2477:
URL: https://github.com/apache/celeborn/pull/2477#issuecomment-2074069359

   I think you need to check exception in close method as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1399] MR CelebornMapOutputCollector should check exception after flush [celeborn]

Posted by "lifulong (via GitHub)" <gi...@apache.org>.
lifulong commented on PR #2477:
URL: https://github.com/apache/celeborn/pull/2477#issuecomment-2074241524

   > I think you need to check exception in close method as well.
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1399] MR CelebornMapOutputCollector should check exception after flush [celeborn]

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #2477:
URL: https://github.com/apache/celeborn/pull/2477#issuecomment-2074268814

   Merged into main(v0.5.0) and branch-0.4(v0.4.1).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org