You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/09/30 19:22:09 UTC
[GitHub] [hbase] huaxiangsun commented on a change in pull request #2451: HBASE-25055 Add ReplicationSource for meta WALs; add enable/disable w…
huaxiangsun commented on a change in pull request #2451:
URL: https://github.com/apache/hbase/pull/2451#discussion_r497745552
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/ServerRegionReplicaUtil.java
##########
@@ -154,47 +162,60 @@ public static StoreFileInfo getStoreFileInfo(Configuration conf, FileSystem fs,
}
/**
- * Create replication peer for replicating to region replicas if needed.
+ * Create replication peer for replicating user-space Region Read Replicas.
* @param conf configuration to use
- * @throws IOException
*/
public static void setupRegionReplicaReplication(Configuration conf) throws IOException {
- if (!isRegionReplicaReplicationEnabled(conf)) {
+ if (!conf.getBoolean(REGION_REPLICA_REPLICATION_CONF_KEY, DEFAULT_REGION_REPLICA_REPLICATION)) {
return;
}
-
+ String peerId = REGION_REPLICA_REPLICATION_PEER;
try (Connection connection = ConnectionFactory.createConnection(conf);
Admin admin = connection.getAdmin()) {
ReplicationPeerConfig peerConfig = null;
try {
- peerConfig = admin.getReplicationPeerConfig(REGION_REPLICA_REPLICATION_PEER);
+ peerConfig = admin.getReplicationPeerConfig(peerId);
} catch (ReplicationPeerNotFoundException e) {
- LOG.warn(
- "Region replica replication peer id=" + REGION_REPLICA_REPLICATION_PEER + " not exist",
- e);
+ LOG.warn("Region replica peer id={} does not exist", peerId, e);
}
-
if (peerConfig == null) {
- LOG.info("Region replica replication peer id=" + REGION_REPLICA_REPLICATION_PEER
- + " not exist. Creating...");
- peerConfig = new ReplicationPeerConfig();
- peerConfig.setClusterKey(ZKConfig.getZooKeeperClusterKey(conf));
- peerConfig.setReplicationEndpointImpl(RegionReplicaReplicationEndpoint.class.getName());
- admin.addReplicationPeer(REGION_REPLICA_REPLICATION_PEER, peerConfig);
+ LOG.info("Region Read Replica peerId={} does not exist; creating...", peerId);
+ peerConfig = ReplicationPeerConfig.newBuilder().
+ setClusterKey(ZKConfig.getZooKeeperClusterKey(conf)).
+ setReplicationEndpointImpl(RegionReplicaReplicationEndpoint.class.getName()).build();
+ admin.addReplicationPeer(peerId, peerConfig);
}
}
}
- public static boolean isRegionReplicaReplicationEnabled(Configuration conf) {
- return conf.getBoolean(REGION_REPLICA_REPLICATION_CONF_KEY,
- DEFAULT_REGION_REPLICA_REPLICATION);
+ /**
+ * @return True if Region Read Replica is enabled for <code>tn</code>.
+ */
+ public static boolean isRegionReplicaReplicationEnabled(Configuration conf, TableName tn) {
+ return isMetaRegionReplicaReplicationEnabled(conf, tn) ||
+ conf.getBoolean(REGION_REPLICA_REPLICATION_CONF_KEY, DEFAULT_REGION_REPLICA_REPLICATION);
Review comment:
Nit: can we have another utility method of
conf.getBoolean(REGION_REPLICA_REPLICATION_CONF_KEY, DEFAULT_REGION_REPLICA_REPLICATION)
as is isUserRegionReplicaReplicationEnabled(***)?
It will be easy to read.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org