You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/06 09:08:21 UTC
[GitHub] [incubator-seatunnel] s7monk opened a new pull request, #3008: add Rds doc
s7monk opened a new pull request, #3008:
URL: https://github.com/apache/incubator-seatunnel/pull/3008
@https://github.com/apache/incubator-seatunnel/issues/2829
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
Add Rds doc
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [x] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] s7monk closed pull request #3008: [Doc][Connector-V2][Rds] add Rds doc
Posted by GitBox <gi...@apache.org>.
s7monk closed pull request #3008: [Doc][Connector-V2][Rds] add Rds doc
URL: https://github.com/apache/incubator-seatunnel/pull/3008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #3008: [Doc][Connector-V2][Rds] add Rds doc
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #3008:
URL: https://github.com/apache/incubator-seatunnel/pull/3008#issuecomment-1279976296
Hi @s7monk why did you close this pr? I think it's useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #3008: [Doc][Connector-V2][Rds] add Rds doc
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #3008:
URL: https://github.com/apache/incubator-seatunnel/pull/3008#discussion_r989137526
##########
docs/en/connector-v2/source/Rds.md:
##########
@@ -0,0 +1,26 @@
+# Rds
+
+> Rds source connector
+
+## Description
+
+Read RDS MySQL data through [Jdbc connector](Jdbc.md).
+
+## Key features
Review Comment:
same as above.
##########
docs/en/connector-v2/sink/Rds.md:
##########
@@ -0,0 +1,18 @@
+# Rds
+
+> Rds sink connector
+
+## Description
+
+Write data to RDS MySQL using [Jdbc connector](Jdbc.md).
+
+## Key features
Review Comment:
I suggest the connector which is direct use `Jdbc connector` only keep the following:
```
# Rds
> Rds sink connector
## Description
Write data to RDS MySQL using [Jdbc connector](Jdbc.md).
```
@hailin0 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org