You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "lostluck (via GitHub)" <gi...@apache.org> on 2023/02/10 19:03:44 UTC

[GitHub] [beam] lostluck opened a new pull request, #25431: [#25417][go] copy env details to dataflow images

lostluck opened a new pull request, #25431:
URL: https://github.com/apache/beam/pull/25431

   Handle #25417 but in the Go SDK.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #25431: [#25417][go] copy env details to dataflow images

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25431:
URL: https://github.com/apache/beam/pull/25431#issuecomment-1426307398

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck merged pull request #25431: [#25417][go] copy env details to dataflow images

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck merged PR #25431:
URL: https://github.com/apache/beam/pull/25431


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #25431: [#25417][go] copy env details to dataflow images

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #25431:
URL: https://github.com/apache/beam/pull/25431#issuecomment-1426224723

   R: @chamikaramj 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #25431: [#25417][go] copy env details to dataflow images

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #25431:
URL: https://github.com/apache/beam/pull/25431#issuecomment-1426442295

   Go tests are failing since the code-cov action needs to be updated to v3. Those tests are also covered by the precommit, so it's not a blocker.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #25431: [#25417][go] copy env details to dataflow images

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #25431:
URL: https://github.com/apache/beam/pull/25431#issuecomment-1426440407

   Definitely making it to dataflow now:
   
   ```
        "sdkHarnessContainerImages": [
   14:43:16           {
   14:43:16             "capabilities": [
   14:43:16               "beam:protocol:progress_reporting:v1",
   14:43:16               "beam:protocol:multi_core_bundle_processing:v1",
   14:43:16               "beam:transform:sdf_truncate_sized_restrictions:v1",
   14:43:16               "beam:protocol:worker_status:v1",
   14:43:16               "beam:protocol:monitoring_info_short_ids:v1",
   14:43:16               "beam:version:sdk_base:go:apache/beam_go_sdk:2.46.0.dev",
   14:43:16               "beam:coder:bytes:v1",
   14:43:16               "beam:coder:bool:v1",
   14:43:16               "beam:coder:varint:v1",
   14:43:16               "beam:coder:double:v1",
   14:43:16               "beam:coder:string_utf8:v1",
   14:43:16               "beam:coder:length_prefix:v1",
   14:43:16               "beam:coder:kv:v1",
   14:43:16               "beam:coder:iterable:v1",
   14:43:16               "beam:coder:state_backed_iterable:v1",
   14:43:16               "beam:coder:windowed_value:v1",
   14:43:16               "beam:coder:global_window:v1",
   14:43:16               "beam:coder:interval_window:v1",
   14:43:16               "beam:coder:row:v1",
   14:43:16               "beam:coder:nullable:v1"
   14:43:16             ],
   14:43:16             "containerImage": "us.gcr.io/apache-beam-testing/jenkins/beam_go_sdk:20230210-201800",
   14:43:16             "environmentId": "go"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #25431: [#25417][go] copy env details to dataflow images

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #25431:
URL: https://github.com/apache/beam/pull/25431#issuecomment-1426241500

   Run Go PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #25431: [#25417][go] copy env details to dataflow images

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #25431:
URL: https://github.com/apache/beam/pull/25431#issuecomment-1426324561

   # [Codecov](https://codecov.io/gh/apache/beam/pull/25431?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#25431](https://codecov.io/gh/apache/beam/pull/25431?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b309b57) into [master](https://codecov.io/gh/apache/beam/commit/8283e4fc0dd6fd2912aea82a023dab7b39bb139a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8283e4f) will **increase** coverage by `0.00%`.
   > The diff coverage is `76.00%`.
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #25431   +/-   ##
   =======================================
     Coverage   72.93%   72.94%           
   =======================================
     Files         748      748           
     Lines       99366    99383   +17     
   =======================================
   + Hits        72476    72492   +16     
   + Misses      25523    25522    -1     
   - Partials     1367     1369    +2     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | go | `51.87% <76.00%> (+0.02%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/25431?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [sdks/go/pkg/beam/core/runtime/pipelinex/util.go](https://codecov.io/gh/apache/beam/pull/25431?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvcGlwZWxpbmV4L3V0aWwuZ28=) | `77.04% <ø> (+1.24%)` | :arrow_up: |
   | [...ks/go/pkg/beam/runners/dataflow/dataflowlib/job.go](https://codecov.io/gh/apache/beam/pull/25431?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL2RhdGFmbG93L2RhdGFmbG93bGliL2pvYi5nbw==) | `29.30% <76.00%> (+5.38%)` | :arrow_up: |
   | [sdks/go/pkg/beam/core/metrics/dumper.go](https://codecov.io/gh/apache/beam/pull/25431?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL21ldHJpY3MvZHVtcGVyLmdv) | `49.20% <0.00%> (-4.77%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org