[unomi] branch master updated: UNOMI-689: avoid load(null) to crash Exceptions (#577)

[jk...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jkevan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/unomi.git


The following commit(s) were added to refs/heads/master by this push:
     new 1b2695a4e UNOMI-689: avoid load(null) to crash Exceptions (#577)
1b2695a4e is described below

commit 1b2695a4e618d9c74f201c1f2c5beea3c3a3d368
Author: kevan Jahanshahi <jk...@apache.org>
AuthorDate: Fri Feb 10 09:30:57 2023 +0100

    UNOMI-689: avoid load(null) to crash Exceptions (#577)
---
 .../elasticsearch/ElasticSearchPersistenceServiceImpl.java            | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/persistence-elasticsearch/core/src/main/java/org/apache/unomi/persistence/elasticsearch/ElasticSearchPersistenceServiceImpl.java b/persistence-elasticsearch/core/src/main/java/org/apache/unomi/persistence/elasticsearch/ElasticSearchPersistenceServiceImpl.java
index 864548f3e..231329ea0 100644
--- a/persistence-elasticsearch/core/src/main/java/org/apache/unomi/persistence/elasticsearch/ElasticSearchPersistenceServiceImpl.java
+++ b/persistence-elasticsearch/core/src/main/java/org/apache/unomi/persistence/elasticsearch/ElasticSearchPersistenceServiceImpl.java
@@ -805,6 +805,10 @@ public class ElasticSearchPersistenceServiceImpl implements PersistenceService,
     }
 
     private <T extends Item> T load(final String itemId, final Class<T> clazz, final String customItemType) {
+        if (StringUtils.isEmpty(itemId)) {
+            return null;
+        }
+
         return new InClassLoaderExecute<T>(metricsService, this.getClass().getName() + ".loadItem", this.bundleContext, this.fatalIllegalStateErrors, throwExceptions) {
             protected T execute(Object... args) throws Exception {
                 try {