[GitHub] [incubator-age] deem0n commented on a change in pull request #166: pg_dump support

[GitBox <gi...@apache.org>]

deem0n commented on a change in pull request #166:
URL: https://github.com/apache/incubator-age/pull/166#discussion_r782045361



##########
File path: src/backend/utils/cache/ag_cache.c
##########
@@ -633,7 +633,7 @@ static void flush_label_oid_cache(void)
 {
     HASH_SEQ_STATUS hash_seq;
 
-    hash_seq_init(&hash_seq, label_name_graph_cache_hash);
+    hash_seq_init(&hash_seq, label_oid_cache_hash);

Review comment:
       We doing tests with dump & restore of the database with AGE extension and some graph data. After restore we have broken oids in the ag_catalog.* tables. Which can be easily fixed and I will commit the fix procedure later. But even after the oid fix we still have errors in the `flush_label_oid_cache(void)`. I think that using `label_name_graph_cache_hash` is just a typo. At least after my fix we see no errors with broken cache anymore after dump & restore and oid fixes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org