You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/14 21:55:43 UTC
[GitHub] [beam-starter-java] davidcavazos opened a new pull request, #32: Use Java 17 by default
davidcavazos opened a new pull request, #32:
URL: https://github.com/apache/beam-starter-java/pull/32
This PR does the following changes:
* Use Java 17 by default.
* Inline dependency versions instead of using variables, so Dependabot can update them
* Remove `sbt` for pure Java since it's not supported by Dependabot -- dependabot/dependabot-core/issues/352
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] I agree that my contributions are licensed with both [Apache ASL2](../../LICENSE-APACHE) and [MIT](../../LICENSE-MIT).
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [`CONTRIBUTING.md`](../../CONTRIBUTING.md) guide for more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-java] aaltay commented on pull request #32: Use Java 17 by default
Posted by GitBox <gi...@apache.org>.
aaltay commented on PR #32:
URL: https://github.com/apache/beam-starter-java/pull/32#issuecomment-1314773018
Do we want to remove sbt? Dependabot support is not relevant to beam users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-java] aaltay commented on pull request #32: Use Java 17 by default
Posted by GitBox <gi...@apache.org>.
aaltay commented on PR #32:
URL: https://github.com/apache/beam-starter-java/pull/32#issuecomment-1316321287
> I guess we can leave it, but we'll have to manually update the dependencies from time to time.
I think that is fine. We can add a note about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-java] davidcavazos commented on pull request #32: Use Java 17 by default
Posted by GitBox <gi...@apache.org>.
davidcavazos commented on PR #32:
URL: https://github.com/apache/beam-starter-java/pull/32#issuecomment-1315726939
I guess we can leave it, but we'll have to manually update the dependencies from time to time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-java] aaltay merged pull request #32: Use Java 17 by default
Posted by GitBox <gi...@apache.org>.
aaltay merged PR #32:
URL: https://github.com/apache/beam-starter-java/pull/32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org