You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Graham Charters (JIRA)" <ji...@apache.org> on 2010/03/05 15:12:27 UTC
[jira] Created: (FELIX-2173) Fix inconsistent maven->osgi version
conversion between maven-bundle-plugin and DefaultMaven2OsgiConverter
Fix inconsistent maven->osgi version conversion between maven-bundle-plugin and DefaultMaven2OsgiConverter
----------------------------------------------------------------------------------------------------------
Key: FELIX-2173
URL: https://issues.apache.org/jira/browse/FELIX-2173
Project: Felix
Issue Type: Bug
Components: Maven Bundle Plugin
Reporter: Graham Charters
The maven bundle plug converts maven version like : 1.0.0-incubating-SNAPSHOT to 1.0.0.incubating-SNAPSHOT which I think is correct.
The DefaultMaven2OsgiConverter coverts maven version like: 1.0.0-incubating-SNAPSHOT to 1.0.0.incubating_SNAPSHOT which unnecessarily coverts '-' to '_'.
The conversion should be reusable and consistent to ensure they match when used in other plugins or environments. I think the DefaultMaven2OsgiConverter needs to be changed to match the maven bundle plugin.
See also: http://www.mail-archive.com/dev@felix.apache.org/msg15894.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2173) Fix inconsistent maven->osgi version
conversion between maven-bundle-plugin and DefaultMaven2OsgiConverter
Posted by "Stuart McCulloch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844002#action_12844002 ]
Stuart McCulloch commented on FELIX-2173:
-----------------------------------------
Note that the code under "org/apache/maven/shared/osgi" is our locally patched version of the
maven-osgi shared component (http://jira.codehaus.org/browse/MSHARED/component/13273)
Duplicate issues have been raised against the maven-osgi component for each of these local
patches, but have unfortunately not yet been committed/released which is why we're still using
our local copy...
You might want to raise an issue at http://jira.codehaus.org/browse/MSHARED/component/13273
for this additional change, to make sure it's in the shared component when they make a release.
( http://jira.codehaus.org/browse/MSHARED-98 might be related, could attach your patch there? )
> Fix inconsistent maven->osgi version conversion between maven-bundle-plugin and DefaultMaven2OsgiConverter
> ----------------------------------------------------------------------------------------------------------
>
> Key: FELIX-2173
> URL: https://issues.apache.org/jira/browse/FELIX-2173
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Reporter: Graham Charters
> Assignee: Guillaume Nodet
> Fix For: maven-bundle-plugin-2.1.0
>
>
> The maven bundle plug converts maven version like : 1.0.0-incubating-SNAPSHOT to 1.0.0.incubating-SNAPSHOT which I think is correct.
> The DefaultMaven2OsgiConverter coverts maven version like: 1.0.0-incubating-SNAPSHOT to 1.0.0.incubating_SNAPSHOT which unnecessarily coverts '-' to '_'.
> The conversion should be reusable and consistent to ensure they match when used in other plugins or environments. I think the DefaultMaven2OsgiConverter needs to be changed to match the maven bundle plugin.
> See also: http://www.mail-archive.com/dev@felix.apache.org/msg15894.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2173) Fix inconsistent maven->osgi version
conversion between maven-bundle-plugin and DefaultMaven2OsgiConverter
Posted by "Stuart McCulloch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844033#action_12844033 ]
Stuart McCulloch commented on FELIX-2173:
-----------------------------------------
+1 for a common osgi utility module
> Fix inconsistent maven->osgi version conversion between maven-bundle-plugin and DefaultMaven2OsgiConverter
> ----------------------------------------------------------------------------------------------------------
>
> Key: FELIX-2173
> URL: https://issues.apache.org/jira/browse/FELIX-2173
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Reporter: Graham Charters
> Assignee: Guillaume Nodet
> Fix For: maven-bundle-plugin-2.1.0
>
>
> The maven bundle plug converts maven version like : 1.0.0-incubating-SNAPSHOT to 1.0.0.incubating-SNAPSHOT which I think is correct.
> The DefaultMaven2OsgiConverter coverts maven version like: 1.0.0-incubating-SNAPSHOT to 1.0.0.incubating_SNAPSHOT which unnecessarily coverts '-' to '_'.
> The conversion should be reusable and consistent to ensure they match when used in other plugins or environments. I think the DefaultMaven2OsgiConverter needs to be changed to match the maven bundle plugin.
> See also: http://www.mail-archive.com/dev@felix.apache.org/msg15894.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2173) Fix inconsistent maven->osgi version
conversion between maven-bundle-plugin and DefaultMaven2OsgiConverter
Posted by "Stuart McCulloch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844037#action_12844037 ]
Stuart McCulloch commented on FELIX-2173:
-----------------------------------------
PS. the numerous classes come from the Maven component / IoC approach: an API and one or more implementations.
This is so it can be injected by Plexus. (in our case we explicitly set it because we want to use our locally patched code.)
> Fix inconsistent maven->osgi version conversion between maven-bundle-plugin and DefaultMaven2OsgiConverter
> ----------------------------------------------------------------------------------------------------------
>
> Key: FELIX-2173
> URL: https://issues.apache.org/jira/browse/FELIX-2173
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Reporter: Graham Charters
> Assignee: Guillaume Nodet
> Fix For: maven-bundle-plugin-2.1.0
>
>
> The maven bundle plug converts maven version like : 1.0.0-incubating-SNAPSHOT to 1.0.0.incubating-SNAPSHOT which I think is correct.
> The DefaultMaven2OsgiConverter coverts maven version like: 1.0.0-incubating-SNAPSHOT to 1.0.0.incubating_SNAPSHOT which unnecessarily coverts '-' to '_'.
> The conversion should be reusable and consistent to ensure they match when used in other plugins or environments. I think the DefaultMaven2OsgiConverter needs to be changed to match the maven bundle plugin.
> See also: http://www.mail-archive.com/dev@felix.apache.org/msg15894.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-2173) Fix inconsistent maven->osgi version
conversion between maven-bundle-plugin and DefaultMaven2OsgiConverter
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved FELIX-2173.
------------------------------------
Resolution: Fixed
Fix Version/s: maven-bundle-plugin-2.1.0
Assignee: Guillaume Nodet
Committing to https://svn.apache.org/repos/asf/felix/trunk ...
M bundleplugin/src/main/java/org/apache/felix/bundleplugin/BundlePlugin.java
M bundleplugin/src/main/java/org/apache/maven/shared/osgi/DefaultMaven2OsgiConverter.java
M bundleplugin/src/test/java/org/apache/felix/bundleplugin/BundlePluginTest.java
Committed r919426
Switch to a modified version of the BNR version cleaner.
> Fix inconsistent maven->osgi version conversion between maven-bundle-plugin and DefaultMaven2OsgiConverter
> ----------------------------------------------------------------------------------------------------------
>
> Key: FELIX-2173
> URL: https://issues.apache.org/jira/browse/FELIX-2173
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Reporter: Graham Charters
> Assignee: Guillaume Nodet
> Fix For: maven-bundle-plugin-2.1.0
>
>
> The maven bundle plug converts maven version like : 1.0.0-incubating-SNAPSHOT to 1.0.0.incubating-SNAPSHOT which I think is correct.
> The DefaultMaven2OsgiConverter coverts maven version like: 1.0.0-incubating-SNAPSHOT to 1.0.0.incubating_SNAPSHOT which unnecessarily coverts '-' to '_'.
> The conversion should be reusable and consistent to ensure they match when used in other plugins or environments. I think the DefaultMaven2OsgiConverter needs to be changed to match the maven bundle plugin.
> See also: http://www.mail-archive.com/dev@felix.apache.org/msg15894.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2173) Fix inconsistent maven->osgi version
conversion between maven-bundle-plugin and DefaultMaven2OsgiConverter
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844031#action_12844031 ]
Guillaume Nodet commented on FELIX-2173:
----------------------------------------
Done, though I'm not sure why we need those three classes, only for computing the version (I don't think the bundle symbolic name computation is really used in our case).
We only need a static method for that, not an interface, an implementation and a class.
I still plan to start a module for common osgi code (version range, version cleaning, etc...), that way, maven could reuse it if needed.
> Fix inconsistent maven->osgi version conversion between maven-bundle-plugin and DefaultMaven2OsgiConverter
> ----------------------------------------------------------------------------------------------------------
>
> Key: FELIX-2173
> URL: https://issues.apache.org/jira/browse/FELIX-2173
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Reporter: Graham Charters
> Assignee: Guillaume Nodet
> Fix For: maven-bundle-plugin-2.1.0
>
>
> The maven bundle plug converts maven version like : 1.0.0-incubating-SNAPSHOT to 1.0.0.incubating-SNAPSHOT which I think is correct.
> The DefaultMaven2OsgiConverter coverts maven version like: 1.0.0-incubating-SNAPSHOT to 1.0.0.incubating_SNAPSHOT which unnecessarily coverts '-' to '_'.
> The conversion should be reusable and consistent to ensure they match when used in other plugins or environments. I think the DefaultMaven2OsgiConverter needs to be changed to match the maven bundle plugin.
> See also: http://www.mail-archive.com/dev@felix.apache.org/msg15894.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (FELIX-2173) Fix inconsistent
maven->osgi version conversion between maven-bundle-plugin and
DefaultMaven2OsgiConverter
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841874#action_12841874 ]
Guillaume Nodet edited comment on FELIX-2173 at 3/5/10 2:27 PM:
----------------------------------------------------------------
Committing to https://svn.apache.org/repos/asf/felix/trunk ...
M bundleplugin/src/main/java/org/apache/felix/bundleplugin/BundlePlugin.java
M bundleplugin/src/main/java/org/apache/maven/shared/osgi/DefaultMaven2OsgiConverter.java
M bundleplugin/src/test/java/org/apache/felix/bundleplugin/BundlePluginTest.java
Committed r919426
Switch to a modified version of the BND version cleaner.
was (Author: gnt):
Committing to https://svn.apache.org/repos/asf/felix/trunk ...
M bundleplugin/src/main/java/org/apache/felix/bundleplugin/BundlePlugin.java
M bundleplugin/src/main/java/org/apache/maven/shared/osgi/DefaultMaven2OsgiConverter.java
M bundleplugin/src/test/java/org/apache/felix/bundleplugin/BundlePluginTest.java
Committed r919426
Switch to a modified version of the BNR version cleaner.
> Fix inconsistent maven->osgi version conversion between maven-bundle-plugin and DefaultMaven2OsgiConverter
> ----------------------------------------------------------------------------------------------------------
>
> Key: FELIX-2173
> URL: https://issues.apache.org/jira/browse/FELIX-2173
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Reporter: Graham Charters
> Assignee: Guillaume Nodet
> Fix For: maven-bundle-plugin-2.1.0
>
>
> The maven bundle plug converts maven version like : 1.0.0-incubating-SNAPSHOT to 1.0.0.incubating-SNAPSHOT which I think is correct.
> The DefaultMaven2OsgiConverter coverts maven version like: 1.0.0-incubating-SNAPSHOT to 1.0.0.incubating_SNAPSHOT which unnecessarily coverts '-' to '_'.
> The conversion should be reusable and consistent to ensure they match when used in other plugins or environments. I think the DefaultMaven2OsgiConverter needs to be changed to match the maven bundle plugin.
> See also: http://www.mail-archive.com/dev@felix.apache.org/msg15894.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.