You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/23 18:23:54 UTC
[GitHub] [airflow] potiuk opened a new pull request #17196: Fix wrong connection name in Druid Hook
potiuk opened a new pull request #17196:
URL: https://github.com/apache/airflow/pull/17196
The connection attribute name was wrong
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #17196: Fix wrong connection name in Druid Hook
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #17196:
URL: https://github.com/apache/airflow/pull/17196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #17196: Fix wrong connection name in Druid Hook
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17196:
URL: https://github.com/apache/airflow/pull/17196#discussion_r675826018
##########
File path: airflow/providers/apache/druid/hooks/druid.py
##########
@@ -136,7 +136,7 @@ class DruidDbApiHook(DbApiHook):
For ingestion, please use druidHook.
"""
- conn_name_attr = 'druid_broker_conn_id'
+ conn_name_attr = 'conn_id'
Review comment:
Right, I close that one and take a closer look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17196: Fix wrong connection name in Druid Hook
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17196:
URL: https://github.com/apache/airflow/pull/17196#issuecomment-886218115
Yeah. It was false alarm. All works fine for my original implementation - just double checked it. I think it was an error on user side (workers were still using old provider) and I will ask the user to try it again when I release rc2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #17196: Fix wrong connection name in Druid Hook
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #17196:
URL: https://github.com/apache/airflow/pull/17196#discussion_r675800071
##########
File path: airflow/providers/apache/druid/hooks/druid.py
##########
@@ -136,7 +136,7 @@ class DruidDbApiHook(DbApiHook):
For ingestion, please use druidHook.
"""
- conn_name_attr = 'druid_broker_conn_id'
+ conn_name_attr = 'conn_id'
Review comment:
Can you explain this change a bit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #17196: Fix wrong connection name in Druid Hook
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #17196:
URL: https://github.com/apache/airflow/pull/17196#discussion_r675804493
##########
File path: airflow/providers/apache/druid/hooks/druid.py
##########
@@ -136,7 +136,7 @@ class DruidDbApiHook(DbApiHook):
For ingestion, please use druidHook.
"""
- conn_name_attr = 'druid_broker_conn_id'
+ conn_name_attr = 'conn_id'
Review comment:
I don't think this is a wrong connection name -- we use the same everywhere for other hooks too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17196: Fix wrong connection name in Druid Hook
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17196:
URL: https://github.com/apache/airflow/pull/17196#issuecomment-885820732
Last one to release providers :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org