You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/09/09 06:54:55 UTC
[GitHub] [airflow] Khrol commented on a change in pull request #6034:
[AIRFLOW-5343] Remove legacy way of pessimistic disconnect handling
Khrol commented on a change in pull request #6034: [AIRFLOW-5343] Remove legacy way of pessimistic disconnect handling
URL: https://github.com/apache/airflow/pull/6034#discussion_r322086884
##########
File path: airflow/config_templates/default_airflow.cfg
##########
@@ -125,11 +125,7 @@ sql_alchemy_pool_recycle = 1800
# Check connection at the start of each connection pool checkout.
# Typically, this is a simple statement like “SELECT 1”.
# More information here: https://docs.sqlalchemy.org/en/13/core/pooling.html#disconnect-handling-pessimistic
-sql_alchemy_pool_pre_ping = False
-
-# How many seconds to retry re-establishing a DB connection after
-# disconnects. Setting this to 0 disables retries.
-sql_alchemy_reconnect_timeout = 300
Review comment:
If connection from the pool is not healthy, it's removed from the pool and new one is created (with three attempts). Other connections are invalidated from the pool as well.
https://github.com/sqlalchemy/sqlalchemy/commit/f881dae8179b94f72ab0dc85d8f62be8c9ce2fe0#diff-31816cdb15e64b0af1b862f51abe1226R920 - the test visualizes this.
This commit from SQLAlchemy is quite a good explanation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services