You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2007/12/07 16:55:43 UTC

[jira] Created: (JCR-1262) AbstractWebdavServlet and SimpleWebdavServlet changes

AbstractWebdavServlet and SimpleWebdavServlet changes
-----------------------------------------------------

                 Key: JCR-1262
                 URL: https://issues.apache.org/jira/browse/JCR-1262
             Project: Jackrabbit
          Issue Type: Improvement
          Components: jackrabbit-jcr-server
            Reporter: Felix Meschberger


The AbstractWebdavServlet has been copied from the jcr-server to the webdav project. The class at the old location has been marked deprecated. I suggest that in addition to marking it deprecated we should have this class extend the new AbstractWebdavServlet class from the webdav project but not contain any fields and methods. This way, users of the old class will always get the newest and best version but can still use the old class.

Additionally, in line with isse JCR-417, I suggest to partially move the SimpleWebdavServlet from the jcr-webapp project to the jcr-server project. By partially I mean, that the new (moved) servlet will be abstract and the getRepository() method will be abstract to. The jcr-webapp project will still contain a SimpleWebdavServlet (for backwards compatibility maintaing the same name) which just extends the new servlet and implements the getRepository() method using the RepositoryAccess servlet.

This second step allows for the reuse of the jcr-server project including the abstract SimpleWebdavServlet in other environments. My intention is to include this project (along with the webdav) project in Sling.

Will provide patches for this proposal

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-1262) Deprecated AbstractWebdavServlet should be empty and extend new AbstractWebdavServlet

Posted by "angela (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela updated JCR-1262:
------------------------

    Fix Version/s: 1.4

scheduled for 1.4

> Deprecated AbstractWebdavServlet should be empty and extend new AbstractWebdavServlet
> -------------------------------------------------------------------------------------
>
>                 Key: JCR-1262
>                 URL: https://issues.apache.org/jira/browse/JCR-1262
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-server
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: 1.4
>
>         Attachments: JCR-1262.patch
>
>
> The AbstractWebdavServlet has been copied from the jcr-server to the webdav project. The class at the old location has been marked deprecated. I suggest that in addition to marking it deprecated we should have this class extend the new AbstractWebdavServlet class from the webdav project but not contain any fields and methods. This way, users of the old class will always get the newest and best version but can still use the old class.
> Will provide a patch for this proposal

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-1262) Deprecated AbstractWebdavServlet should be empty and extend new AbstractWebdavServlet

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger updated JCR-1262:
-----------------------------------

    Attachment: JCR-1262.patch

Patch implementing proposed change to the AbstractWebdavServlet:

  - Extend new AbstractWebdavServlet
  - Remove all methods

> Deprecated AbstractWebdavServlet should be empty and extend new AbstractWebdavServlet
> -------------------------------------------------------------------------------------
>
>                 Key: JCR-1262
>                 URL: https://issues.apache.org/jira/browse/JCR-1262
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-server
>            Reporter: Felix Meschberger
>         Attachments: JCR-1262.patch
>
>
> The AbstractWebdavServlet has been copied from the jcr-server to the webdav project. The class at the old location has been marked deprecated. I suggest that in addition to marking it deprecated we should have this class extend the new AbstractWebdavServlet class from the webdav project but not contain any fields and methods. This way, users of the old class will always get the newest and best version but can still use the old class.
> Will provide a patch for this proposal

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-1262) Deprecated AbstractWebdavServlet should be empty and extend new AbstractWebdavServlet

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger updated JCR-1262:
-----------------------------------

    Description: 
The AbstractWebdavServlet has been copied from the jcr-server to the webdav project. The class at the old location has been marked deprecated. I suggest that in addition to marking it deprecated we should have this class extend the new AbstractWebdavServlet class from the webdav project but not contain any fields and methods. This way, users of the old class will always get the newest and best version but can still use the old class.

Will provide a patch for this proposal

  was:
The AbstractWebdavServlet has been copied from the jcr-server to the webdav project. The class at the old location has been marked deprecated. I suggest that in addition to marking it deprecated we should have this class extend the new AbstractWebdavServlet class from the webdav project but not contain any fields and methods. This way, users of the old class will always get the newest and best version but can still use the old class.

Additionally, in line with isse JCR-417, I suggest to partially move the SimpleWebdavServlet from the jcr-webapp project to the jcr-server project. By partially I mean, that the new (moved) servlet will be abstract and the getRepository() method will be abstract to. The jcr-webapp project will still contain a SimpleWebdavServlet (for backwards compatibility maintaing the same name) which just extends the new servlet and implements the getRepository() method using the RepositoryAccess servlet.

This second step allows for the reuse of the jcr-server project including the abstract SimpleWebdavServlet in other environments. My intention is to include this project (along with the webdav) project in Sling.

Will provide patches for this proposal

        Summary: Deprecated AbstractWebdavServlet should be empty and extend new AbstractWebdavServlet  (was: AbstractWebdavServlet and SimpleWebdavServlet changes)

Reducing the extent of this issue to the modification of the AbstractWebdavServlet as suggested by Angela. See JCR-1263 for the former second part regarding the SimpleWebdavServlet.

> Deprecated AbstractWebdavServlet should be empty and extend new AbstractWebdavServlet
> -------------------------------------------------------------------------------------
>
>                 Key: JCR-1262
>                 URL: https://issues.apache.org/jira/browse/JCR-1262
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-server
>            Reporter: Felix Meschberger
>
> The AbstractWebdavServlet has been copied from the jcr-server to the webdav project. The class at the old location has been marked deprecated. I suggest that in addition to marking it deprecated we should have this class extend the new AbstractWebdavServlet class from the webdav project but not contain any fields and methods. This way, users of the old class will always get the newest and best version but can still use the old class.
> Will provide a patch for this proposal

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (JCR-1262) Deprecated AbstractWebdavServlet should be empty and extend new AbstractWebdavServlet

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger closed JCR-1262.
----------------------------------

    Resolution: Fixed

Fixed in Rev. 603175.

> Deprecated AbstractWebdavServlet should be empty and extend new AbstractWebdavServlet
> -------------------------------------------------------------------------------------
>
>                 Key: JCR-1262
>                 URL: https://issues.apache.org/jira/browse/JCR-1262
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-server
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>         Attachments: JCR-1262.patch
>
>
> The AbstractWebdavServlet has been copied from the jcr-server to the webdav project. The class at the old location has been marked deprecated. I suggest that in addition to marking it deprecated we should have this class extend the new AbstractWebdavServlet class from the webdav project but not contain any fields and methods. This way, users of the old class will always get the newest and best version but can still use the old class.
> Will provide a patch for this proposal

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1262) AbstractWebdavServlet and SimpleWebdavServlet changes

Posted by "angela (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549455 ] 

angela commented on JCR-1262:
-----------------------------

hi felix

may i ask you to create separate issues for different things?
it makes discussions and issue-resolution hard if various issues are packed into one.

in this special case the 2 issues also affect different jackrabbit projects. one more reason to keep it in separate issues.

thanks a lot
angela

> AbstractWebdavServlet and SimpleWebdavServlet changes
> -----------------------------------------------------
>
>                 Key: JCR-1262
>                 URL: https://issues.apache.org/jira/browse/JCR-1262
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-server
>            Reporter: Felix Meschberger
>
> The AbstractWebdavServlet has been copied from the jcr-server to the webdav project. The class at the old location has been marked deprecated. I suggest that in addition to marking it deprecated we should have this class extend the new AbstractWebdavServlet class from the webdav project but not contain any fields and methods. This way, users of the old class will always get the newest and best version but can still use the old class.
> Additionally, in line with isse JCR-417, I suggest to partially move the SimpleWebdavServlet from the jcr-webapp project to the jcr-server project. By partially I mean, that the new (moved) servlet will be abstract and the getRepository() method will be abstract to. The jcr-webapp project will still contain a SimpleWebdavServlet (for backwards compatibility maintaing the same name) which just extends the new servlet and implements the getRepository() method using the RepositoryAccess servlet.
> This second step allows for the reuse of the jcr-server project including the abstract SimpleWebdavServlet in other environments. My intention is to include this project (along with the webdav) project in Sling.
> Will provide patches for this proposal

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1262) AbstractWebdavServlet and SimpleWebdavServlet changes

Posted by "angela (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549457 ] 

angela commented on JCR-1262:
-----------------------------

a part from that... i'm in favour of the proposed changes.

> AbstractWebdavServlet and SimpleWebdavServlet changes
> -----------------------------------------------------
>
>                 Key: JCR-1262
>                 URL: https://issues.apache.org/jira/browse/JCR-1262
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-server
>            Reporter: Felix Meschberger
>
> The AbstractWebdavServlet has been copied from the jcr-server to the webdav project. The class at the old location has been marked deprecated. I suggest that in addition to marking it deprecated we should have this class extend the new AbstractWebdavServlet class from the webdav project but not contain any fields and methods. This way, users of the old class will always get the newest and best version but can still use the old class.
> Additionally, in line with isse JCR-417, I suggest to partially move the SimpleWebdavServlet from the jcr-webapp project to the jcr-server project. By partially I mean, that the new (moved) servlet will be abstract and the getRepository() method will be abstract to. The jcr-webapp project will still contain a SimpleWebdavServlet (for backwards compatibility maintaing the same name) which just extends the new servlet and implements the getRepository() method using the RepositoryAccess servlet.
> This second step allows for the reuse of the jcr-server project including the abstract SimpleWebdavServlet in other environments. My intention is to include this project (along with the webdav) project in Sling.
> Will provide patches for this proposal

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (JCR-1262) Deprecated AbstractWebdavServlet should be empty and extend new AbstractWebdavServlet

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger reassigned JCR-1262:
--------------------------------------

    Assignee: Felix Meschberger

> Deprecated AbstractWebdavServlet should be empty and extend new AbstractWebdavServlet
> -------------------------------------------------------------------------------------
>
>                 Key: JCR-1262
>                 URL: https://issues.apache.org/jira/browse/JCR-1262
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-jcr-server
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>         Attachments: JCR-1262.patch
>
>
> The AbstractWebdavServlet has been copied from the jcr-server to the webdav project. The class at the old location has been marked deprecated. I suggest that in addition to marking it deprecated we should have this class extend the new AbstractWebdavServlet class from the webdav project but not contain any fields and methods. This way, users of the old class will always get the newest and best version but can still use the old class.
> Will provide a patch for this proposal

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.