You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/15 06:42:22 UTC
[GitHub] [dubbo-go-hessian2] sanxun0325 opened a new pull request #289: convert pointer to encode
sanxun0325 opened a new pull request #289:
URL: https://github.com/apache/dubbo-go-hessian2/pull/289
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
When a user implements custom POJOs and uses non-pointer POJOs to encode, the encoding fails to transfer poJOs forcibly. As a result, the program execution fails to meet expectations
When non-pointer structures are encoded, they are uniformly converted to Pointers for encoding
、
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter commented on pull request #289: convert pointer to encode
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #289:
URL: https://github.com/apache/dubbo-go-hessian2/pull/289#issuecomment-968654369
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#289](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (146bb9b) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/3a4ef0be57cec0ab889e3a0b22e546df24e2e6a8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a4ef0b) will **decrease** coverage by `0.09%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #289 +/- ##
==========================================
- Coverage 70.26% 70.16% -0.10%
==========================================
Files 27 27
Lines 3033 3040 +7
==========================================
+ Hits 2131 2133 +2
- Misses 677 681 +4
- Partials 225 226 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [codec.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29kZWMuZ28=) | `69.51% <100.00%> (+0.50%)` | :arrow_up: |
| [encode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5jb2RlLmdv) | `78.26% <100.00%> (+0.58%)` | :arrow_up: |
| [serialize.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VyaWFsaXplLmdv) | `66.66% <100.00%> (ø)` | |
| [java\_sql\_time.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YV9zcWxfdGltZS5nbw==) | `63.88% <0.00%> (-2.78%)` | :arrow_down: |
| [ref.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVmLmdv) | `83.78% <0.00%> (-2.71%)` | :arrow_down: |
| [pojo.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cG9qby5nbw==) | `63.46% <0.00%> (-0.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3a4ef0b...146bb9b](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo edited a comment on pull request #289: convert pointer to encode
Posted by GitBox <gi...@apache.org>.
wongoo edited a comment on pull request #289:
URL: https://github.com/apache/dubbo-go-hessian2/pull/289#issuecomment-968662872
@sanxun0325 I think it's definition issue, if define `JavaClassName` on struct pointer , then not encode the non-pointer struct instance.
If u want encode the non-pointer struct instance, define `JavaClassName` on the struct directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo commented on pull request #289: convert pointer to encode
Posted by GitBox <gi...@apache.org>.
wongoo commented on pull request #289:
URL: https://github.com/apache/dubbo-go-hessian2/pull/289#issuecomment-968662872
@sanxun0325 I think it definition issue, if define `JavaClassName` on struct pointer , then not encode the non-pointer struct instance.
If u want encode the non-pointer struct instance, define `JavaClassName` on the struct directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo merged pull request #289: convert pointer to encode
Posted by GitBox <gi...@apache.org>.
wongoo merged pull request #289:
URL: https://github.com/apache/dubbo-go-hessian2/pull/289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter edited a comment on pull request #289: convert pointer to encode
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #289:
URL: https://github.com/apache/dubbo-go-hessian2/pull/289#issuecomment-968654369
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#289](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (948e953) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/3a4ef0be57cec0ab889e3a0b22e546df24e2e6a8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a4ef0b) will **decrease** coverage by `0.18%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #289 +/- ##
==========================================
- Coverage 70.26% 70.07% -0.19%
==========================================
Files 27 27
Lines 3033 3041 +8
==========================================
Hits 2131 2131
- Misses 677 683 +6
- Partials 225 227 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [codec.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29kZWMuZ28=) | `69.51% <100.00%> (+0.50%)` | :arrow_up: |
| [encode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5jb2RlLmdv) | `78.26% <100.00%> (+0.58%)` | :arrow_up: |
| [serialize.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VyaWFsaXplLmdv) | `66.66% <100.00%> (ø)` | |
| [java\_sql\_time.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YV9zcWxfdGltZS5nbw==) | `61.11% <0.00%> (-5.56%)` | :arrow_down: |
| [ref.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVmLmdv) | `83.78% <0.00%> (-2.71%)` | :arrow_down: |
| [object.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2JqZWN0Lmdv) | `65.69% <0.00%> (-0.59%)` | :arrow_down: |
| [pojo.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cG9qby5nbw==) | `64.11% <0.00%> (+0.17%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3a4ef0b...948e953](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/289?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org