[GitHub] [pinot] heatclub commented on a diff in pull request #10411: Retry segment untar failures

["heatclub (via GitHub)" <gi...@apache.org>]

heatclub commented on code in PR #10411:
URL: https://github.com/apache/pinot/pull/10411#discussion_r1133886860


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -644,12 +659,13 @@ private File downloadAndStreamUntarWithRateLimit(String segmentName, SegmentZKMe
   }
 
   @VisibleForTesting
-  File untarAndMoveSegment(String segmentName, File tarFile, File tempRootDir)
+  protected File untarAndMoveSegment(String segmentName, File tarFile, File tempRootDir)
       throws IOException {
     File untarDir = new File(tempRootDir, segmentName);
     try {
       // If an exception is thrown when untarring, it means the tar file is broken
       // or not found after the retry. Thus, there's no need to retry again.
+      // unless untar retry is configured, which will retry this function call

Review Comment:
   That is the premise of this issue: https://github.com/apache/pinot/issues/9152 for which this PR is raised.
   In case of partial/corrupted tar downloads the untar fails, so the download and untar is retried.
   This function is externally retried, so should I remove this comment ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org