You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/28 09:39:34 UTC
[GitHub] [pulsar] congbobo184 opened a new pull request, #17869: [fix][flaky-test] BookKeeperClusterTestCase.setup()
congbobo184 opened a new pull request, #17869:
URL: https://github.com/apache/pulsar/pull/17869
Fixes:
- Prove https://github.com/apache/pulsar/issues/16544 can be solved
### Motivation
now in tests, we getFreePort not occupied, just written in configuration, so it may be created repeatedly. If the socket port is repeatedly, the test will become flaky.
### Modifications
when we getFreePort, the port will be occupied and then if you use completely can release this port.
### Documentation
- [x] `doc-not-needed`
### Matching PR in the forked repository
PR in forked repository:
- https://github.com/congbobo184/pulsar/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui closed pull request #17869: [fix][flaky-test] AdvertisedListenersTest.setup
Posted by GitBox <gi...@apache.org>.
codelipenghui closed pull request #17869: [fix][flaky-test] AdvertisedListenersTest.setup
URL: https://github.com/apache/pulsar/pull/17869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #17869: [fix][flaky-test] AdvertisedListenersTest.setup
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17869:
URL: https://github.com/apache/pulsar/pull/17869#issuecomment-1277029704
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/17869?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@7e4c746`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/pulsar/pull/17869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17869 +/- ##
=========================================
Coverage ? 70.74%
Complexity ? 437
=========================================
Files ? 26
Lines ? 2246
Branches ? 245
=========================================
Hits ? 1589
Misses ? 484
Partials ? 173
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `70.74% <0.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #17869: [fix][test] AdvertisedListenersTest.setup
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #17869:
URL: https://github.com/apache/pulsar/pull/17869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org