[GitHub] [activemq-artemis] clebertsuconic commented on a diff in pull request #4509: ARTEMIS-4314 support queue federation batchOnEmpty via consumerWindow…

["clebertsuconic (via GitHub)" <gi...@apache.org>]

clebertsuconic commented on code in PR #4509:
URL: https://github.com/apache/activemq-artemis/pull/4509#discussion_r1231485362


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/Queue.java:
##########
@@ -389,6 +389,8 @@ default int retryMessages(Filter filter, Integer expectedHits) throws Exception
 
    boolean hasMatchingConsumer(Message message);
 

Review Comment:
   If you're using this outside of ring, I would rename this to something else...
   
   
   getRawMessageCount (terrible name I know.. but anything removing the "ring" term)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org