[GitHub] [incubator-superset] betodealmeida opened a new pull request #7281: Do not use GET requests in Explore view

[GitBox <gi...@apache.org>]

betodealmeida opened a new pull request #7281: Do not use GET requests in Explore view
URL: https://github.com/apache/incubator-superset/pull/7281
 
 
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   With the new chart cache, when we first load the Explore view we perform a `GET` request, to quickly load a cached response (if any). When the user clicks "Run Query", the request is  `POST`ed to `explore_json`, bypassing the response cache but still using the data frame cache in `viz.py`.
   
   One problem with this is that if the user modifies the visualization, saves and reloads the page, they will see the old visualization, because of the browser cache.
   
   We can use the [Application Cache](https://developer.mozilla.org/en-US/docs/Web/HTML/Using_the_application_cache) mechanism to fix that, but it would require keeping a list of cached and invalidated resources. For now, I'd rather just turn off the `GET` requests in the Explore view.
   
   Since we're turning off `GET` requests in Explore view, we can also revert https://github.com/apache/incubator-superset/pull/7255.
   
   <!-- ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF -->
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [X] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org