You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "aFlyBird0 (via GitHub)" <gi...@apache.org> on 2023/05/26 07:42:21 UTC

[GitHub] [incubator-devlake] aFlyBird0 opened a new pull request, #5292: [Feature][Connection]: make sure the connection endpoint ends with "/"

aFlyBird0 opened a new pull request, #5292:
URL: https://github.com/apache/incubator-devlake/pull/5292

   ### Summary
   make sure the connection endpoint ends with "/"
   
   ### Does this close any open issues?
   Closes #4996
   
   ### Screenshots
   Include any relevant screenshots here.
   
   ### Other Information
   
   **Please review carefully, I'm not sure it is the best way.**
   
   I noticed that currently, after receiving JSON information from the frontend, the decoding, validation, and saving to the database are done together, making it difficult to implement custom logic here.
   
   <img width="1029" alt="image" src="https://github.com/apache/incubator-devlake/assets/36830265/81451d38-aca9-40a3-8db6-72951941b7ca">
   
   I also observed that all connections call the NewApiClientFromConnection function and pass connection.GetEndpoint() as the base URL. So, instead of modifying the records in the database, I'm trying to automatically add a / when the endpoint is needed on the backend.
   
   
   <img width="993" alt="image" src="https://github.com/apache/incubator-devlake/assets/36830265/2e55cc26-f1f8-473b-a501-40279f35063e">
   <img width="880" alt="image" src="https://github.com/apache/incubator-devlake/assets/36830265/0018d803-83de-4cdd-8d23-f78093634add">
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] aFlyBird0 commented on pull request #5292: [Feature][Connection]: make sure the connection endpoint ends with "/"

Posted by "aFlyBird0 (via GitHub)" <gi...@apache.org>.
aFlyBird0 commented on PR #5292:
URL: https://github.com/apache/incubator-devlake/pull/5292#issuecomment-1563950927

   cc @Startrekzky @mindlesscloud 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] abeizn merged pull request #5292: [Feature][Connection]: make sure the connection endpoint ends with "/"

Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn merged PR #5292:
URL: https://github.com/apache/incubator-devlake/pull/5292


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org