[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1617: IGNITE-18213 Sql. Make exchange rewindable

["korlov42 (via GitHub)" <gi...@apache.org>]

korlov42 commented on code in PR #1617:
URL: https://github.com/apache/ignite-3/pull/1617#discussion_r1095742820


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/Fragment.java:
##########
@@ -64,19 +73,21 @@ public class Fragment {
      * @param remotes Remote sources of the fragment.
      */
     public Fragment(long id, IgniteRel root, List<IgniteReceiver> remotes) {
-        this(id, root, remotes, null, null);
+        this(id, root, expectsCorrelatesFromOutside(root), remotes, null, null);
     }
 
     /**
      * Constructor.
      * TODO Documentation https://issues.apache.org/jira/browse/IGNITE-15859
      */
-    Fragment(long id, IgniteRel root, List<IgniteReceiver> remotes, @Nullable String rootSer, @Nullable FragmentMapping mapping) {
+    Fragment(long id, IgniteRel root, boolean expectsCorrelatesFromOutside, List<IgniteReceiver> remotes,

Review Comment:
   I reworked this part because of a races (see comment to commit [74fe27e](https://github.com/apache/ignite-3/pull/1617/commits/74fe27ec36f980bc9fe3688deff68ca5a4efbfff) for details). Your suggestion was taken into account



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org