You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Ryan McKinley (JIRA)" <ji...@apache.org> on 2007/07/05 20:59:04 UTC

[jira] Updated: (SOLR-60) Remove overwritePending, overwriteCommitted flags?

     [ https://issues.apache.org/jira/browse/SOLR-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-60:
------------------------------

    Attachment: SOLR-60-Overwrite.patch

This changes AddUpdateCommand to want 'update' and depricates the other flags

   public boolean overwrite = true;
   
   @Deprecated public Boolean allowDups;
   @Deprecated public Boolean overwritePending;
   @Deprecated public Boolean overwriteCommitted;

If any of allowDups, overwritePending, overwriteCommitted are set, it will use old style calculations.  Autoboxing should handle the conversion cleanly.

> Remove overwritePending, overwriteCommitted flags?
> --------------------------------------------------
>
>                 Key: SOLR-60
>                 URL: https://issues.apache.org/jira/browse/SOLR-60
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>            Reporter: Yonik Seeley
>            Priority: Minor
>         Attachments: SOLR-60-Overwrite.patch
>
>
> The overwritePending, overwriteCommitted, allowDups flags seem needlessly complex and don't add much value.  Do people need/use separate control over pending vs committed documents?
> Perhaps all most people need is overwrite=true/false?
> overwritePending, overwriteCommitted were originally added because it was a (mis)feature that another internal search tool had.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.