You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2022/07/04 07:02:28 UTC

[GitHub] [openwhisk] ningyougang commented on a diff in pull request #5265: [Scheduler Enhancement] Remove deleted containers.

ningyougang commented on code in PR #5265:
URL: https://github.com/apache/openwhisk/pull/5265#discussion_r912684739


##########
common/scala/src/main/scala/org/apache/openwhisk/common/Logging.scala:
##########
@@ -593,7 +593,8 @@ object LoggingMarkers {
   val SCHEDULER_KAFKA = LogMarkerToken(scheduler, kafka, start)(MeasurementUnit.time.milliseconds)
   val SCHEDULER_KAFKA_WAIT_TIME =
     LogMarkerToken(scheduler, "kafkaWaitTime", counter)(MeasurementUnit.none)
-  def SCHEDULER_WAIT_TIME(action: String) = LogMarkerToken(scheduler, "waitTime", counter, Some(action), Map("action" -> action))(MeasurementUnit.none)
+  def SCHEDULER_WAIT_TIME(action: String) =
+    LogMarkerToken(scheduler, "waitTime", counter, Some(action), Map("action" -> action))(MeasurementUnit.none)

Review Comment:
   Seems the content is same, just do format.
   Normally, the time unit should be `MeasurementUnit.time.milliseconds`, why here `MeasurementUnit.none`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org